[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2021-10-22 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2021-10-22 14:07:57



--- Comment #8 from Mattia Verga  ---
Package was imported, then orphaned. Closing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1893901
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901



--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ansible-base


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-14 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901



--- Comment #6 from Kevin Fenzi  ---
Thanks so much for the review!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-08 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin   ---
(In reply to Kevin Fenzi from comment #4)
> I'm fine removing all the .git_keep and .travis.yml, but these two I think
> are used by ansible_test:
> 
> > /usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc
> > ansible-base.noarch: E: zero-length
> > /usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg
> > ansible-base.noarch: E: zero-length
> 

Sure!

>  >  - Please don't forget to clean the Sphinx build leftovers here
> > 
> > %if 0%{?with_docs}
> >   make PYTHON=/usr/bin/python3 SPHINXBUILD=sphinx-build-3 webdocs
> > %else
> 
> Can you expand on what build leftovers should be cleaned? Is there a
> guideline?
> 
Sphinx building leaves hidden files that should be removed:

# remove the sphinx-build leftovers
rm -rf docs/docsite/_build/html/.{doctrees,buildinfo}

Although you don't build the doc, I think this shoild be added for the future.


Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-07 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901



--- Comment #4 from Kevin Fenzi  ---
(In reply to Robert-André Mauchin  from comment #3)
> > These are harmless I think: 
> 
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/.travis.yml
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.
> git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/.travis.yml
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.
> git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.
> git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/
> roles/.git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/
> .git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/.travis.yml
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.
> git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.
> git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/.travis.yml
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep
> ansible-base.noarch: W: hidden-file-or-dir
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.
> git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.
> git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.
> git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/
> roles/.git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/
> .git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.
> git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.
> git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep
> 
> 
> Please remove them.

I'm fine removing all the .git_keep and .travis.yml, but these two I think are
used by ansible_test:

> /usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc
> ansible-base.noarch: E: zero-length
> /usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg
> ansible-base.noarch: E: zero-length

> 
>  - Would prefer you use %bcond_with/%bcond_without
> 
> %global with_tests 1

I suppose. I hate it's syntax, but sure. 

> 
> 
>  - Please document why this patch is needed:
> 
> Patch1:  2.10.3-test-patch.patch

Done.

 >  - Please don't forget to clean the Sphinx build leftovers here
> 
> %if 0%{?with_docs}
>   make PYTHON=/usr/bin/python3 SPHINXBUILD=sphinx-build-3 webdocs
> %else

Can you expand on what build leftovers should be cleaned? Is there a guideline?

> 
>  - manpages should not be marked as %doc:

Indeed. fixed. 

> %{_mandir}/man1/ansible*
> 
>  - that don't work for whole dir, use:
> 
> %dir %{_sysconfdir}/ansible/
> %config(noreplace) %{_sysconfdir}/ansible/*

Fixed.

>  - What the point of this: 
> 
> cp -pr docs/docsite/rst .
> %if 0%{?with_docs}
>   cp -pr docs/docsite/_build/html %{_builddir}/%{name}-%{version}/html
> %endif
> 
> You could directly include the docs with:
> 
> %files -n ansible-base-doc
> %doc docs/docsite/rst
> %if 0%{?with_docs}
> %doc docs/docsite/_build/html
> %endif

Yeah, you are right. Dropped that. 

Here's the diff: 

5c5
< %global with_docs 0
---
> %bcond_with docs
10c10
< %global with_tests 1
---
> %bcond_with tests
23d22
< Patch1:  2.10.3-test-patch.patch
30c29,33
< %if

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-07 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901

Robert-André Mauchin   changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin   ---
> These are harmless I think: 

ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/network/.travis.yml
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/.travis.yml
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/roles/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/container/.travis.yml
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/.travis.yml
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep
ansible-base.noarch: W: hidden-file-or-dir
/usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/roles/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep
ansible-base.noarch: E: zero-length
/usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep


Please remove them.

 - Would prefer you use %bcond_with/%bcond_without

%global with_tests 1


 - Please document why this patch is needed:

Patch1:  2.10.3-test-patch.patch

 - Please don't forget to clean the Sphinx build leftovers here

%if 0%{?with_docs}
  make PYTHON=/usr/bin/python3 SPHINXBUILD=sphinx-build-3 webdocs
%else

 - manpages should not be marked as %doc:

%{_mandir}/man1/ansible*

 - that don't work for whole dir, use:

%dir %{_sysconfdir}/ansible/
%config(noreplace) %{_sysconfdir}/ansible/*

 - What the point of this: 

cp -pr docs/docsite/rst .
%if 0%{?with_docs}
  cp -pr docs/docsite/_build/html %{_builddir}/%{name}-%{version}/html
%endif

You could directly include the docs with:

%files -n ansible-base-doc
%doc docs/docsite/rst
%if 0%{?with_docs}
%doc docs/docsite/_build/html
%endif


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-05 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901

farro...@redhat.com changed:

   What|Removed |Added

 CC||farro...@redhat.com



--- Comment #2 from farro...@redhat.com ---
@Kevin : I'm still myself confused with ansible vs ansible-base : when I read
latest "Bullhorn" mail, I see that both ansible and ansible-base seem to exist
: https://mailchi.mp/redhat/the-bullhorn-13
While it seems that ansible itself (2.10) can be used a simple replacement for
previous ansible, the new ansible-base seems "lightweight" and only just core
and one or two plugins.
Do you still plan to have ansible itself targetting 2.10 (like upstream) or
just packaging from now ansible-base (and forget about ansible, which still
seems to exist) ? :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

2020-11-03 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1893901



--- Comment #1 from Kevin Fenzi  ---
Updated to 2.10.3:

Spec URL:
https://www.scrye.com/~kevin/fedora/ansible-base-review/ansible-base.spec
SRPM URL:
https://www.scrye.com/~kevin/fedora/ansible-base-review/ansible-base-2.10.3-1.fc34.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org