[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #15 from Fedora Update System --- FEDORA-2021-9cb3f46ded has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-11 23:38:01 --- Comment #14 from Fedora Update System --- FEDORA-2021-6fe42e6a2c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #13 from Fedora Update System --- FEDORA-2021-6fe42e6a2c has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6fe42e6a2c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6fe42e6a2c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- FEDORA-2021-9cb3f46ded has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9cb3f46ded \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9cb3f46ded See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #11 from Fedora Update System --- FEDORA-2021-6fe42e6a2c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6fe42e6a2c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2021-9cb3f46ded has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9cb3f46ded -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #9 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/j4-dmenu-desktop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin 🐧 --- Sponsored + refreshing flag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Robert-André Mauchin 🐧 changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review+ | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Robert-André Mauchin 🐧 changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin 🐧 --- Package approved but you still need to find a sponsor: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #6 from Tobias Florek --- Oh, I did not know that you could get it by a different filename. That's neat. I fixed it as well as the (slight not as) useless use of cat. Thanks you! > [?]: Package functions as described. I will note, that I have been using that package daily since November, so it works for me. New Spec File (same URL as above): https://gitlab.com/ibotty/j4-dmenu-desktop-rpm-spec/-/raw/main/j4-dmenu-desktop.spec?inline=false -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #5 from Robert-André Mauchin 🐧 ---
(In reply to Tobias Florek from comment #3)
> Thank you for the review!
>
> I fixed all things I could fix.
>
> Unfortunately, I don't control upstream, so I cannot fix the source tarball
> name. I agree that this name is pretty bad.
Github support passing the filename you want after the last / in the url
Source0:
https://github.com/enkore/%{name}/archive/r%{version}/%{name}-%{version}.tar.gz
- why cat and not just cp or install -pm 0644 here:
cat %{name}.1 > %{buildroot}%{_mandir}/man1/%{name}.1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v3.0 or
later", "*No copyright* GNU General Public License v3.0 or later". 31
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/j4-dmenu-desktop/review-j4-dmenu-
desktop/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note:
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #4 from Tobias Florek --- New link to spec and SRPM. Spec URL: https://gitlab.com/ibotty/j4-dmenu-desktop-rpm-spec/-/raw/main/j4-dmenu-desktop.spec?inline=false SRPM URL: https://gitlab.com/ibotty/j4-dmenu-desktop-rpm-spec/-/raw/spec-file/j4-dmenu-desktop-2.18-2.fc33.src.rpm?inline=false -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #3 from Tobias Florek --- Thank you for the review! I fixed all things I could fix. Unfortunately, I don't control upstream, so I cannot fix the source tarball name. I agree that this name is pretty bad. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052
Robert-André Mauchin 🐧 changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Robert-André Mauchin 🐧 ---
- Please give your archive a better name:
Source0:
https://github.com/enkore/%{name}/archive/r%{version}/%{name}-%{version}.tar.gz
- Don't gzip the man page yourself, it is handled by rpm:
gzip < %{name}.1 > %{buildroot}%{_mandir}/man1/%{name}.1.gz
- The license file must be installed with %license not %doc:
%files
%license LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 --- Comment #1 from Tobias Florek --- > $ rpmlint . > 4 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1901052] Review Request: j4-dmenu-desktop - Generic menu for desktop managers
https://bugzilla.redhat.com/show_bug.cgi?id=1901052 Tobias Florek changed: What|Removed |Added Version|rawhide |33 Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
