[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #17 from Fedora Update System --- FEDORA-EPEL-2020-ddeb1f2063 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #16 from Fedora Update System --- FEDORA-EPEL-2020-078d93890e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #15 from Fedora Update System --- FEDORA-2020-4b377f8a28 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-12-15 01:21:16 --- Comment #14 from Fedora Update System --- FEDORA-2020-e034e4c49a has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #13 from Fedora Update System --- FEDORA-2020-e034e4c49a has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e034e4c49a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e034e4c49a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #12 from Fedora Update System --- FEDORA-2020-4b377f8a28 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4b377f8a28 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4b377f8a28 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2020-ddeb1f2063 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ddeb1f2063 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2020-078d93890e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-078d93890e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #9 from Fedora Update System --- FEDORA-EPEL-2020-ddeb1f2063 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ddeb1f2063 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #8 from Fedora Update System --- FEDORA-EPEL-2020-078d93890e has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-078d93890e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #7 from Fedora Update System --- FEDORA-2020-4b377f8a28 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4b377f8a28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-e034e4c49a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e034e4c49a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/endlessh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 Michel Alexandre Salim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Michel Alexandre Salim --- Looks fine! APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Mikel Olasagasti Uranga changed:
What|Removed |Added
Flags|needinfo?(mikel@olasagasti. |
|info) |
--- Comment #3 from Mikel Olasagasti Uranga ---
Thanks for the review Michel Alexandre, I learned new things here.
Updated spec and srpm:
Spec URL: https://mikel.olasagasti.info/tmp/fedora/endlessh.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/endlessh-1.1-2.fc33.src.rpm
- Added missing %dir %{_sysconfdir}/%{name}
- Changed systemd to Req and added BR to systemd-rpm-macros
- Registered systemd unit
- Patched Makefile with sed during %install to use %{optflags}
- Change $RPM_BUILD_ROOT to %{buildroot} to use one style
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Michel Alexandre Salim changed:
What|Removed |Added
Flags||needinfo?(mikel@olasagasti.
||info)
--- Comment #2 from Michel Alexandre Salim ---
Must-fixes:
Directory ownership needs fixing:
- missing %dir %{_sysconfdir}/%{name}
- need to Requires: systemd for ownership of %{_unitdir}
Registering your unit files
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd
for registering and unregistering your systemd service during installation and
uninstallation
Compiler flags not used by Makefile
You'll have to patch the Makefile to support passing %{optflags}; it currently
hardcodes the flags used.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
- systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in endlessh
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_scriptlets
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "the Unlicense", "*No copyright* the
Unlicense". 12 files have unknown license. Detailed output of
licensecheck in
/home/michel/src/fedora/reviews/1904172-endlessh/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /etc/endlessh
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/system,
/etc/endlessh, /usr/lib/systemd
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
missing systemd scriptlets, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() p
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Michel Alexandre Salim changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mic...@michel-slm.name
Assignee|nob...@fedoraproject.org|mic...@michel-slm.name
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Michel Alexandre Salim ---
Taking this review. Some initial notes:
- the BuildRequires on systemd is probably overkill. you can use
systemd-rpm-macros (for %{_unitdir}) and `mkdir -p` it in %install before
copying a file there. At runtime you can assume systemd is installed
- Other BRs are fine (git is used for %autosetup -S git)
- installing files do not preserve permissions, both the additional files you
install as well as the ones by `make install`
- you're not using %make_install, but upstream Makefile doesn't support
DESTDIR and INSTALL which the macro assumes. if you submit a patch to upstream,
it might be worth making it support the variables %make_install uses
These are not blockers though, but consider making the first change before
importing your package, it will speed up the build a bit by pulling in less
dependencies.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
