[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-01-02 16:04:45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/megapixels -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976
Kevin Fenzi changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Kevin Fenzi ---
(In reply to Torrey Sorensen from comment #4)
> Spec URL:
> https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec
> SRPM URL:
> https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-
> rawhide-aarch64/01841904-megapixels/megapixels-0.13.1-2.fc34.src.rpm
> Copr Build:
> https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1841904/
>
> > 1. Why %global debug_package %{nil} ? Don't we want debuginfo?
>
> Yes, we want debuginfo. Removed that line.
Thanks.
> > 2. The package seems to include the inih package bundled in.
> > Might see if you can get it to use inih-devel already packaged in Fedora?
> > If not, you may have to Provides: bundled(inih)
>
> I added inih-devel to BuildRequires.
It doesn't seem to be using it? Not a blocker, but perhaps ask upstream to
detect and use a system version if available?
> > 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config
> > (either via %dir in files, or changing the globbing)
>
> Fixed :)
Thanks.
> > 4. DEBUG util.py:444: warning: bogus date in %changelog:
> > Wed Dec 03 2020 Torrey Sorensen - 0.12.0-2
> > The 3rd was a thursday. ;)
>
> oof, that was dumb of me.
Naw, happens to everyone. ;)
> > 5. It doesn't seem to work here on x86_64:
>
> As mentioned I added ExclusiveArch for the two arm arches.
>
> Tested and still works "as expected" on the PinePhone.
>
>
> Thank you for the review.
Cool. All blockers I see are fixed. Please check into the inih thing with
upstream when you get a chance... This package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976
--- Comment #4 from Torrey Sorensen ---
Spec URL:
https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-aarch64/01841904-megapixels/megapixels-0.13.1-2.fc34.src.rpm
Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1841904/
> 1. Why %global debug_package %{nil} ? Don't we want debuginfo?
Yes, we want debuginfo. Removed that line.
> 2. The package seems to include the inih package bundled in.
> Might see if you can get it to use inih-devel already packaged in Fedora?
> If not, you may have to Provides: bundled(inih)
I added inih-devel to BuildRequires.
> 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config
> (either via %dir in files, or changing the globbing)
Fixed :)
> 4. DEBUG util.py:444: warning: bogus date in %changelog:
> Wed Dec 03 2020 Torrey Sorensen - 0.12.0-2
> The 3rd was a thursday. ;)
oof, that was dumb of me.
> 5. It doesn't seem to work here on x86_64:
As mentioned I added ExclusiveArch for the two arm arches.
Tested and still works "as expected" on the PinePhone.
Thank you for the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976
--- Comment #3 from Peter Robinson ---
> 1. Why %global debug_package %{nil} ? Don't we want debuginfo?
We do :)
> 2. The package seems to include the inih package bundled in.
> Might see if you can get it to use inih-devel already packaged in Fedora?
> If not, you may have to Provides: bundled(inih)
It might be a fork due to something not upstream, or requiring a non stable/LTS
release, if that's the case it should be documented why with comments and if
the former to a ticket for resolution.
> 5. It doesn't seem to work here on x86_64:
>
> Could not read device name from device tree
> Could not find any config file
>
> Is it arm specific? If so, perhaps a ExclusiveArch ?
Looking at the upstream it states "As first step it will get the first
compatible name in the device tree" and reading further on it's VERY dependent
on specific sensors and SoCs so yes, it should be ExclusiveArch to the two arm
arches, it would work with some ARMv7 devices too but I doubt it would work
with the Raspberry Pi.
Ultimately in the short term I think this is fine, in the medium term an app
based on libcamera is what we'll actually need TBH.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976
--- Comment #2 from Kevin Fenzi ---
Issues:
1. Why %global debug_package %{nil} ? Don't we want debuginfo?
2. The package seems to include the inih package bundled in.
Might see if you can get it to use inih-devel already packaged in Fedora?
If not, you may have to Provides: bundled(inih)
3. Need to own /usr/share/megapixels and /usr/share/megapixels/config
(either via %dir in files, or changing the globbing)
4. DEBUG util.py:444: warning: bogus date in %changelog:
Wed Dec 03 2020 Torrey Sorensen - 0.12.0-2
The 3rd was a thursday. ;)
5. It doesn't seem to work here on x86_64:
Could not read device name from device tree
Could not find any config file
Is it arm specific? If so, perhaps a ExclusiveArch ?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 47 files have unknown license. Detailed
output of licensecheck in /home/kevin/megapixels/review-
megapixels/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/megapixels,
/usr/share/megapixels/config
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/megapixels/config,
/usr/share/megapixels
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED CC||ke...@scrye.com Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #1 from Kevin Fenzi --- I'll review this. Look for a full review in a bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Torrey Sorensen changed: What|Removed |Added Blocks||1817424 (mobility) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1817424 [Bug 1817424] Tracker for mobility SIG activities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Torrey Sorensen changed: What|Removed |Added CC||sorensen...@tuta.io Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
