[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Didik Supriadi changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||didiksupriad...@gmail.com Resolution|--- |CURRENTRELEASE Last Closed|2020-12-15 19:01:39 |2021-10-22 17:08:17 --- Comment #10 from Didik Supriadi --- This package is now in Fedora repo hence closing this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1908038 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 --- Comment #8 from Jerry James --- Thanks for the review, Dan! Unretirement request: https://pagure.io/releng/issue/9924 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 --- Comment #9 from Jerry James --- Oh, I forgot to mention that the fedora-review complaint is because both the main package and the javadoc package contain the license file. Since neither depends on the other, this is necessary. The contents of the file are exactly the same in both cases, so this is okay from an RPM standpoint. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 dan.cer...@cgc-instruments.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #7 from dan.cer...@cgc-instruments.com --- (In reply to Jerry James from comment #6) > Thanks, Dan. I have added a license file to the main package and removed > the duplicate javadocs from the main package. The URLs are the same. The > fixed version is building in COPR now. Hm, fedora-review is still complaining about the directory ownership. However, it's only about /usr/share/licenses/jline2 so I think that should be ok. Thanks for bringing jline2 back! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 --- Comment #6 from Jerry James --- Thanks, Dan. I have added a license file to the main package and removed the duplicate javadocs from the main package. The URLs are the same. The fixed version is building in COPR now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|dan.cermak@cgc-instruments.
||com
--- Comment #5 from dan.cer...@cgc-instruments.com ---
I've managed to build jline2 now, thanks for the tipps Jerry!
Overall the package looks good to me, but there's two issues:
- no license is included in the rpm, although upstream ships one (also in the
tarball: LICENSE.txt)
- something weird is going on with the directory ownership, apparently a whole
bunch of dirs under /usr/share/javadoc/jline2 are owned by the main and by the
javadoc subpackage
Once those are addressed, I'll be more than happy to approve this package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License". 89 files have unknown license. Detailed output of
licensecheck in /home/dan/fedora-scm/1908038-jline2/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/javadoc/jline2(jline2-javadoc),
/usr/share/javadoc/jline2/jline(jline2-javadoc),
/usr/share/javadoc/jline2/jline/class-use(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/class-use(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/completer(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/completer/class-
use(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/history(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/history/class-
use(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/internal(jline2-javadoc),
/usr/share/javadoc/jline2/jline/console/internal/class-
use(jline2-javadoc),
/usr/share/javadoc/jline2/jline/internal(jline2-javadoc),
/usr/share/javadoc/jline2/jline/internal/class-use(jline2-javadoc),
/usr/share/javadoc/jline2/jquery(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/external(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/external/jquery(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/images(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/jszip(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/jszip-utils(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/jszip-utils/dist(jline2-javadoc),
/usr/share/javadoc/jline2/jquery/jszip/dist(jline2-javadoc),
/usr/share/javadoc/jline2/resources(jline2-javadoc)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is prese
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Jerry James changed: What|Removed |Added Flags|needinfo?(loganjerry@gmail. | |com)| --- Comment #4 from Jerry James --- Hi Dan. Sorry, I should have updated the instructions. The jansi1 package has been built into a side tag, f34-build-side-35261. Both jansi1 and this package are also available in COPR: https://copr.fedorainfracloud.org/coprs/jjames/scala/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 dan.cer...@cgc-instruments.com changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com Flags||needinfo?(loganjerry@gmail. ||com) --- Comment #3 from dan.cer...@cgc-instruments.com --- The package cannot be build in Rawhide: No matching package to install: 'mvn(org.fusesource.jansi:jansi:1)' I also cannot build the package even with --enablerepo=local. Could you maybe double check if a build is available? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Jerry James changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened --- Comment #2 from Jerry James --- It turns out that there has been a jline2 package in Fedora before, so the request with --exception was denied. I apparently do need a re-review in order to make jline2 live again. Reopening. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED CC||decatho...@gmail.com Resolution|--- |NOTABUG Last Closed||2020-12-15 19:01:39 --- Comment #1 from Fabio Valentini --- You didn't need to open a review request for a compat package, "fedpkg request-repo" does not need a bug in this case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Bug 1908038 depends on bug 1908037, which changed state. Bug 1908037 Summary: Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java https://bugzilla.redhat.com/show_bug.cgi?id=1908037 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Jerry James changed: What|Removed |Added Depends On||1908037 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1908037 [Bug 1908037] Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
