https://bugzilla.redhat.com/show_bug.cgi?id=1912419
c...@musicinmybrain.net changed:
What|Removed |Added
CC||c...@musicinmybrain.net
--- Comment #1 from c...@musicinmybrain.net ---
Before a full review, would you mind taking care of these?
- The %python_provide macro is obsolete, and you do not even need %py_provides
if you are not packaging for Fedora 32.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
(Somebody really needs to update pyp2rpm to match the current guidelines; the
same things keep coming up over and over.)
- A new version 0.2.2 is available.
- You can use the GitHub tarball and run the tests, because your issue
https://github.com/pogzyb/asyncwhois/issues/10 is now fixed. You’ll need to add
the install_requires as BR’s.
- Upstream added the separate license file in
https://github.com/pogzyb/asyncwhois/pull/11, too.
This is not mandatory, but please consider whether you might want to use the
pyproject-rpm-macros (https://src.fedoraproject.org/rpms/pyproject-rpm-macros).
Generated BR’s are really nice; you get the version requirements from upstream
if applicable, and you’ll never forget to update them. In
https://bugzilla.redhat.com/show_bug.cgi?id=1914450, I provided an example of
rewriting a simple spec file to use the pyproject-rpm-macros. In this case, you
would use “%pyproject_buildrequires -r” to get the install_requires as BR’s,
and ”%pytest” in %check, adding a manual BR on python3dist(pytest).
By the way, if you need to use a GitHub tarball, the %forgemeta macro is really
helpful, *especially* if releases are not properly tagged. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ for
examples.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
