[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 Iztok Fister Jr. changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-01-25 09:42:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-niaaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 Aniket Pradhan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 Aniket Pradhan changed: What|Removed |Added Flags||fedora-review? --- Comment #3 from Aniket Pradhan --- Dear Iztok Thank you for the changes. The spec looks good. rpmlint reports some warnings for the doc subpackage: ``` python-niaaml-doc.noarch: W: description-shorter-than-summary python-niaaml-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-niaaml-doc/html/.buildinfo ``` The .buildinfo can be removed, as it would not be required further, but you can keep it if you want to. The description can also be updated if you want to. Approving the review. :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 --- Comment #2 from Iztok Fister Jr. --- Hi Aniket, Thank you very much for a quick response from your side. I have already pushed a new version to this GH repo. My changes in a nutshell: - line: "%define _unpackaged_files_terminate_build 0" was removed, - two files (CHANGELOG.md and LICENSE in site-packages) are now removed, - tests are still disabled by the upstream. Most of the tests are still in its infancy. Actually, package is very fresh. - BuildRequires were revised, - Good points about the documentation! A new subpackage was created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718
--- Comment #1 from Aniket Pradhan ---
Hello Iztok
* This line should not be used, and you should delete the installed files that
you don't want to package.
```
%define _unpackaged_files_terminate_build 0
```
I saw that the macros create some extra files in the `site-packages` directory
which it shouldn't, hence you should delete those.
```
error: Installed (but unpackaged) file(s) found:
/usr/lib/python3.9/site-packages/CHANGELOG.md
/usr/lib/python3.9/site-packages/LICENSE
```
* Are you sure the tests are running? It doesn't log anything it running the
tests.
* Are you sure the BuildRequires are correct? I don't see python3-wheel as a
dep anywhere.
* Could you also include the documentation as a subpackage? Upstream uses
sphinx to build the docs and it would fit nicely to include it as a subpackage.
* Here is the automated review for the same.
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 152 files have unknown license. Detailed output of
licensecheck in
/home/major/Documents/NeuroFedora/review/1913718-python-
niaaml/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 Aniket Pradhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||aniketpradhan1...@gmail.com Assignee|nob...@fedoraproject.org|aniketpradhan1...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1913718] Review Request: python-niaaml - Python automated machine learning framework
https://bugzilla.redhat.com/show_bug.cgi?id=1913718 Iztok Fister Jr. changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
