[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Bug 1917075 depends on bug 1917073, which changed state. Bug 1917073 Summary: Review Request: cLaTeXMath - A dynamic and cross-platform LaTeX rendering library https://bugzilla.redhat.com/show_bug.cgi?id=1917073 What|Removed |Added Status|POST|CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1917075 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #18 from Fedora Update System --- FEDORA-2021-0f1c379ae3 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-05-17 03:08:37 --- Comment #17 from Fedora Update System --- FEDORA-2021-d528e516ba has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #16 from Fedora Update System --- FEDORA-2021-d528e516ba has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d528e516ba \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d528e516ba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- FEDORA-2021-0f1c379ae3 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0f1c379ae3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0f1c379ae3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #14 from Fedora Update System --- FEDORA-2021-0f1c379ae3 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0f1c379ae3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #13 from Fedora Update System --- FEDORA-2021-d528e516ba has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d528e516ba -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Lyes Saadi changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||notekit-0.1-4.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #12 from Robert-André Mauchin --- Seems good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #11 from Lyes Saadi --- Oh, sorry, I somehow missed this message in my e-mails! Glad I looked again, I was about to push :)! Thank you for the macro, quite handy, I will certainly add this :)! So, am I good to push? Or should I wait a bit more for a cLaTeXMath/jlatexmath answer? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075
--- Comment #10 from Robert-André Mauchin ---
%build
%if %{with clatexmath}
%meson
%else
%meson -Dclatexmath=false
%endif
You can do it that way:
%meson %{!?with_clatexmath:-Dclatexmath=false}
See http://rpm.org/user_doc/conditional_builds.html
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #9 from Lyes Saadi --- Spec URL: https://lyessaadi.fedorapeople.org/reviews/notekit/notekit.spec SRPM URL: https://lyessaadi.fedorapeople.org/reviews/notekit/notekit-0.1-3.fc34.src.rpm - Adding conditional to enable/disable cLaTeXMath - Disabling cLaTeXMath by default due to licensing issues Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=66445752 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #8 from Lyes Saadi --- Hey Robert-André! So, due to the licensing issues with clatexmath (As I found that they even broke the GPL by rewriting a GPL project and relicensing it in MIT), I was unable to move forward. And considering how much this has taken and the inactivity of both clatexmath and jlatexmath, I have decided to take things in my own hands and to remove clatexmath as a dependency through bconds. I will update this bug shortly to send the new version of the specfile :). And since this is a modified version of the specfile, I am not sure whether you need or not to take a look at it. I will push it to repos at the end of the week if you don't have any objection. I hope not to inconvenience you with the problems that those two reviews may have caused you... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #7 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/notekit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #5 from Lyes Saadi --- Spec URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/notekit/notekit.spec SRPM URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/notekit/notekit-0.1-2.fc33.src.rpm - Removing the git-core dependency - Checking for the validity of the Desktop and Metainfo files - Adding a License breakdown - Marking the Charter License as a License - "Unglobing" the icons/hicolor folder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075
--- Comment #4 from Lyes Saadi ---
> - You should check the metainfo filein %install or %check:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
>
> appstream-util validate-relax --nonet
> %{buildroot}%{_metainfodir}/*.metainfo.xml
>
> - And the desktop file:
>
>
> desktop-file-validate %{buildroot}/%{_datadir}/applications/%{uuid}.desktop
Aha! I've added the BuildRequires but somehow forgot to execute the commands
:P!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
- You should check the metainfo filein %install or %check:
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
appstream-util validate-relax --nonet
%{buildroot}%{_metainfodir}/*.metainfo.xml
- And the desktop file:
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{uuid}.desktop
- Install the file 'Charter license.txt' with %license in %files:
%license LICENSE 'data/fonts/Charter license.txt'
- Add the license breakdown aboe the License: field
- Don't glob the entire directory:
%{_datadir}/icons/hicolor/*
instead:
%{_datadir}/icons/hicolor/*/apps/%{uuid}.*
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file Charter license.txt is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v3.0 or
later", "GNU Lesser General Public License v2.1 or later". 74 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/notekit/review-notekit/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor/128x128(redeclipse, qmmp, keepassx, lammps-
data, sxiv, xchm, qucs, klatexformula, freedroidrpg, flatcam, hicolor-
icon-theme, yokadi, wesnoth-data, vacuum-im),
/usr/share/icons/hicolor/128x128/apps(redeclipse, qmmp, keepassx,
lammps-data, sxiv, xchm, alsa-tools, qucs, klatexformula,
freedroidrpg, flatcam, hicolor-icon-theme, yokadi, wesnoth-data,
vacuum-im), /usr/share/icons/hicolor/scalable(qtl866, dxf2gcode, qmmp,
keepassx, wdisplays, eom, autokey-common, pdfmod, qucs, tuxanci,
klatexformula, freedroidrpg, fedora-logos, hicolor-icon-theme, lxqt-
powermanagement, massif-visualizer, swappy),
/usr/share/icons/hicolor/scalable/apps(qtl866, dxf2gcode, qmmp,
keepassx, wdisplays, eom, autokey-common, pdfmod, qucs, tuxanci,
klatexformula, freedroidrpg, fedora-logos, hicolor-icon-theme, swappy,
massif-visualizer)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Lyes Saadi changed: What|Removed |Added Depends On||1917073 Doc Type|--- |If docs needed, set a value --- Comment #1 from Lyes Saadi --- COPR Build: https://copr.fedorainfracloud.org/coprs/lyessaadi/notekit/build/1885524/ This is my first ever software packaged for Fedora, and thus the first ever SPEC file I wrote! Since, it has finally reached its first stable release! Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1917073 [Bug 1917073] Review Request: cLaTeXMath - A dynamic and cross-platform LaTeX rendering library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
