[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2021-03-05 18:55:19




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #12 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-logging


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

  Flags||fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Dusty Mabe  changed:

   What|Removed |Added

 CC||dustym...@redhat.com



--- Comment #11 from Dusty Mabe  ---
Nice work Eric! Thanks Neal!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #10 from ericedens  ---
Great, thanks! Last iteration fixes the lint errors:


Spec URL:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01930355-google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01930355-google-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210202git6cbb518.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #9 from Neal Gompa  ---
I've sponsored Eric Edens as a packager. Welcome to the Fedora packagers group!

Now you are now able to proceed to the next step in the process to add this
package to Fedora.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Neal Gompa  ---
Package was generated through go2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (go2rpm generated spec)
- license correct and valid
- only sources installed
- no serious issues from rpmlint

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #7 from ericedens  ---
fedora-review appears to take the last links on the page, so adding the correct
ones here:

Spec URL:
https://raw.githubusercontent.com/EricEdens/fedora-packages/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/EricEdens/fedora-packages/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm
COPR:
https://copr.fedorainfracloud.org/coprs/ericedens/gcp-guest-packages/build/1905931/
Description: Logging facade for Google Cloud Platform guest agents. Required to
complete .
Fedora Account System Username: ericedens

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #6 from Neal Gompa  ---
Can you please update the Spec URL to point to the raw path to the spec file
itself (not the Github rendered HTML version)? fedora-review is choking on the
current URL.

ngompa@fedkde-ryo-ohki-winvm ~> fedora-review -b 1920606 -m
fedora-rawhide-x86_64
INFO: Processing bugzilla bug: 1920606
INFO: Getting .spec and .srpm Urls from : 1920606
INFO:   --> SRPM url:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm
INFO:   --> Spec url:
https://github.com/EricEdens/fedora-packages/blob/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
INFO: Using review directory:
/home/ngompa/1920606-golang-github-googlecloudplatform-guest-logging
INFO: Downloading .spec and .srpm files
error: line 7: Unknown tag: 
ERROR: "Can't parse specfile: can't parse specfile\n" (logs in
/home/ngompa/.cache/fedora-review.log)
Exception ignored in: 
AttributeError: '_Null' object has no attribute 'flush'


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #5 from ericedens  ---
Updated


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://github.com/EricEdens/fedora-packages/blob/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm
COPR:
https://copr.fedorainfracloud.org/coprs/ericedens/gcp-guest-packages/build/1905931/
Description: Logging facade for Google Cloud Platform guest agents. Required to
complete .
Fedora Account System Username: ericedens

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #4 from Neal Gompa  ---
Eric, the SRPM URL is wrong too. It needs to be the direct path to the SRPM
file built in COPR. Could you please update it to fix that?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||177841 (FE-NEEDSPONSOR)
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Neal Gompa  ---
Taking this review.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606



--- Comment #2 from ericedens  ---
done!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

ericedens  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://github.com/EricEdens/fedora-packages/blob/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec
SRPM URL: 
 -
https://copr.fedorainfracloud.org/coprs/ericedens/gcp-guest-packages/build/1905931/
 -
https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/
Description: Logging facade for Google Cloud Platform guest agents. Required to
complete .
Fedora Account System Username: ericedens

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1920606] Review Request: golang-github-googlecloudplatform-guest-logging - Logging facade used by GCP guest agents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1920606

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Neal Gompa  ---
The "Fedora Account System Username" should be your username in FAS, not your
email address. Could you please edit it to fix that?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org