[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 Mattia Verga changed: What|Removed |Added Resolution|--- |CURRENTRELEASE Status|POST|CLOSED Last Closed||2022-03-05 09:54:32 --- Comment #14 from Mattia Verga --- Package is in repositories, closing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1925322 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 --- Comment #13 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/google-guest-agent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 --- Comment #12 from ericedens --- Requested a repo: ~ fedpkg request-repo google-guest-agent 1925322 https://pagure.io/releng/fedora-scm-requests/issue/32903 > The directory ownership thing with /etc/default doesn't make sense Referring to the `%install` section? For this, I was taking the guidance of [1] which said "The default file mode is 0644 or 0755. Directories should be mode 0755...". [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Neal Gompa --- Everything looks good to me. The directory ownership thing with /etc/default doesn't make sense, since that should be owned by filesystem. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #10 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "*No
copyright* Apache License 2.0", "Apache License 2.0", "BSD 3-clause
"New" or "Revised" License", "zlib/libpng license". 24 files have
unknown license. Detailed output of licensecheck in
/home/ngompa/1925322-google-guest-agent/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /etc/default
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/default
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in google-guest-agent
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 ericedens changed: What|Removed |Added Flags|needinfo?(ericedens@google. | |com)| --- Comment #9 from ericedens --- Created attachment 1761850 --> https://bugzilla.redhat.com/attachment.cgi?id=1761850=edit fedora-review-output.txt - submitted build for golang-github-googlecloudplatform-guest-logging; currently showing live in F35: https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-logging - Ran `fedora-review -b 1925322 -m fedora-rawhide-x86_64`. The build passed, and the results are attached. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 Neal Gompa changed: What|Removed |Added Flags||needinfo?(ericedens@google. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 --- Comment #8 from Neal Gompa --- There are no builds of golang-github-googlecloudplatform-guest-logging: https://koji.fedoraproject.org/koji/packageinfo?packageID=33136 You are listed as the maintainer of this library: https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-logging Please build it for Rawhide so that it actually exists there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 --- Comment #7 from Neal Gompa --- fedora-review fails because the package cannot be built. The error returned when trying to install the build dependencies: * No matching package to install: 'golang(github.com/GoogleCloudPlatform/guest-logging-go/logger)' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 Bug 1925322 depends on bug 1926331, which changed state. Bug 1926331 Summary: systemd presets request - google-guest-agent.service google-startup-scripts.service google-shutdown-scripts.service https://bugzilla.redhat.com/show_bug.cgi?id=1926331 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925322] Review Request: google-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 ericedens changed: What|Removed |Added Summary|Review Request: |Review Request: |golang-github-googlecloudpl |google-guest-agent - Guest |atform-guest-agent - Guest |agent for Google Cloud |agent for Google Cloud |Platform |Platform| --- Comment #6 from ericedens --- Great! Changed to `google-guest-agent`. `fedora-review --copr-build 1963695` passes. SRPM url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-rawhide-x86_64/01963695-google-guest-agent//google-guest-agent-20201217.02-1.fc35.src.rpm Spec url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-rawhide-x86_64/01963695-google-guest-agent//google-guest-agent.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
