[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/chatty -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 --- Comment #10 from sorensen...@tuta.io --- > Before you import it tho, it might be nice to add some comments to the crazy > libjabber areas? Absolutely! Will get that ready while the package repo is being prepped :) Thanks again for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 Kevin Fenzi changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Kevin Fenzi --- Looks good to me, this package is APPROVED. Before you import it tho, it might be nice to add some comments to the crazy libjabber areas? explain why we exclude (don't want other packages to get it from us), why we copy in build (we have to link against it), why we make a ld.so.conf.d file (to allow us to use the private lib at runtime). Just to avoid confusion from people. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 --- Comment #8 from sorensen...@tuta.io --- I like that much better actually. I made those changed and did a build on Copr, tested on my phone and it works as expected still, so that's good! SPEC URL: https://gitlab.com/fedora-mobile/chatty/-/raw/master/chatty.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/02079947-chatty/chatty-0.2.0-5.fc35.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/2079947/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969
--- Comment #7 from Kevin Fenzi ---
ok. After messing with this a bunch yesterday, I see where I was wrong. :)
You do have to copy this private lib and modify the meson config to build
against it.
However, currently you are shipping it in libdir for everything else to see and
use, and it could well get out of date, if say pidgin is updated but chatty
isn't yet.
So, I can offer the following (sadly a bit complex) change:
Exclude requriing libjabber from the chatty rpm.
(If we don't do this, it will expect that library to be provided by either
itself or libpurple, but we don't want to provide it here (because other things
might try and use it and it's not ours) and libpurple doesn't want to provide
it as it's a private library.
> %global __requires_exclude ^libjabber\\.so.*$
For build, the existing patch and copying to /tmp works.
In install add a ld.so.conf.d config to have it look in the purple-2 private
dir for libs:
> mkdir -p %{buildroot}/%{_sysconfdir}/ld.so.conf.d
> echo "%{_libdir}/chatty" >
> %{buildroot}/%{_sysconfdir}/ld.so.conf.d/chatty.conf
Add the conf to files:
> %{_sysconfdir}/ld.so.conf.d/chatty.conf
so, this way, chatty doesn't actually provide or have the library, it's still
in libpurple, it just looks there when installed.
I tested this here and it seemed to all work, but worth testing again in case I
missed something.
It's still not ideal, but I think it's better than shipping the pidgin private
lib in chatty.
Thoughts?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 --- Comment #6 from Kevin Fenzi --- Ack on all the other fixes. On libjabber, I am confused. Looking at it it looks like it should look for it in the pidgin-2 directory and just work. :( Instead it's looking up the purple plugin dir, then somehow not using it to check the libjabber.so library (which is there and provided by libpurple). Lets meet up on irc and discuss it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969
--- Comment #5 from sorensen...@tuta.io ---
Spec URL: https://gitlab.com/fedora-mobile/chatty/-/raw/master/chatty.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/02074354-chatty/chatty-0.2.0-5.fc35.src.rpm
Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/2074354/
> - Package uses either %{buildroot} or $RPM_BUILD_ROOT
> Note: Using both %{buildroot} and $RPM_BUILD_ROOT
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
This has been addressed.
> - The private library usage is... unfortunate. Is there any way to just
> disable
> the jabber support and not have to use it? Failing that, would it at least be
> possible
> to use the libpurple library at runtime? (currently this package installs the
> kind of generic sounding /usr/lib64/libjabber.so which it gets from libpurple
> during build instead of the /usr/lib64/purple-2/libjabber.so).
> Also if you can't use the libpurple one, make sure to add a
> Provides: bundled(libjabber.so) per
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
So, all other info regarding this being linked, the only thing I could figure
out to continue is to resume using the "hacky patch" and to update to use the
correct bundled() = [version] addition.
Various other cleanups from the review as well (tabs/space etc...)
Thanks again!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 --- Comment #4 from sorensen...@tuta.io --- Thanks for the review! Regarding the libjabber thing, there was an issue opened here https://source.puri.sm/Librem5/chatty/-/issues/266 but seems to have stalled. There was already some discussion about it on previous reviews prior to this one: https://bugzilla.redhat.com/show_bug.cgi?id=1870890 I'll do some playing around with the library and fix up those other issues as soon as possible. Thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969
--- Comment #3 from Kevin Fenzi ---
Sorry for the delay here.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
- The private library usage is... unfortunate. Is there any way to just disable
the jabber support and not have to use it? Failing that, would it at least be
possible
to use the libpurple library at runtime? (currently this package installs the
kind of generic sounding /usr/lib64/libjabber.so which it gets from libpurple
during build instead of the /usr/lib64/purple-2/libjabber.so).
Also if you can't use the libpurple one, make sure to add a
Provides: bundled(libjabber.so) per
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
- rpmlint has:
(a bunch of stuff that can be ignored and)
chatty.src:42: W: unversioned-explicit-provides libjabber
(this related to the above)
chatty.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 21)
(might be nice to stick to one or the other of tabs and spaces)
chatty.src: E: specfile-error warning: bogus date in %changelog: Sun Feb 15
2021 Torrey Sorensen - 0.2.0-4
(The 15th was a monday :)
A bunch of weak symbols related to libjabber (see above).
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/bash-
completion(chocolate-doom, wlogout, driverctl, rtags, mt-st, skim,
git-annex, nitrokey-app, exa, devscripts-checkbashisms, tealdeer,
gpaste, fedmod, unar, stress-ng, ripgrep, rpmdevtools, toolbox, nnn,
beaker-client, yadifa, pipx, libqmi, restic, dotnet-host, git-core,
falkon, docopt, docker-compose, dnf, zypper, filesystem, rpmlint,
pdfgrep, clevis, cowsay, libmbim, cobbler, tracker, reprepro,
etckeeper, mercurial, maven, rpmspectool, fd-find, subversion, kmod,
alacritty, bodhi-client, gammu, task, bubblewrap, eg, git-delta,
yadifa-tools, swayidle, ModemManager, devscripts, glib2, python-
django-bash-completion, hyperfine, smc-tools, dconf-editor, cmake-
data, fedpkg, hstr, mtr, datamash, sway, monotone, buildah, playerctl,
source-highlight, vagrant, zeitgeist, lightdm, clufter-cli, lxc, tio,
golang-github-tdewolff-minify, calf, breezy, swaylock,
python3-catkin_tools, licensecheck, awscli, lxi-tools, ffsend, zola,
darcs, flatpak, pbuilder, ldc, policycoreutils, skopeo, stratis-cli,
rubygem-ronn-ng, tracker3, exercism, ethtool, bash-completion, cpu-x,
python3-trezor), /usr/share/bash-completion/completions(chocolate-
doom, wlogout, driverctl, rtags, mt-st, skim, git-annex, nitrokey-app,
exa, nbdkit-bash-completion, devscripts-checkbashisms, tealdeer,
gpaste, fedmod, unar, packit, stress-ng, ripgrep, rpmdevtools,
toolbox, nnn, beaker-client, firejail, yadifa, firewalld, pipx,
libqmi, flameshot, restic, dotnet-host, git-core, falkon, ndctl,
docopt, kompose, docker-compose, dnf, zypper, filesystem, rpmlint,
calibre, pdfgrep, clevis, cowsay, libmbim, cobbler, opensc, tracker,
reprepro, etckeeper, mercurial, maven, nordugrid-arc-client,
rpmspectool, fd-find, subversion, kmod, libappstream-glib, alacritty,
bodhi-client, lastpass-cli, gammu, task, bubblewrap, eg, git-delta,
yadifa-tools, swayidle, coccinelle-bash-completion, ModemManager,
devscripts, glib2, python-django-bash-completion, hyperfine, smc-
tools, dconf-editor, cmake-data, fedpkg, hstr, jo, mtr, tig, datamash,
sway, python3-pip, monotone, libguestfs-bash-completion, buildah,
playerctl, source-highlight, vagrant, zeitgeist, lightdm, clufter-cli,
lxc, tio,
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED CC||ke...@scrye.com Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #2 from Kevin Fenzi --- I'll review this. Look for a full review in a while... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 sorensen...@tuta.io changed: What|Removed |Added CC||h...@nikhiljha.com --- Comment #1 from sorensen...@tuta.io --- *** Bug 1870890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 sorensen...@tuta.io changed: What|Removed |Added Blocks||1817424 (mobility) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1817424 [Bug 1817424] Tracker for mobility SIG activities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1928969] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1928969 sorensen...@tuta.io changed: What|Removed |Added CC||sorensen...@tuta.io Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
