[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Parag Nemade changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-backrefs-5.0.1-5.fc3 ||5 Resolution|--- |RAWHIDE Last Closed||2021-03-04 14:50:04 --- Comment #17 from Parag Nemade --- Added with "commit" rights. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #16 from Miro Hrončok --- Consider adding @python-sig. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #15 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-backrefs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #14 from Miro Hrončok --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #13 from Parag Nemade --- Thank You Miro for checking this package license with Legal team. I have updated this package to remove unnecessary docs files now. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-backrefs-5.0.1-5.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks|182235 (FE-Legal) |
Assignee|nob...@fedoraproject.org|mhron...@redhat.com
Flags||fedora-review?
--- Comment #12 from Miro Hrončok ---
Ben said the license is weird but OK.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
1) I would not include the tools/unicodedata/LICENSE file in the package, as
the unicodedata are not shipped.
2) I would not include docs/src/markdown/about/license.md either, it is the
same as LICENSE.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License", "Unicode Terms of Use".
The unicodedata is not shipped.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final prov
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Miro Hrončok changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #11 from Miro Hrončok --- I found an odd license in the tarball. https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/DHIXYVPYVUARICEQJJ2VX6IG6QG2PVPD/ The content does not appear to be shipped at runtime, only in the SRPM. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #10 from Parag Nemade --- Thanks Miro. I will wait if anyone or you to do this package review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #9 from Miro Hrončok --- Package looks fine now, but I won't be able to do a full review any time soon, I was hoping to do it today, but I'm too tired. Somebody else can do it or I can get to it some other day. Sorry about that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #8 from Parag Nemade --- It is not needed actually, dropped it now. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-backrefs-5.0.1-4.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991
--- Comment #7 from Miro Hrončok ---
- nothing provides python3.Xdist(backrefs[extras]) needed by
python3-backrefs-5.0.1-3.fc35.noarch
1) The X was just a placeholder, if you need to require the package, use
`Requires: python3-%{pypi_name}+extras = %{version}-%{release}` instead.
2) I don't understand the hard dependency, why is it needed?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #6 from Parag Nemade --- Sorry about 404 error. I realized I have wrong path set for package upload using fedora-create-review. Fixed this package for above comment suggestions. Below URL's will work fine. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-backrefs-5.0.1-3.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991
--- Comment #5 from Miro Hrončok ---
Spec sanity:
> Source0:
> https://github.com/facelessuser/backrefs/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
This can be simplified to:
Source0:
https://github.com/facelessuser/backrefs/archive/%{version}/%{name}-%{version}.tar.gz
Or even:
Source0:%{url}/archive/%{version}/%{name}-%{version}.tar.gz
> Requires: python3dist(regex)
Why is this needed? I see there is an extra called "extras" that requires
regex:
$ pip install 'backrefs[extras]'
Requirement already satisfied: backrefs[extras] in
./__venv_tmp__/lib/python3.9/site-packages (5.0.1)
Collecting regex; extra == "extras"
Using cached regex-2020.11.13-cp39-cp39-manylinux2014_x86_64.whl (732 kB)
Installing collected packages: regex
Successfully installed regex-2020.11.13
I suggest following this:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_extras
i.e. adding:
%{?python_extras_subpkg:%python_extras_subpkg -n python3-%{pypi_name} -i
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info
extras}
Then, the dependent packages can require python3.Xdist(backrefs[extras]) if
needed.
Instead now, the package always requires regex and there is no provide for
python3.Xdist(backrefs[extras]).
> # Remove bundled egg-info
> rm -rf %{pypi_name}.egg-info
This is not needed, there is no egg-info in the github tarball.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #4 from Miro Hrončok --- Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-backrefs-5.0.1-2.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #3 from Miro Hrončok --- Error 404. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #2 from Parag Nemade --- Spec URL: https://pnemade.fedorapeople.org/fedora-work/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/python-backrefs-5.0.1-2.fc34.src.rpm Followed the guidelines given in 192990 package review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Parag Nemade changed: What|Removed |Added Blocks||1929992 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1929992 [Bug 1929992] Review Request: python-wcmatch - Wildcard/glob file name matcher -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #1 from Parag Nemade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=62202842 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
