[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 Petr Viktorin changed: What|Removed |Added Status|POST|CLOSED CC||pvikt...@redhat.com Resolution|--- |RAWHIDE Last Closed||2021-03-30 09:20:50 --- Comment #15 from Petr Viktorin --- The package is built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #14 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jaraco-path -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Assignee|ksu...@redhat.com |mhron...@redhat.com Flags|fedora-review? |fedora-review+ --- Comment #13 from Miro Hrončok --- Approving on behalf of Karolina, who is not yet a packager. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #12 from Karolina Surma --- All looks good to me. The package can be APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #11 from Tomáš Hrnčiar --- Apologies, disregard previous links. I made a couple of minor changes. https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060038-python-jaraco-path/python-jaraco-path.spec https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060038-python-jaraco-path/python-jaraco-path-3.3.1-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #10 from Tomáš Hrnčiar --- Hello Karolina, here is the updated spec file, thank you. https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060023-python-jaraco-path/python-jaraco-path.spec https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02060023-python-jaraco-path/python-jaraco-path-3.3.1-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #9 from Miro Hrončok --- > I always struggle to use the correct GitHub URL's when working with archives. The URLs that work are: https://github.com///archive/.zip https://github.com///archive/.tar.gz https://github.com///archive//.zip https://github.com///archive//.tar.gz I consider this one is the optimal one: https://github.com///archive//-.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #8 from Tomáš Hrnčiar ---
(In reply to Miro Hrončok from comment #7)
> 1. Have you considered using this patch definition?
That's a good idea, I will do it.
> If you'd like to both use this AND have a nicer filename, you can do:
>
> Patch1:
> https://github.com/jaraco/jaraco.path/pull/1.patch#/better-filename.patch
Thanks, I wondered how to do it. I'll stick to 1.patch with full URL.
> 2. Have you considered having a nicer source filename? E.g. this:
>
> Source0:
> https://github.com/jaraco/jaraco.path/archive/v%{version}/jaraco.path-
> %{version}.tar.gz
I have to write this down :). I always struggle to use the correct GitHub URL's
when working with archives.
> 3. What is the benefit of defining the %pkg_name and %pypi_name macros? I
> find the spec file harder to read and it is not likely the values would
> change with time (unlike e.g. %version). IMHO it is much simpler if the
> values are used explicitly (especially since there are two different names
> used here).
My spec file is based on the other jaraco packages and I was trying to be
consistent. But since I used pyproject-rpm-macros this is probably the only
"consistency" that left there so I'll just remove it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #7 from Miro Hrončok ---
Thanks Karolina for the detailed review. I'm here with just a few nit picks,
nothing is critical:
1. Have you considered using this patch definition?
Patch1: https://github.com/jaraco/jaraco.path/pull/1.patch
Or is the patch manually rebased?
I find this beneficial, because the reader knows the patch is identical to this
PR if this is the case.
If you'd like to both use this AND have a nicer filename, you can do:
Patch1:
https://github.com/jaraco/jaraco.path/pull/1.patch#/better-filename.patch
(However I don't find it particularly useful, by using the URL you communicate
"this patch is PR#1".)
2. Have you considered having a nicer source filename? E.g. this:
Source0:
https://github.com/jaraco/jaraco.path/archive/v%{version}/jaraco.path-%{version}.tar.gz
This is useful when somebody works with this package in standard rpmbuild
source directories (i.e. outside of dist-git), where all the sources are in one
directory and v%{version}.tar.gz might clash with another package.
3. What is the benefit of defining the %pkg_name and %pypi_name macros? I find
the spec file harder to read and it is not likely the values would change with
time (unlike e.g. %version). IMHO it is much simpler if the values are used
explicitly (especially since there are two different names used here).
4. The comment in %check seem pretty much copy-pasted from the referenced
bugzilla. I'd change "if upstream sets
https://docs.pytest.org/en/stable/reference.html#confval-norecursedirs ..."
with something like "jaraco.path redefines norecursedirs without `.*`" -- the
bugzilla text tries to explain a situation in general terms, but this is a
specific package, so we can afford being more specific -- and hence shorter and
easier to understand. Whoever want's to know the details can visit the
referenced bugzilla.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255
--- Comment #6 from Karolina Surma ---
Hi Tomas,
The main issue was indeed solved.
There is a typo in %files section, in line: %exclude %dir
%{python3_sitelib}/jaraco/__pychache__ (should be: __pycache__) resulting in
both jaraco packages owning the directory.
This is considered a blocker for approval.
Also, it would be still handy to have the patch file renamed, as "1.patch"
doesn't really describe what the contents is.
As noted before, it's better when comments are of reasonable length, please
consider splitting the extra-long line of comment above the patch.
After fixes, the next review iteration is likely to be approval as no other
major issues were found.
For details see summary below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 20 files have unknown license. Detailed output of
licensecheck in /home/ksurma/tmp/1935255-python-jaraco-
path/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.9/site-
packages/jaraco/__pycache__(python3-jaraco)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a s
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #5 from Tomáš Hrnčiar --- Hello Karolina & Lumir, thank you for the review. I have addressed your concerns. You can find the updated spec file below. https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02052697-python-jaraco-path/python-jaraco-path.spec https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02052697-python-jaraco-path/python-jaraco-path-3.3.1-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #4 from Karolina Surma --- Also as noted by Lumir, please make sure that the resulting package depends on python3-jaraco containing the paths you're excluding here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #3 from Karolina Surma --- Hi Tomas, The package builds, but when built, it doesn't contain the actual file(s) it's supposed to have, there are only metadata and documentation. There are also some changes that would be nice to include in the spec file: - the patch name doesn't tell much about the contents, there could be additional comment including link to upstream patch - styling suggestion: A line of comment in the %check section could be divided into two separate to increase readability -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #2 from Lumír Balhar --- Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02049882-python-jaraco-path/python-jaraco-path.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-jaraco-path/fedora-rawhide-x86_64/02049882-python-jaraco-path/python-jaraco-path-3.3.1-1.fc35.src.rpm The provided links contain an error and the package does not build but I see that the error is already fixed in COPR so here are new links. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 --- Comment #1 from Tomáš Hrnčiar --- I just realized I forgot to add a link to the patch. https://patch-diff.githubusercontent.com/raw/jaraco/jaraco.path/pull/1.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 Lumír Balhar changed: What|Removed |Added Status|NEW |ASSIGNED CC||lbal...@redhat.com Assignee|nob...@fedoraproject.org|ksu...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935255] Review Request: python-jaraco-path - cross platform hidden file detection
https://bugzilla.redhat.com/show_bug.cgi?id=1935255 Miro Hrončok changed: What|Removed |Added Blocks||1933046 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1933046 [Bug 1933046] python-setuptools-54.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
