[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #20 from Fedora Update System --- FEDORA-2021-fc63def3f8 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #19 from Fedora Update System --- FEDORA-2021-fc63def3f8 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #18 from Fedora Update System --- FEDORA-2021-5926f0a056 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #17 from Fedora Update System --- FEDORA-2021-5926f0a056 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-5926f0a056` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5926f0a056 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #16 from Fedora Update System --- FEDORA-2021-fc63def3f8 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-fc63def3f8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-fc63def3f8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #15 from Fedora Update System --- FEDORA-2021-fc63def3f8 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fc63def3f8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #14 from Fedora Update System --- FEDORA-2021-5926f0a056 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5926f0a056 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #13 from Fedora Update System --- FEDORA-2021-e6ec396d70 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-04-03 01:27:56 --- Comment #12 from Fedora Update System --- FEDORA-2021-0408c8753e has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #11 from Fedora Update System --- FEDORA-2021-e6ec396d70 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e6ec396d70 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e6ec396d70 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-2021-0408c8753e has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0408c8753e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0408c8753e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #9 from Fedora Update System --- FEDORA-2021-0408c8753e has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0408c8753e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2021-e6ec396d70 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e6ec396d70 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rpi-imager -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #6 from Kees de Jong --- Thanks! Comments added in the spec and created new SRPM. Spec URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SPECS/rpi-imager.spec SRPM URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SRPMS/rpi-imager-1.6-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- - Pleas add the link to the bug above the patch Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937 --- Comment #4 from Kees de Jong --- Another change, added a patch: https://github.com/raspberrypi/rpi-imager/commit/2d87a2275f9a2525f000d0f216468b9cced97e98.patch This because of: https://github.com/raspberrypi/rpi-imager/issues/172#issuecomment-804857137 This indeed fixes the issue of selecting custom images. I think this concludes all changes I wanted to apply. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937
--- Comment #3 from Kees de Jong ---
Just to highlight one certain change, I want the app launcher in the Utilities
category in GNOME Shell.
I did this by doing:
desktop-file-install \
--add-category="X-GNOME-Utilities" \
%{buildroot}%{_datadir}/applications/%{name}.desktop
I suppose this is sufficient. I see no need to delete the original, since I
only want to append this category. I tested this and the launcher now does
appear in that category in GNOME.
Furthermore, as the docs state, it's either using desktop-file-install or
desktop-file-validate. So this should be sufficient to validate the desktop
file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937
--- Comment #2 from Kees de Jong ---
Thanks Robert, strange that I missed those obvious review remarks. Anyway, I
think I fixed all the issues now.
---
Spec URL:
https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SPECS/rpi-imager.spec
SRPM URL:
https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SRPMS/rpi-imager-1.6-1.fc33.src.rpm
Description: Graphical user-interface to write disk images and format SD cards
Fedora Account System Username: keesdejong
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3 Apache License 2.0", "Apache License 2.0", "curl License",
"*No copyright* [generated file]", "*No copyright* Apache License
2.0", "*No copyright* GNU General Public License", "GNU General Public
License", "[generated file]", "FSF Unlimited License (with Retention)
GNU General Public License, Version 2 [generated file]", "FSF
Unlimited License [generated file]", "zlib/libpng license", "ISC
License", "BSD 3-clause "New" or "Revised" License", "Public domain",
"BSD 2-clause "Simplified" License", "*No copyright* Public domain",
"BSD 3-clause "New" or "Revised" License BSD 2-clause "Simplified"
License", "BSD 2-clause "Simplified" License [generated file]", "GNU
General Public License v3.0 or later", "FSF All Permissive License",
"GNU General Public License v2.0 or later [generated file]", "FSF
Unlimited License (with Retention)", "Expat License [generated file]",
"GNU General Public License v2.0 or later", "BSD 4-clause "Original"
or "Old" License", "*No copyright* Boost Software License 1.0", "Boost
Software License 1.0", "NTP License", "*No copyright* zlib/libpng
license". 1465 files have unknown license. Detailed output of
licensecheck in /tmp/1940937-rpi-imager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop
[Bug 1940937] Review Request: rpi-imager - Graphical user-interface to write disk images and format SD cards
https://bugzilla.redhat.com/show_bug.cgi?id=1940937
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Nope:
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/128x128/apps
Add Requires: hicolor-icon-theme to own the icon dirs.
- You need to validate the desktop file as stated:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
BuildRequires: desktop-file-utils
[…]
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
- You also need to validate the appdata file, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
BuildRequires: libappstream-glib
[…]
appstream-util validate-relax --nonet
%{buildroot}%{_metainfodir}/%{name}.metainfo.xml
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3 Apache License 2.0", "Apache License 2.0", "curl License",
"*No copyright* [generated file]", "*No copyright* Apache License
2.0", "*No copyright* GNU General Public License", "GNU General Public
License", "[generated file]", "FSF Unlimited License (with Retention)
GNU General Public License, Version 2 [generated file]", "FSF
Unlimited License [generated file]", "zlib/libpng license", "ISC
License", "BSD 3-clause "New" or "Revised" License", "Public domain",
"BSD 2-clause "Simplified" License", "*No copyright* Public domain",
"BSD 3-clause "New" or "Revised" License BSD 2-clause "Simplified"
License", "BSD 2-clause "Simplified" License [generated file]", "GNU
General Public License v3.0 or later", "FSF All Permissive License",
"GNU General Public License v2.0 or later [generated file]", "FSF
Unlimited License (with Retention)", "Expat License [generated file]",
"GNU General Public License v2.0 or later", "BSD 4-clause "Original"
or "Old" License", "*No copyright* Boost Software License 1.0", "Boost
Software License 1.0", "NTP License", "*No copyright* zlib/libpng
license". 1465 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/rpi-imager/review-rpi-
imager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/128x128/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American
