[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-31 00:16:53 --- Comment #19 from Fedora Update System --- FEDORA-2021-a24c53741b has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- FEDORA-2021-a24c53741b has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a24c53741b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a24c53741b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #17 from Fedora Update System --- FEDORA-2021-f76c3d5eef has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f76c3d5eef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #16 from Fedora Update System --- FEDORA-2021-a24c53741b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a24c53741b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- FEDORA-2021-f76c3d5eef has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-f76c3d5eef \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f76c3d5eef See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #14 from Fedora Update System --- FEDORA-2021-f76c3d5eef has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f76c3d5eef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #13 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/guestfs-tools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #12 from Richard W.M. Jones --- Indeed it is, thanks. I will add the extra BR before pushing. Please let me know (probably better by direct email) when you have the package that you want me to review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Jerry James --- (In reply to Richard W.M. Jones from comment #10) > - Add perl(Test::More) dependency for the Perl test suite. But perl(Module::Build) isn't needed? I'll let you sort that out. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #10 from Richard W.M. Jones --- Spec URL: http://oirase.annexia.org/reviews/guestfs-tools/guestfs-tools.spec SRPM URL: http://oirase.annexia.org/reviews/guestfs-tools/guestfs-tools-1.45.2-3.fc33.src.rpm Description: Tools to access and modify virtual machine disk images Fedora Account System Username: rjones changelog: - Add perl(Test::More) dependency for the Perl test suite. - Fix ounit2 dependency again. Hopefully third time lucky. I enabled %check this time when I was testing it, and it builds here for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #9 from Jerry James --- Is this okay? --- Checking for Perl --- checking for perl... perl checking for Pod::Man... yes checking for Pod::Simple... yes checking for Test::More... no checking for Module::Build... no configure: WARNING: some Perl modules required to compile or test the Perl bindings are missing Also, the ounit fix appears to be incomplete: make[2]: Entering directory '/builddir/build/BUILD/guestfs-tools-1.45.2/common/mlstdutils' CC std_utils_tests-dummy.o OCAMLOPT std_utils_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1348: std_utils_tests.cmx] Error 2 make[2]: Entering directory '/builddir/build/BUILD/guestfs-tools-1.45.2/common/mlutils' CC c_utils_unit_tests-dummy.o OCAMLOPT c_utils_unit_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1378: c_utils_unit_tests.cmx] Error 2 make[2]: Entering directory '/builddir/build/BUILD/guestfs-tools-1.45.2/common/mltools' CC getopt_tests-dummy.o OCAMLOPT getopt_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: getopt_tests.cmx] Error 2 make[2]: Target 'getopt_tests' not remade because of errors. CC machine_readable_tests-dummy.o OCAMLOPT machine_readable_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: machine_readable_tests.cmx] Error 2 make[2]: Target 'machine_readable_tests' not remade because of errors. CC tools_messages_tests-dummy.o OCAMLOPT tools_messages_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: tools_messages_tests.cmx] Error 2 make[2]: Target 'tools_messages_tests' not remade because of errors. CC dummy.o OCAMLOPT JSON_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: JSON_tests.cmx] Error 2 make[2]: Target 'JSON_tests' not remade because of errors. CC JSON_parser_tests-dummy.o OCAMLOPT JSON_parser_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: JSON_parser_tests.cmx] Error 2 make[2]: Target 'JSON_parser_tests' not remade because of errors. CC tools_utils_tests-dummy.o OCAMLOPT tools_utils_tests.cmx ocamlfind: Package `oUnit' not found make[2]: *** [Makefile:1856: tools_utils_tests.cmx] Error 2 Everything else looks good. I'm not going to make you move those locale files around. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #8 from Richard W.M. Jones --- Spec URL: http://oirase.annexia.org/reviews/guestfs-tools/guestfs-tools.spec SRPM URL: http://oirase.annexia.org/reviews/guestfs-tools/guestfs-tools-1.45.2-2.fc33.src.rpm Description: Tools to access and modify virtual machine disk images Fedora Account System Username: rjones changelog: - Add perl(Locale::TextDomain) dependency for virt-win-reg. - Fix ounit2 dependency upstream. I didn't move the locale files around because I'm not sure how to do it, or if it's the right thing to do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #7 from Richard W.M. Jones --- > checking for OCaml findlib package oUnit... not found I think that's an upstream bug - I'll take a look. > checking for Locale::TextDomain... no I think that's either an upstream bug or missing dep. It's strange that the build succeeds. I'll take a look. > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 128 bytes in /usr/share It actually seems to be more: 1.5M./guestfs-tools-1.45.2-1.fc33.x86_64.rpm/usr/share 268K./guestfs-tools-man-pages-uk-1.45.2-1.fc33.noarch.rpm/usr/share 236K./guestfs-tools-man-pages-ja-1.45.2-1.fc33.noarch.rpm/usr/share 64K ./virt-dib-1.45.2-1.fc33.x86_64.rpm/usr/share 60K ./virt-win-reg-1.45.2-1.fc33.noarch.rpm/usr/share 24K ./guestfs-tools-bash-completion-1.45.2-1.fc33.noarch.rpm/usr/share It's basically all locale files in the largest of those. I'm fairly sure that is OK, since the locale files are needed by the binaries at runtime (so moving them to another package would make no sense). I suppose the message is something about how these locale files could be shared ...? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #6 from Richard W.M. Jones --- > - nothing provides libguestfs-dib >= 1:1.45.2-1 needed by > virt-dib-1.45.2-1.fc35.x86_64 This (will be) provided by the patched libguestfs (http://oirase.annexia.org/reviews/guestfs-tools/0001-New-upstream-version-1.45.2.patch) I can't push that yet - I need to add this package and update libguestfs at about the same time, otherwise the tools will disappear. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #5 from Jerry James --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ This is the installation error: Error: Problem: conflicting requests - nothing provides libguestfs-dib >= 1:1.45.2-1 needed by virt-dib-1.45.2-1.fc35.x86_64 (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) - Are these configure failures of concern? checking for OCaml findlib package oUnit... not found ... --- Checking for Perl --- checking for perl... perl checking for Pod::Man... yes checking for Pod::Simple... yes checking for Test::More... no checking for Module::Build... no configure: WARNING: some Perl modules required to compile or test the Perl bindings are missing checking for Pod::Usage... yes checking for Getopt::Long... yes checking for Locale::TextDomain... no checking for Win::Hivex... yes checking for Win::Hivex::Regedit... yes --- Checking for other libraries --- configure: WARNING: some Perl modules required to compile the Perl virt-* tools are missing - Some files carry the old FSF address on Mass Ave.: check-mli.sh, config.sh.in, ocaml-dep.sh.in, ocaml-link.sh.in = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/virt-builder(libguestfs- tools-c), /usr/share/bash-completion/completions(toolbox, swayidle, cobbler, golang-github-tdewolff-minify, exercism, tio, nbdkit-bash- completion, ModemManager, exa, devscripts, minipro, opensc, hyperfine, gpaste, flameshot, python3-pip, yadifa-tools, mt-st, datamash, rpmdevtools, coccinelle-bash-completion, chocolate-doom, zypper, rpmlint, bubblewrap, dconf-editor, devscripts-checkbashisms, driverctl, jo, unar, ffsend, git-delta, buildah, fd-find, ethtool, pbuilder, libqmi, rpmspectool, lxi-tools, calf, bodhi-client, fedpkg, python-django-bash-completion, firewalld, mercurial, firejail, swaylock, skim, bash-completion, cowsay, docopt, libappstream-glib, beaker-client, cmake-data, flatpak, libnbd-bash-completion, subversion, kmod, eg, git-core, fedmod, hstr, wlogout, darcs, falkon, ndctl, libguestfs-bash-completion, clevis, licensecheck, yadifa, stress-ng, monotone, playerctl, python3-catkin_tools, clufter-cli, gammu, xss-lock, GMT-common, sway, zeitgeist, ldc, git-annex, calibre, maven, rtags, pdfgrep, skopeo, rubygem-ronn-ng, source-highlight, docker-compose, dnf, lightdm, vagrant, breezy, lastpass-cli, dotnet- host, glib2, lxc, ripgrep, tig, nnn, libmbim, nordugrid-arc-client, etckeeper, restic, mtr, filesystem, nitrokey-app, zola, task, pipx, smc-tools, stratis-cli, awscli, cpu-x, kompose, tracker, tealdeer, packit, alacritty, reprepro, python3-trezor) These are fine. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. virt-dib needs libguestfs-dib; see above [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #4 from Jerry James --- I will take this review. I don't have any packages in need of review at the moment, although I will submit ocaml-camlbz2 and ocaml-parmap for review soon, so that the ocaml-ocamlgraph upgrade can proceed. I'll ping you then to see if you have time for a review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #3 from Richard W.M. Jones --- Looking through the fedora-review and rpmlint output, I can see: > guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot > /usr/bin/virt-builder I'm pretty sure this a bug in rpmlint. It's confused that this OCaml program is statically linked to the OCaml Unix library which includes a binding for chroot and therefore appears to call it, which it does not in reality. > guestfs-tools-bash-completion.noarch: W: no-documentation I guess we could include the README file but it seems pointless for such a simple subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #2 from Richard W.M. Jones --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=64438651 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942114] Review Request: guestfs-tools - Tools to access and modify virtual machine disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #1 from Richard W.M. Jones --- A bit of background. These tools were originally part of libguestfs (upstream: https://libguestfs.org/ Fedora: https://src.fedoraproject.org/rpms/libguestfs) Upstream we have split them off into a new repository: https://listman.redhat.com/archives/libguestfs/2021-March/msg00090.html https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c This is the corresponding Fedora review to add a new package (guestfs-tools) corresponding to the new source repository upstream. There is also a change to the current libguestfs package in Fedora to remove all the tools. I have not pushed it yet of course, but the intended patch is: http://oirase.annexia.org/reviews/guestfs-tools/0001-New-upstream-version-1.45.2.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
