[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 Jarek Prokop changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rubygem-protobuf-3.10.3-1.f ||c36 Resolution|--- |RAWHIDE Last Closed||2021-08-26 10:54:18 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-protobuf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- (In reply to Jarek Prokop from comment #4) > Remarks fixed: > > updated srpm: > https://fedorapeople.org/cgit/jackorp/public_git/rubygem-protobuf.git/plain/ > rubygem-protobuf-3.10.3-1.fc35.src.rpm > > updated spec: > https://fedorapeople.org/cgit/jackorp/public_git/rubygem-protobuf.git/plain/ > rubygem-protobuf.spec You need to add a comment explaining the license breakdown in the SPEC: # MIT: main library # BSD: proto/google/protobuf/compiler/plugin.proto # and proto/google/protobuf/descriptor.proto License: MIT and BSD Package approved, please fix the aforementioned issue before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 --- Comment #4 from Jarek Prokop --- Remarks fixed: updated srpm: https://fedorapeople.org/cgit/jackorp/public_git/rubygem-protobuf.git/plain/rubygem-protobuf-3.10.3-1.fc35.src.rpm updated spec: https://fedorapeople.org/cgit/jackorp/public_git/rubygem-protobuf.git/plain/rubygem-protobuf.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
- Some file are BSD:
BSD 3-clause "New" or "Revised" License
---
protobuf-3.10.3/proto/google/protobuf/compiler/plugin.proto
protobuf-3.10.3/proto/google/protobuf/descriptor.proto
Add:
# MIT: main library
# BSD: proto/google/protobuf/compiler/plugin.proto
# and proto/google/protobuf/descriptor.proto
License: MIT and BSD
- Fix the changelog release:
rubygem-protobuf.noarch: W: incoherent-version-in-changelog 3.10.3-1
['3.10.3-1.13.fc35', '3.10.3-1.13']
- Remove the tab line82:
rubygem-protobuf.src:82: W: mixed-use-of-spaces-and-tabs (spaces: line 53, tab:
line 82)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright*
[generated file]", "BSD 3-clause "New" or "Revised" License". 177
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/rubygem-protobuf/review-rubygem-
protobuf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
= SHOULD items =
Generic:
[-]: Avoid
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 --- Comment #2 from Jarek Prokop --- Yes I am aware of that, pvalena is planning to bring that package back: https://src.fedoraproject.org/rpms/rubygem-middleware/pull-request/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- DEBUG util.py:446: Last metadata expiration check: 0:00:02 ago on Mon Mar 29 22:31:49 2021. DEBUG util.py:444: No matching package to install: 'rubygem(middleware)' DEBUG util.py:444: Not all dependencies satisfied DEBUG util.py:444: Error: Some packages could not be found. It has been orphaned for more than 2 years: https://src.fedoraproject.org/rpms/rubygem%2Dmiddleware -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
