[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kweather -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Robert-André Mauchin 🐧 --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816
--- Comment #7 from Onuralp SEZER ---
It is fixed as well, thank you.
Thank you.(In reply to Neal Gompa from comment #6)
> > sed -i 's/GPL-2+/GPL-2/g'
> > %{buildroot}%{_datadir}/metainfo/org.kde.%{name}.appdata.xml
>
> This should be "GPL-2+" -> "GPL-2.0-or-later".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816
Neal Gompa changed:
What|Removed |Added
CC||ngomp...@gmail.com
--- Comment #6 from Neal Gompa ---
> sed -i 's/GPL-2+/GPL-2/g'
> %{buildroot}%{_datadir}/metainfo/org.kde.%{name}.appdata.xml
This should be "GPL-2+" -> "GPL-2.0-or-later".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 --- Comment #5 from Onuralp SEZER --- "hicolor-icon-theme" package requirement added. Version has been updated. https://pagure.io/kweather/blob/main/f/kweather-21.05-1.fc34.src.rpm https://pagure.io/kweather/blob/main/f/kweather.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #4 from Robert-André Mauchin 🐧 ---
- Add Requires: hicolor-icon-theme to own the icons directories
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Creative Commons Attribution 4.0
International License", "GNU General Public License, Version 2". 104
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/kweather/review-kweather/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstrea
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 --- Comment #2 from Onuralp SEZER --- (In reply to Ben Beasley from comment #1) > I unfortunately don’t have time to review this right now, but at least the > following from your fedora-review output above will have to be fixed: > > - > > > kweather.x86_64: W: incoherent-version-in-changelog 0.1.1-1 ['0.4-1.fc35', > > '0.4-1'] I fixed the version to proper version. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs > > - > > > kweather.x86_64: W: invalid-license GPL-2.0+ I fixed the license part (I forgot it) > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/ > > Valid short names are listed here: > > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses > > - > > > kweather.x86_64: E: invalid-desktopfile > > /usr/share/applications/org.kde.kweather.desktop value "0.3" for key > > "Version" in group "Desktop Entry" is not a known version I removed it. (upstream removed as well in their next release) > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_desktop_file_install_usage > > https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec- > latest.html > > (Maybe the upstream author thinks the Version field is for the application > version, rather than for the Desktop Entry Specification version to which > the .desktop file conforms?) > They remove that "Version" part in next version already so I can removed as well For now I used "sed" command to fix it. > - > > You also “MUST” validate the desktop file > (https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_desktop_file_install_usage) and AppData XML > (https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/); maybe > instead of commenting out these checks, you could patch these files as > needed to pass validation until the corresponding upstream issues are fixed? I re-enabled desktop and appdata check as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 Ben Beasley changed: What|Removed |Added CC||c...@musicinmybrain.net Doc Type|--- |If docs needed, set a value --- Comment #1 from Ben Beasley --- I unfortunately don’t have time to review this right now, but at least the following from your fedora-review output above will have to be fixed: - > kweather.x86_64: W: incoherent-version-in-changelog 0.1.1-1 ['0.4-1.fc35', > '0.4-1'] https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs - > kweather.x86_64: W: invalid-license GPL-2.0+ https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ Valid short names are listed here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses - > kweather.x86_64: E: invalid-desktopfile > /usr/share/applications/org.kde.kweather.desktop value "0.3" for key > "Version" in group "Desktop Entry" is not a known version https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html (Maybe the upstream author thinks the Version field is for the application version, rather than for the Desktop Entry Specification version to which the .desktop file conforms?) - You also “MUST” validate the desktop file (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage) and AppData XML (https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/); maybe instead of commenting out these checks, you could patch these files as needed to pass validation until the corresponding upstream issues are fixed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 Onuralp SEZER changed: What|Removed |Added Blocks||1957702 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1957702 [Bug 1957702] Review Request: kweathercore - Library to facilitate retrieval of weather information -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 --- Comment #3 from Onuralp SEZER --- https://download.copr.fedorainfracloud.org/results/thunderbirdtr/kweather/fedora-rawhide-x86_64/02168733-kweather/fedora-review/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
