[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #26 from Fedora Update System --- FEDORA-2021-31c566a3df has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #25 from Fedora Update System --- FEDORA-2021-86c956b384 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #24 from Fedora Update System --- FEDORA-2021-86c956b384 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-86c956b384 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-86c956b384 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- FEDORA-2021-31c566a3df has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-31c566a3df \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-31c566a3df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #22 from Fedora Update System --- FEDORA-2021-31c566a3df has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-31c566a3df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #21 from Fedora Update System --- FEDORA-2021-86c956b384 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-86c956b384 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #20 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rofimoji -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #19 from Ben Beasley --- > rofimoji --selector wofi --action print Thanks. I can confirm that works just fine (and uses a very different widget style). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #18 from Major Hayden --- (In reply to Major Hayden from comment #17) > I think I figured it out, Ben. It looks like rofimoji defaults to most of > the X11 type defaults, but you can override them. I set up a custom keyboard > shortcut in GNOME/Wayland to run: > > rofimoji --selector wofi --action print > > It likes to run rofi by default, but this causes it to run wofi instead. > Perhaps rofimoji should be a bit smarter to detect which system is running. To be fair, each window manager takes a little work to figure out with rofimoji. When I went from GNOME+X11 to i3wm+X11, I had to change how I ran rofimoji. I had to change again when switching to sway/Wayland. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #17 from Major Hayden --- I think I figured it out, Ben. It looks like rofimoji defaults to most of the X11 type defaults, but you can override them. I set up a custom keyboard shortcut in GNOME/Wayland to run: rofimoji --selector wofi --action print It likes to run rofi by default, but this causes it to run wofi instead. Perhaps rofimoji should be a bit smarter to detect which system is running. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783
--- Comment #16 from Ben Beasley ---
This looks fine now. It still doesn’t work for me, as I previously described,
but it seems to be correctly packaged.
Please feel free to ask me to help debug, here or in a new issue filed against
the package post-import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 314 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1961783-rofimoji/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
GUI is intended to be launched from the command line only.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
Submitter reports it works for them.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Descripti
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #15 from Major Hayden --- Thanks for letting me know what you're using. I'll put it into a VM with GNOME/Wayland and give it a try. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #14 from Ben Beasley --- > This does work for me if I install 'wtype'. I tested in Sway (Wayland) > yesterday and it seems to work properly. Which WM are you using? I can try it > there. I’m using standard GNOME/Wayland on Fedora 34. It doesn’t have to work for me for the package review to be approved (it should probably work for SOMEONE), but I’m happy to help debug. I’ll review the updated submission ASAP. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Major Hayden changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) --- Comment #13 from Major Hayden --- Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/rofimoji/fedora-rawhide-x86_64/02221246-rofimoji/rofimoji.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/rofimoji/fedora-rawhide-x86_64/02221246-rofimoji/rofimoji-5.1.0-5.fc35.src.rpm Fixed the non-executable shebang (again). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #12 from Major Hayden --- Ugh, the shebang fix was not what I thought it was. Correcting that now and running it through COPR. https://copr.fedorainfracloud.org/coprs/mhayden/rofimoji/build/2221246/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #11 from Major Hayden --- Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/rofimoji/fedora-rawhide-x86_64/02221220-rofimoji/rofimoji.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/rofimoji/fedora-rawhide-x86_64/02221220-rofimoji/rofimoji-5.1.0-5.fc35.src.rpm I enabled the fedora-review step in COPR and it looks pretty clean at this point: https://copr-be.cloud.fedoraproject.org/results/mhayden/rofimoji/fedora-rawhide-x86_64/02221220-rofimoji/fedora-review/ Thanks again for taking the time to review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783
Major Hayden changed:
What|Removed |Added
Flags|needinfo?(mhay...@redhat.co |
|m) |
--- Comment #10 from Major Hayden ---
> - The base package is named as an application rather than a library (rofimoji
> rather than python-rofimoji), which I think is correct.
>
> Since this is an application, I think you should put everything in the base
> package and drop the python3-rofimoji subpackage. The subpackage doesn’t
> offer an importable package or module called “rofimoji” as you would expect
> by its name, and the package that is installed (“picker”) is clearly
> designed
> as the tool implementation rather than as an API.
>
> You could move the BuildRequires and Requires from python3-rofimoji into
> the
> base rofimoji package, change
>
> %files -n python3-%{srcname} -f %{pyproject_files}
>
> to
>
> %files -f %{pyproject_files}
>
> and drop the python3-rofimoji subpackage altogether.
>
> It wouldn’t hurt to add the following to the base package, then, although I
> am not convinced it is required because the package is only intended to be
> imported by the application:
>
> %py_provides python3-picker
That makes sense. It's now fixed.
> - You can, if you like, move
>
> Version:5.1.0
>
> back below
>
> Name: %{srcname}
>
> and the expansion of
>
> %global tag %{version}
>
> will still work.
Done!
> - You have placed
>
> %%generate_buildrequires
%pyproject_buildrequires -r
> %pyproject_buildrequires -r
>
> as if it were part of %prep, but %generate_buildrequires is its own
> section.
> To make it less confusing, add a blank line before %generate_buildrequires.
>
> While there is no technical requirement to put %generate_buildrequires in a
> particular part of the spec file, a more common placement for this would be
> after the base package’s %description.
Fixed. I wasn't aware that '%generate_buildrequires' was its own section until
you mentioned it!
> - This looks like it is left over from an experiment:
>
> echo "error" >&2
🤭 That was a mistake, indeed.
> - The quotes here are unnecessary and unusal:
>
> %pyproject_save_files 'picker'
Fixed.
> - I tried the package in an actual Wayland session on Fedora 34. I was unable
> to type into the filter field, and when I double-clicked an emoji, I got
> “Compositor does not support the virtual keyboard protocol” in the
> terminal.
> Does it work for you?
This does work for me if I install 'wtype'. I tested in Sway (Wayland)
yesterday and it seems to work properly. Which WM are you using? I can try it
there.
I'll post the spec + SRPM shortly.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783
Ben Beasley changed:
What|Removed |Added
Flags||needinfo?(mhay...@redhat.co
||m)
--- Comment #9 from Ben Beasley ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- The base package is named as an application rather than a library (rofimoji
rather than python-rofimoji), which I think is correct.
Since this is an application, I think you should put everything in the base
package and drop the python3-rofimoji subpackage. The subpackage doesn’t
offer an importable package or module called “rofimoji” as you would expect
by its name, and the package that is installed (“picker”) is clearly designed
as the tool implementation rather than as an API.
You could move the BuildRequires and Requires from python3-rofimoji into the
base rofimoji package, change
%files -n python3-%{srcname} -f %{pyproject_files}
to
%files -f %{pyproject_files}
and drop the python3-rofimoji subpackage altogether.
It wouldn’t hurt to add the following to the base package, then, although I
am not convinced it is required because the package is only intended to be
imported by the application:
%py_provides python3-picker
- You can, if you like, move
Version:5.1.0
back below
Name: %{srcname}
and the expansion of
%global tag %{version}
will still work.
- You have placed
%generate_buildrequires
%pyproject_buildrequires -r
as if it were part of %prep, but %generate_buildrequires is its own section.
To make it less confusing, add a blank line before %generate_buildrequires.
While there is no technical requirement to put %generate_buildrequires in a
particular part of the spec file, a more common placement for this would be
after the base package’s %description.
- This looks like it is left over from an experiment:
echo "error" >&2
- The quotes here are unnecessary and unusal:
%pyproject_save_files 'picker'
- I tried the package in an actual Wayland session on Fedora 34. I was unable
to type into the filter field, and when I double-clicked an emoji, I got
“Compositor does not support the virtual keyboard protocol” in the terminal.
Does it work for you?
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 314 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1961783-rofimoji/re-
review/1961783-rofimoji/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Major Hayden changed: What|Removed |Added Flags|needinfo?(mhay...@redhat.co | |m) | --- Comment #8 from Major Hayden --- Spec URL: https://fedorapeople.org/~mhayden/rofimoji.spec SRPM URL: https://fedorapeople.org/~mhayden/rofimoji-5.1.0-4.fc34.src.rpm I switched over to using pyproject-rpm-macros after a coworker recommended it. Here's the most recent koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=68875287 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley changed: What|Removed |Added Flags||needinfo?(mhay...@redhat.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #7 from Ben Beasley --- Could you post an updated spec and SRPM incorporating the feedback from my original review? I don’t expect to have any new feedback. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #6 from Major Hayden --- Ben -- now that wtype is in rawhide and on its way to F34, does this spec need any more changes? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Bug 1961783 depends on bug 1964027, which changed state. Bug 1964027 Summary: Review Request: wtype - xdotool type for Wayland https://bugzilla.redhat.com/show_bug.cgi?id=1964027 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley changed: What|Removed |Added Depends On||1964027 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1964027 [Bug 1964027] Review Request: wtype - xdotool type for Wayland -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #5 from Ben Beasley --- Thanks. I’ll review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #4 from Major Hayden --- Ben: My wtype package is proposed over here: https://bugzilla.redhat.com/show_bug.cgi?id=1964027 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Major Hayden changed: What|Removed |Added Link ID||Red Hat Bugzilla 1964027 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Major Hayden changed: What|Removed |Added Flags|needinfo?(mhay...@redhat.co | |m) | --- Comment #3 from Major Hayden --- Thank you, Ben. 🤗 It's been a little while since I submitted a new package for Fedora and I have now discovered that `fedora-review` tool. I'll work through the rofimoji changes and take a look at packaging wtype. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783
Ben Beasley changed:
What|Removed |Added
Flags||needinfo?(mhay...@redhat.co
||m)
--- Comment #2 from Ben Beasley ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- Rpmlint reports:
python3-rofimoji.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3
You can remove the shebang line in %prep:
# No need for this to be a script when installed in site-packages:
sed -r -i 's/1{/^#!/d}/' picker/rofimoji.py
The entry point via /usr/bin/rofimoji will still work, of course.
- By default (installed in a clean mock chroot) the roflmoji command fails with
Could not find a valid way to type characters. Please check the required
dependencies.
To support both Wayland and X11 sessions, it seems that rofimoji should have:
# X11
Requires: rofi
Requires: xsel
Requires: xclip
Requires: xdotool
# Wayland
Requires: wofi
# For wl-copy
Requires: wl-clipboard
Requires: wtype
You might argue that these should all be weak dependencies
(https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/),
but I think that this is not appropriate since rofimoji will not function at
all without the appropriate group of dependencies for the session.
- Since wtype is needed for this package to work with Wayland sessions, you
should package it first. It is a very simple package, and I will be happy to
review it as well, and to answer questions about packaging it.
https://github.com/atx/wtype
- The spec file in the SRPM is (trivially) different from the one in the spec
file link.
- The pattern for the man page should allow for the compression format to
change. Change this:
%{_mandir}/man1/%{name}.1.gz
to this:
%{_mandir}/man1/%{name}.1*
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 314 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1961783-rofimoji/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstal
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley changed: What|Removed |Added Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 --- Comment #1 from Ben Beasley --- Fixed the issue title. Please link to the “raw” spec file so that tools such as fedora-review can process it: Spec URL: https://raw.githubusercontent.com/major/rpms/main/rofimoji.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/packages/fedora-rawhide-x86_64/02185143-rofimoji/rofimoji-5.1.0-2.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961783] Review Request: rofimoji - A character picker for rofi
https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley changed: What|Removed |Added CC||c...@musicinmybrain.net Summary|Review Request: -| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
