[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #14 from Fedora Update System  ---
FEDORA-2021-93f12a179d has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



--- Comment #13 from Fedora Update System  ---
FEDORA-2021-27518d9875 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Major Hayden 🤠  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2021-06-03 15:51:22 |2021-06-10 01:11:07




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #12 from Fedora Update System  ---
FEDORA-2021-93f12a179d has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-93f12a179d \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-93f12a179d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
FEDORA-2021-27518d9875 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-27518d9875 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-27518d9875

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #10 from Fedora Update System  ---
FEDORA-2021-93f12a179d has been submitted as an update to Fedora 33.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-93f12a179d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



--- Comment #9 from Fedora Update System  ---
FEDORA-2021-27518d9875 has been submitted as an update to Fedora 34.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-27518d9875


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #8 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-knack


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #7 from Major Hayden  ---
(In reply to Ben Beasley from comment #6)
> Looks great. Package approved, with a few comments below.
> 
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> = Notes (no change required) =
> 
> - This is not really required:
> 
> %{?!python3_pkgversion:%global python3_pkgversion 3}
> 
>   since the macro is already defined to “3” on Fedora and EPEL8 (and to “36”
> on
>   EPEL7). There should not be any current Fedora or EPEL release where it is
>   undefined.
>  
>   It might be possible to dispense with the macro entirely and use just a
>   literal “3”, if you are not targeting EPEL7. It is not clear to me if there
>   is any reason to use the macro in EPEL8 or not.
> 
>   (If you are targeting EPEL7, you will need a few tweaks to get
> there—mostly,
>   manual Requires guarded by “%if 0%{?el7}/%endif”,
>   “%if 0%{?epel} == 7/%endif”, or similar, since EPEL7 lacks a Python
>   dependency generator.)

I see. Thanks for that!

> - You can, if you like, write
> 
> %{python3_sitelib}/knack-*.egg-info
> 
>   as
> 
> %{python3_sitelib}/knack-py%{python3_version}.egg-info
> 
>   or
> 
> %{python3_sitelib}/%{srcname}-py%{python3_version}.egg-info
> 
>   which works as a boilerplate pattern for most simple Python packages, but
> the
>   version you have is fine.

Good to know. I always like re-using variables whenever I can.

Thank you!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Ben Beasley  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Ben Beasley  ---
Looks great. Package approved, with a few comments below.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= Notes (no change required) =

- This is not really required:

%{?!python3_pkgversion:%global python3_pkgversion 3}

  since the macro is already defined to “3” on Fedora and EPEL8 (and to “36” on
  EPEL7). There should not be any current Fedora or EPEL release where it is
  undefined.

  It might be possible to dispense with the macro entirely and use just a
  literal “3”, if you are not targeting EPEL7. It is not clear to me if there
  is any reason to use the macro in EPEL8 or not.

  (If you are targeting EPEL7, you will need a few tweaks to get there—mostly,
  manual Requires guarded by “%if 0%{?el7}/%endif”,
  “%if 0%{?epel} == 7/%endif”, or similar, since EPEL7 lacks a Python
  dependency generator.)

- You can, if you like, write

%{python3_sitelib}/knack-*.egg-info

  as

%{python3_sitelib}/knack-py%{python3_version}.egg-info

  or

%{python3_sitelib}/%{srcname}-py%{python3_version}.egg-info

  which works as a boilerplate pattern for most simple Python packages, but the
  version you have is fine.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License", "*No copyright* Expat
 License". 10 files have unknown license. Detailed output of
 licensecheck in /home/reviewer/1966722-python-knack/2/1966722-python-
 knack/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python

[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Major Hayden  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|WONTFIX |---
   Keywords||Reopened



--- Comment #5 from Major Hayden  ---
Okay, this package *is* actually needed by python-azure-cli-core. 🤦🏻‍♂️


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Major Hayden  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2021-06-03 15:51:22



--- Comment #4 from Major Hayden  ---
Disregard. After working on packaging on the latest version of the Azure
SDK/CLI, it turns out that this requirement is no longer needed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Major Hayden  changed:

   What|Removed |Added

  Flags|needinfo?(mhay...@redhat.co |
   |m)  |



--- Comment #3 from Major Hayden  ---
(In reply to Ben Beasley from comment #2)
> - The patch for https://fedoraproject.org/wiki/Changes/DeprecatePythonMock
>   looks reasonable:
> 
> # Use unittest's mock that is built in for Python 3.x.
> sed -i 's/^import mock/from unittest import mock/' tests/*.py
> 
>   but it should be offered upstream. I went ahead and created a PR, which you
>   can link in a comment:
> 
> # https://github.com/microsoft/knack/pull/248
> 

Thanks! Noted that in the spec.


> Because you are using pyproject-rpm-macros (a great idea!) I know you are
> targeting only Fedora, not EPEL7 or EPEL8, since the pyproject-rpm-macros are
> not available there. Considering that:

Good point. I'd like this to potentially work in EPEL, so I'll go back to the
other python RPM macros instead.

> - You should remove
> 
> %{?python_enable_dependency_generator}

Done.

Spec URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/0348-python-knack/python-knack.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/0348-python-knack/python-knack-0.8.2-1.fc35.src.rpm
fedora-review:
https://copr-be.cloud.fedoraproject.org/results/mhayden/python-knack/fedora-rawhide-x86_64/0348-python-knack/fedora-review/review.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Ben Beasley  changed:

   What|Removed |Added

  Flags||needinfo?(mhay...@redhat.co
   ||m)



--- Comment #2 from Ben Beasley  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= Issues =

- The patch for https://fedoraproject.org/wiki/Changes/DeprecatePythonMock
  looks reasonable:

# Use unittest's mock that is built in for Python 3.x.
sed -i 's/^import mock/from unittest import mock/' tests/*.py

  but it should be offered upstream. I went ahead and created a PR, which you
  can link in a comment:

# https://github.com/microsoft/knack/pull/248

- While it’s not required, you could switch to the GitHub tarball if you want,
  in order to install the Markdown docs and the examples.

Because you are using pyproject-rpm-macros (a great idea!) I know you are
targeting only Fedora, not EPEL7 or EPEL8, since the pyproject-rpm-macros are
not available there. Considering that:

- You should remove

%{?!python3_pkgversion:%global python3_pkgversion 3}

  and replace each occurrence of “%{python3_pkgversion}” with “3”. This macro
  is an EPEL-ism.

- While you can rewrite

python%{python3_pkgversion}-pytest

  as

python3-pytest

  the following “standardized name” style is more conventional in Fedora today
 
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic_provides_with_a_standardized_name):

python3dist(pytest)

- You should remove

%{?python_enable_dependency_generator}

  because the automatic dependency generator is enabled by default in Fedora
 
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies),
  so this line is unnecessary.

  Even if you were targeting EPEL, the automatic dependency generator is
  enabled by default in EPEL8 and is unavailable in EPEL7, so this line would
  still do nothing. It was only useful on versions of Fedora that are now
  end-of-life.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License", "*No copyright* Expat
 License". 10 files have unknown license. Detailed output of
 licensecheck in /home/reviewer/1966722-python-knack/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Packa

[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722



--- Comment #1 from Major Hayden  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02221420-python-knack/python-knack.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02221420-python-knack/python-knack-0.8.2-1.fc35.src.rpm

The other build didn't include fedora-review as it should have, but this one
has it:
https://copr-be.cloud.fedoraproject.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02221420-python-knack/fedora-review/review.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1966722] Review Request: python-knack - A Command-Line Interface framework used by the Azure cli

2021-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1966722

Ben Beasley  changed:

   What|Removed |Added

 CC||c...@musicinmybrain.net
   Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure