[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #34 from Fedora Update System --- FEDORA-2021-c50292f421 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #33 from Fedora Update System --- FEDORA-2021-e7eabe3138 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2021-10-19 00:36:38 --- Comment #32 from Fedora Update System --- FEDORA-2021-a305b11c41 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #31 from Fedora Update System --- FEDORA-2021-c50292f421 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-c50292f421 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-c50292f421 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #30 from Fedora Update System --- FEDORA-2021-e7eabe3138 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e7eabe3138 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e7eabe3138 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #29 from Fedora Update System --- FEDORA-2021-a305b11c41 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a305b11c41 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a305b11c41 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #28 from Fedora Update System --- FEDORA-2021-e7eabe3138 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e7eabe3138 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #27 from Fedora Update System --- FEDORA-2021-a305b11c41 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a305b11c41 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #26 from Fedora Update System --- FEDORA-2021-c50292f421 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-c50292f421 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #25 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/anarch -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #24 from Ankur Sinha (FranciscoD) --- Thanks, that looks good! XXX APPROVED XXX -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #23 from Artur Frenszek-Iwicki --- > typo on line 26: the description macro should be desc_text (currently is > desc_test) Thanks, fixed. > You need to require hicolor-icon-theme which owns the icon directories. Oh, oops. Fixed. > Compilation warning worth looking at: > main_sdl.c: In function 'SFG_sleepMs': > main_sdl.c:172:3: warning: implicit declaration of function 'usleep'; did you > mean 'sleep'? [-Wimplicit-function-declaration] Fixed via compiler flags. > anarch-CSFML.x86_64: E: summary-too-long > anarch-SDL2.x86_64: E: summary-too-long Shortened the summary and fixed the redefinition issue. > You can use the forge macros to simplify the spec if you wish: > You can use the %autosetup macro, it does the patching for you too: Maybe one day. Can't teach an old dog new tricks. ;) Updated links: spec: https://svgames.pl/fedora/anarch-1.02d-3.20210616gitf6a6a68a/anarch.spec srpm: https://svgames.pl/fedora/anarch-1.02d-3.20210616gitf6a6a68a/anarch-1.02d-3.20210616gitf6a6a68a.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=76516558 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987
--- Comment #22 from Ankur Sinha (FranciscoD) ---
Looks very good. Just a few minor things to fix up:
- You can use the forge macros to simplify the spec if you wish:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control
- typo on line 26: the description macro should be desc_text (currently is
desc_test)
- You can use the %autosetup macro, it does the patching for you too:
https://rpm-software-management.github.io/rpm/manual/autosetup.html
- You need to require hicolor-icon-theme which owns the icon directories. See
the filesystem bit here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
- Compilation warning worth looking at:
main_sdl.c: In function 'SFG_sleepMs':
main_sdl.c:172:3: warning: implicit declaration of function 'usleep'; did you
mean 'sleep'? [-Wimplicit-function-declaration]
172 | usleep(timeMs * 1000);
| ^~
| sleep
- You can use autochangelog if you wish:
https://fedoraproject.org/wiki/Changes/rpmautospec
RPMlint bits:
- anarch-CSFML.x86_64: E: summary-too-long Suckless, anarcho-pacifist,
90s-style Doom clone that runs everywhere (SDL2 version) (CSFML version)
^
"SDL2 version" shouldn't be here
I seems like %summary is being redefined for each sub-package. I'm not sure if
this is supposed to happen, though.
- anarch-SDL2.x86_64: E: summary-too-long Suckless, anarcho-pacifist, 90s-style
Doom clone that runs everywhere (SDL2 version)
^
Could perhaps shorten this a bit to make rpmlint happy?
- because of typo in desc_text:
anarch.src: W: unexpanded-macro %description -l C %{desc_text}
anarch-CSFML.x86_64: W: unexpanded-macro %description -l C %{desc_text}
anarch-SDL2.x86_64: W: unexpanded-macro %description -l C %{desc_text}
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Creative Commons CC0
1.0", "Creative Commons CC0 1.0". 206 files have unknown license.
Detailed output of licensecheck in /home/asinha/dump/fedora-
reviews/1977987-anarch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/128x128/apps
^
I think you need to require hicolor-icon-theme which owns these directories:
https://packages.fedoraproject.org/pkgs/hicolor-icon-theme/hicolor-icon-theme/
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: anarch-SDL2 (description), anarch-CSFML (description)
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Ankur Sinha (FranciscoD) changed: What|Removed |Added Assignee|notinsideofhereiamnotinside |sanjay.an...@gmail.com |@gmail.com | Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #21 from Ankur Sinha (FranciscoD) --- Sure, I'll review this over the weekend at the latest. Do ping me wherever and let's get your system fixed up :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #20 from niohiani --- A OK with me, and yes Ankur, I'll email you to coordinate timing. I actually just tried fedora-review on packages that I previously reviewed successfully, and am now getting the same error for those, so something has definitely gone wrong since my last successful review, and I'd be happy to have some assistance in getting to the bottom of it! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #19 from Artur Frenszek-Iwicki --- Fine by me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #18 from Ankur Sinha (FranciscoD) --- Can you please hit me up on IRC sometime so we can debug this? With the options I noted, it shouldn't run systemd-nspawn at all. So, something is off with your system. Are you able to run mock generally? fedora-review works here, so I can take over the review while we fix your system if that's OK with both you and Artur? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #17 from niohiani --- Hey guys. The Build logs always have the following errors in them: ERROR: Exception(~/Public/FedReviews/review-anarch/srpm/anarch-1.02d-2.20210616gitf6a6a68a.fc34.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 46 seconds INFO: Results and/or logs in: ~/Public/FedReviews/review-anarch/results ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M afe2814e84c542a99ae39f11f9cc33a8 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.xcjfjtwo:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;\007" --setenv=PS1= \s-\v\$ --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/anarch.spec It's always the same, including when I ran fedora-review with the options suggested by Ankur. This has not happened with other reviews. Pretty stumped. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #16 from Ankur Sinha (FranciscoD) --- Hrm, is that what the error is suggesting or is that just the full command that is printed out whenever mock errors? Anyway, one can use the `--isolation=simple` argument with mock to not use systemd-nspawn. `man mock` for more on that. To use this with fedora-review, one would use the `-o` flag there, so I'd think: `fedora-review -o "--no-bootstrap-chroot --no-cleanup-after --no-clean --isolation=simple ...` should do it (the other options are the defaults that fedora-review uses). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #15 from Artur Frenszek-Iwicki --- Well the error message says that systemd-nspawn failed. So I guess it's an issue either in mock itself, or systemd containers don't work on their machine. Maybe worth asking on devel mailing list? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #14 from Ankur Sinha (FranciscoD) --- What do the build logs say? (~/Public/FedReviews/review-anarch/results/build.log). We need to narrow it down to see whether it's an issue with mock running, or an issue in the build once mock runs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #13 from niohiani --- Sorry, I was without internet access for a few days. I just did 'mock clean --scrub=all', then attempted to run the review again. Still throwing up errors, and unfortunately I'm getting the same results as the past several dozen attempts. ERROR: 'mock build failed, see ~/Public/FedReviews/review-anarch/results/build.log' ERROR: Exception(~/Public/FedReviews/review-anarch/srpm/anarch-1.02d-2.20210616gitf6a6a68a.fc34.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 46 seconds INFO: Results and/or logs in: ~/Public/FedReviews/review-anarch/results ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M afe2814e84c542a99ae39f11f9cc33a8 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.xcjfjtwo:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;\007" --setenv=PS1= \s-\v\$ --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/anarch.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #12 from Artur Frenszek-Iwicki --- What's the error from mock? Did you try "mock clean --scrub=all"? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 niohiani changed: What|Removed |Added Assignee|nob...@fedoraproject.org|notinsideofhereiamnotinside ||@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #11 from niohiani --- Sorry for the delay. Been trying to get this take care of for the past few days, but the mock build keeps failing. Trying to get a handle on why. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Bug 1977987 depends on bug 1988952, which changed state. Bug 1988952 Summary: Review Request: CSFML - C bindings for the C++ SFML library https://bugzilla.redhat.com/show_bug.cgi?id=1988952 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #10 from Artur Frenszek-Iwicki --- Fixed the linker flags and also added a CSFML (rhbz#1988952) build of the game. spec: https://svgames.pl/fedora/anarch-1.02d-2.20210616gitf6a6a68a/anarch.spec srpm: https://svgames.pl/fedora/anarch-1.02d-2.20210616gitf6a6a68a/anarch-1.02d-2.20210616gitf6a6a68a.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=74980719 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987
--- Comment #9 from Ankur Sinha (FranciscoD) ---
I had a quick look. Looks very good. I wasn't able to get fedora-review to run
though, but I can't see anything wrong with the spec. The only additional note
here is:
- I think you may have to add the linker flags manually too since you're
running the compilation commands yourself. %{optflags} doesn't include
%{build_ldflags}. So your commands will be:
gcc %{optflags} -std=c99 -o %{name}-sdl2 main_sdl.c -lSDL2 %{build_ldflags}
gcc %{optflags} -std=c99 -o %{name}-test main_test.c %{build_ldflags}
(You can set linker flags in multiple places on the compiler command line, but
I remember reading somewhere that adding them at the end seems to work
best---can't find the the post now :/)
Cheers,
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #8 from Ankur Sinha (FranciscoD) --- If all those review items pass, you're free to approve the review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 niohiani changed: What|Removed |Added Flags||needinfo?(sanjay.ankur@gmai ||l.com) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Artur Frenszek-Iwicki changed: What|Removed |Added Depends On||1988952 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1988952 [Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #7 from niohiani --- Alright. Fedora-review works with the latest URLs you provided. These are the sections which require manual review, and my feedback on those sections where possible. A (✓) means there does not appear to be a problem. An (x) means there is an issue. A (?) means I'm not sure. C/C++: (✓): Package does not contain kernel modules. (✓): Package contains no static executables. Generic: (✓): Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. (✓): License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons CC0 Universal 1.0 Public Domain Dedication", "Creative Commons CC0 Universal 1.0 Public Domain Dedication". 207 files have unknown license. Detailed output of licensecheck in licensecheck.txt (✓): License file installed when any subpackage combination is installed. (✓): %build honors applicable compiler flags or justifies otherwise. (✓): Package contains no bundled libraries without FPC exception. (✓): Changelog in prescribed format. (✓): Sources contain only permissible code or content. (✓): Development files must be in a -devel package (✓): Package uses nothing in %doc for runtime. (✓): Package consistently uses macros (instead of hard-coded directory names). (✓): Package is named according to the Package Naming Guidelines. (✓): Package does not generate any conflict. (✓): Package obeys FHS, except libexecdir and /usr/target. (✓): If the package is a rename of another package, proper Obsoletes and Provides are present. (✓): Spec file is legible and written in American English. (✓): Useful -debuginfo package or justification otherwise. (✓): Package is not known to require an ExcludeArch tag. (✓): Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 1 files. (✓): Package complies to the Packaging Guidelines Generic: (✓): If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. (✓): Final provides and requires are sane (see attachments). (✓): Package functions as described. (✓): Latest version is packaged. (✓): Package does not include license text files separate from upstream. (✓): Patches link to upstream bugs/comments/lists or are otherwise justified. (✓): Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. (✓): Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. (✓): Package should compile and build into binary rpms on all supported architectures. To a newb this looks good. I will eMail Ankur to confirm. By the way, I've seen your game floating around, and a couple of articles about it. I tried it out myself a couple of months back, and I appreciate your work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #6 from Artur Frenszek-Iwicki --- Yep, looks like the original SRPM got corrupted during upload. Sorry for that. Here's a new build that fixes issues with ownership of /usr/share/icons/... directories, and also adds a patch to store the game's savefile in $XDG_DATA_HOME instead of $PWD. spec: https://svgames.pl/fedora/anarch-1.02d-2.20210616gitf6a6a68a/anarch.spec srpm: https://svgames.pl/fedora/anarch-1.02d-2.20210616gitf6a6a68a/anarch-1.02d-2.20210616gitf6a6a68a.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=71576566 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #5 from niohiani --- Loud and clear about the flag topic. No problemo, and will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Ankur Sinha (FranciscoD) changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #4 from Ankur Sinha (FranciscoD) --- Thanks Niohiani, Dridi, That looks good. Please wait for Arthur to correct the issues you've outlined and then continue to new rounds of review as required. Please also keep in mind that fedora-review is a helper but it does not replace a human review. So please do remember to check the package against the guidelines manually too if you haven't done that already. :) PS: please add us to the CC list instead of using the needinfo flag. The needinfo flag is used when you haven't received a response after multiple messages. It sends extra notifications to folks, so should be used only when necessary. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987
--- Comment #3 from Didik Supriadi ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Creative Commons CC0
Universal 1.0 Public Domain Dedication", "Creative Commons CC0
Universal 1.0 Public Domain Dedication". 207 files have unknown
license. Detailed output of licensecheck in
/home/chronoelves/rpmbuild/SRPMS/anarch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 Didik Supriadi changed: What|Removed |Added CC||didiksupriad...@gmail.com --- Comment #2 from Didik Supriadi --- Hello, I'm new contributor too. I see that your srpm link seems broken or at least can't be extracted. here's an example: $ rpm2archive anarch-1.02d-1.20210616gitf6a6a68a.fc34.src.rpm Error reading file from rpm payload But the koji is online, so it's fine to me. Rpmlint gives this warning: anarch.x86_64: W: incoherent-version-in-changelog 1.02d-1.20210617gitf6a6a68a8 ['1.02d-1.20210616gitf6a6a68a.fc35', '1.02d-1.20210616gitf6a6a68a'] ^ the date seems wrong -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977987] Review Request: anarch - minimalist first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1977987 niohiani changed: What|Removed |Added CC||notinsideofhereiamnotinside ||@gmail.com, ||sanjay.an...@gmail.com Flags||needinfo?(sanjay.ankur@gmai ||l.com) --- Comment #1 from niohiani --- I should note that I'm a new contributor awaiting sponsorship into the package maintainers group, but I simply cannot get this to build, which means it obviously won't install. Here's a sampling of the errors received when using the fedora-review tool: INFO: Processing bug on url: https://bugzilla.redhat.com/show_bug.cgi?id=1977987 INFO: Getting .spec and .srpm Urls from : https://bugzilla.redhat.com/show_bug.cgi?id=1977987 INFO: --> SRPM url: https://svgames.pl/fedora/anarch-1.02d-1.20210616gitf6a6a68a/anarch-1.02d-1.20210616gitf6a6a68a.fc34.src.rpm INFO: --> Spec url: https://svgames.pl/fedora/anarch-1.02d-1.20210616gitf6a6a68a/anarch.spec INFO: Using review directory: /review-anarch INFO: Downloading .spec and .srpm files cpio: premature end of file WARNING: Cannot unpack /review-anarch/srpm/anarch-1.02d-1.20210616gitf6a6a68a.fc34.src.rpm into /review-anarch/srpm-unpacked cpio: premature end of file WARNING: Cannot unpack /review-anarch/srpm/anarch-1.02d-1.20210616gitf6a6a68a.fc34.src.rpm into /review-anarch/srpm-unpacked INFO: No upstream for (Source101): anarch-sdl2.appdata.xml INFO: No upstream for (Source100): anarch-sdl2.desktop INFO: Downloading (Source0): https://gitlab.com/drummyfish/anarch/-/archive/f6a6a68a890716cd394c6fb2d00bd8123b51b18f/anarch-f6a6a68a890716cd394c6fb2d00bd8123b51b18f.tar.gz INFO: Running checks and generating report ERROR: Exception(/review-anarch/srpm/anarch-1.02d-1.20210616gitf6a6a68a.fc34.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 1 seconds INFO: Results and/or logs in: /review-anarch/results ERROR: Source RPM is not installable: INFO: Reading configuration from /etc/mock/site-defaults.cfg INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg ERROR: 'mock build failed, see /review-anarch/results/build.log' In conclusion, I am adding the contributor who will eventually be sponsoring me (Ankur Sinha) to the discussion for further input. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
