[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692 Sandro Mani changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2021-08-09 21:31:59 --- Comment #5 from Sandro Mani --- All done! - Thanks for all the reviews, feel free to come back to me if you need more in the future! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-qt6-qtcharts -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692
Major Hayden 🤠changed:
What|Removed |Added
Status|NEW |POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Major Hayden 🤠---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
No issues here outside of normal mingw rpmlint differences. Approved! 🎉
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
3", "*No copyright* [generated file]", "GNU General Public License
v3.0 or later", "GNU Free Documentation License, Version 1.3". 740
files have unknown license. Detailed output of licensecheck in
/var/lib/copr-rpmbuild/results/mingw-qt6-qtcharts/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
mingw32-qt6-qtcharts , mingw64-qt6-qtcharts
[x]: Package functions as described.
[X]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and
[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692 Sandro Mani changed: What|Removed |Added Flags|needinfo?(manisandro@gmail. | |com)| --- Comment #2 from Sandro Mani --- mingw-qt6-qtdeclarative is now available in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692 Major Hayden 🤠changed: What|Removed |Added Flags||needinfo?(manisandro@gmail. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988692] Review Request: mingw-qt6-qtcharts - Qt6 for Windows - QtCharts component
https://bugzilla.redhat.com/show_bug.cgi?id=1988692 Major Hayden 🤠changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mhay...@redhat.com Doc Type|--- |If docs needed, set a value CC||mhay...@redhat.com Flags||fedora-review? --- Comment #1 from Major Hayden 🤠--- This one also failed to build on rawhide: No matches found for the following disable plugin patterns: local, spacewalk, versionlock Copr repository 126 kB/s | 3.0 kB 00:00 fedora 443 kB/s | 11 kB 00:00 No matching package to install: 'mingw32-qt6-qtbase = 6.1.1' No matching package to install: 'mingw32-qt6-qtdeclarative = 6.1.1' No matching package to install: 'mingw64-qt6-qtbase = 6.1.1' No matching package to install: 'mingw64-qt6-qtdeclarative = 6.1.1' -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
