[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #18 from Fedora Update System --- FEDORA-2021-75223b7b4d has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1988952 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #17 from Fedora Update System --- FEDORA-2021-b4ec32da20 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2021-09-09 17:31:43 --- Comment #16 from Fedora Update System --- FEDORA-2021-7cc9dfc7be has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #15 from Fedora Update System --- FEDORA-2021-b4ec32da20 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b4ec32da20 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b4ec32da20 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #14 from Fedora Update System --- FEDORA-2021-7cc9dfc7be has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-7cc9dfc7be \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cc9dfc7be See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2021-75223b7b4d has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-75223b7b4d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-75223b7b4d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #12 from Fedora Update System --- FEDORA-2021-b4ec32da20 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b4ec32da20 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #11 from Fedora Update System --- FEDORA-2021-7cc9dfc7be has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cc9dfc7be -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2021-75223b7b4d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-75223b7b4d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #9 from Kevin Fenzi --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/CSFML -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952
Petr Menšík changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #8 from Petr Menšík ---
Did you know %doc would copy files from source directory? Installing them to
correct locations is not necessary.
%doc readme.txt
If would include after %cmake_install:
rm -f %{buildroot}%{_datadir}/%{name}/license.txt
Then remove from %files:
%doc %{_datadir}/%{name}/license.txt
It is handled by %license license.txt already, but put into different
directory. One license copy in a package is enough.
But that is just cosmetic issue. It seems fine and ready for the distribution,
thank you!
Continue by fedpkg request-repo
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #7 from Artur Frenszek-Iwicki --- spec: https://svgames.pl/fedora/CSFML-2.5.1-2/CSFML.spec srpm: https://svgames.pl/fedora/CSFML-2.5.1-2/CSFML-2.5.1-2.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=74626495 Sorry for taking so long. Regarding the CSFML-SFML dependency, I tried compiling a program using CSFML, and here's how it looks: - CSFML-devel does not require SFML-devel - i.e. headers are independent - CSFML requires SFML - i.e. one library pulls in the other library -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 Artur Frenszek-Iwicki changed: What|Removed |Added Blocks||1977987 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1977987 [Bug 1977987] Review Request: anarch - minimalist first person shooter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #6 from Artur Frenszek-Iwicki --- This spec is based on the current SFML spec, so yes, some of the issues can be traced back there. I'll get to fixing it later today or maybe tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 Petr Menšík changed: What|Removed |Added Assignee|nob...@fedoraproject.org|pemen...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952
Petr Menšík changed:
What|Removed |Added
Flags||fedora-review?
Status|NEW |ASSIGNED
--- Comment #5 from Petr Menšík ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file license.txt is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- license file is not installed using %license, but marked as %doc.
use just:
%license license.txt
%doc readme.txt
# ^^ installs from sources directory to correct paths
# rm license.txt in %{_datadir}/doc/ after install if needed
- /usr/include/SFML is shared with SFML-devel. It is unusual to share header
directories
if it does not depend on SFML-devel. I think it might be confusing.
No pkg-config or cmake config file is provided to easy configuration.
I guess okay if SFML-devel and CSFML-devel do not conflict and they are
related.
Depends on how is the usage of library documented.
- /usr/share/CSFML/doc is wrong, /usr/share/doc/CSFML should be used instead.
SFML uses it the same wrong way, but should be corrected too. To be fixed in
cmake/Config.cmake
CMake module GNUInstallDirs should be considered on Linux:
https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html
- I would recommend adding html API docs to separate -doc subpackage with
BuildArch: noarch.
It is not so small and not always required for building.
Recommends: %{name}-doc might be in devel package.
Also, add the html directory also: %{_datadir}/%{name}/doc/html/* ->
%{_datadir}/doc/%{name}/html
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "zlib/libpng license". 35 files have
unknown license. Detailed output of licensecheck in
/home/reviewer/fedora/rawhide/1988952-CSFML/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/CSFML, /usr/share/CSFML/doc,
/usr/share/CSFML/doc/html
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/CSFML/doc/html,
/usr/share/CSFML/doc, /usr/share/CSFML
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/include/SFML(SFML-
devel), /usr/include/SFML/Audio(SFML-devel),
/usr/include/SFML/Graphics(SFML-devel),
/usr/include/SFML/Network(SFML-devel), /usr/include/SFML/System(SFML-
devel), /usr/include/SFML/Window(SFML-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[!]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
- /usr/share/
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #4 from Petr Menšík --- Reference to guidelines regarding shared libraries: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952
--- Comment #3 from Petr Menšík ---
(In reply to Artur Frenszek-Iwicki from comment #2)
> > I think lowercase package name should be used.
> The "normal" SFML package has an upper-case name, so that's why I went with
> that. SDL and SDL2 do this as well.
> https://src.fedoraproject.org/rpms/SFML
Okay, I take it back. Guidelines mention recommended case is lower [1], but if
upstream wants it uppercase, it can be. Upstream seems to reference to it
always uppercase [2]. DNF does not care anyway and would accept dnf install
csfml. I were surprised dnf install sfml-devel passed when the package is
SFML-devel. If SFML is also uppercase, it should be similar way. rpm requires
correct case, dnf does not.
>
> > I would recommend including first number of library so version in non-devel
> > package instead of %{_libdir}/*.so.*.
> I'll take a look at how other packages handle this.
It helps watching for binary incompatible upgrades if so version in included in
name.
For libcsfml-audio.so.2.5 it might be %{_libdir}/libcsfml-*.so.2*
If it upgrades to %{_libdir}/libcsfml-*.so.3* later, it would require all
depending packages to be rebuilt with new library. Explicit change in spec
helps to remember when such action might be needed. When upgrade is not just
internal improvements, but also incompatible public API changes.
1.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity
2. https://www.sfml-dev.org/download/csfml/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952
--- Comment #2 from Artur Frenszek-Iwicki ---
> I think lowercase package name should be used.
The "normal" SFML package has an upper-case name, so that's why I went with
that. SDL and SDL2 do this as well.
https://src.fedoraproject.org/rpms/SFML
> I would recommend including first number of library so version in non-devel
> package instead of %{_libdir}/*.so.*.
I'll take a look at how other packages handle this.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library
https://bugzilla.redhat.com/show_bug.cgi?id=1988952
Petr Menšík changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
CC||pemen...@redhat.com
--- Comment #1 from Petr Menšík ---
Just few notes yet:
I think lowercase package name should be used. It is preferred and does not
make sense to have upper case C binding, when nobody can mix it with common
word.
I would recommend including first number of library so version in non-devel
package instead of %{_libdir}/*.so.*. Helps on later rebases to protect against
ABI breaking updates without dependencies rebuilt.
Otherwise looks ready for formal review. Later :)
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
