[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 Mamoru TASAKA changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2021-08-25 14:32:13 --- Comment #11 from Mamoru TASAKA --- Successfully built on rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1823091 Thank you for review! Closing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-image_size -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #9 from Mamoru TASAKA --- https://pagure.io/releng/fedora-scm-requests/issue/36436 https://pagure.io/releng/fedora-scm-requests/issue/36437 https://pagure.io/releng/fedora-scm-requests/issue/36438 https://pagure.io/releng/fedora-scm-requests/issue/36439 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #8 from Mamoru TASAKA --- Thank you!! By the way, FYI I debugged out s390x issue: https://github.com/toy/image_size/pull/16 : I will include this patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 Jarek Prokop changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Jarek Prokop --- LGTM. Package approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #6 from Mamoru TASAKA --- * if ( uname -m | grep -q s390x ) 1. %ifarch s390x won't work because the srpm is **noarch** . Actually build environment is of course on some target, so "uname -m" returns some arch-dependent result, but in this case %ifarch matches "noarch". 2. s390x issue needs debugging, currently I have not figure out what component is fault, I want to debug later, however I don't want to think this is a blocker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #5 from Jarek Prokop --- * if ( uname -m | grep -q s390x ) - use the ifarch conditional instead `%ifarch s390x` (improves readability IMO) - The issue should be reported upstream if it is not the fault of the Fedora environment. Other than that the package is LGTM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #4 from Mamoru TASAKA --- Updated: * For FSF address issue, I will ask the upstream later * For spec Gemfile and so on, I will keep removing them. https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-image_size.spec https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-image_size-2.1.1-2.fc34.src.rpm * Wed Aug 18 2021 Mamoru TASAKA - 2.1.1-2 - Remove unneeded environment setting - Disable failing test on s390x -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931
--- Comment #3 from Mamoru TASAKA ---
Thank you for review, I will reply and update the spec in tomorrow (perhaps).
Just some notes:
* %{nil} convention
This is useful when I want to add additional lines after "spec \" line.
When not using %{nil}, I have to write "spec" (ends here), and when I want to
add additional
line, I have to change the line to "spec \", while using %nil as "sentinel",
this can
make diff a bit smaller.
* Doc subpackage could be noarch.
Actually I wonder why gem2rpm writes "noarch" to subpackage... When the main
package is
marked as "BuildArch: noarch", all subpackages becomes noarch automatically.
(Conversely: we cannot make subpackage arch-dependent when writing main
package as
"BuildArch: noarch")
* You do not have to move the gemspec file in %prep.
This is to clean up build dir after rebuild.
When you do "$ rpmbuild --rebuild *.src.rpm" or "$ fedpkg --release f34 local
-- --clean",
you can see:
---
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/tasaka1/rpmbuild/INSTROOT/rubygem-image_size-2.1.1-1.fc34-foo-tasaka1
Wrote:
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/rubygem-image_size-2.1.1-1.fc34.src.rpm
Wrote:
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/noarch/rubygem-image_size-2.1.1-1.fc34.noarch.rpm
Wrote:
/home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/noarch/rubygem-image_size-doc-2.1.1-1.fc34.noarch.rpm
Executing(%clean): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.9WXLyW
+ umask 022
+ cd /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review
+ cd image_size-2.1.1
+ /usr/bin/rm -rf
/home/tasaka1/rpmbuild/INSTROOT/rubygem-image_size-2.1.1-1.fc34-foo-tasaka1
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(--clean): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.ENZqEC
+ umask 022
+ cd /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review
+ rm -rf image_size-2.1.1 <
+ RPM_EC=0
++ jobs -p
+ exit 0
---
Without moving every unpackaged files under the directory specfied by "%setup
-n" option,
files are not cleaned up after rpmbuild.
Actually I oppose to use directories outside the one specified by "%setup
-n".
* I will ask the upstream to modify FSF address later, however for now I will
leave this
as it is.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931
--- Comment #2 from Jarek Prokop ---
Rpmlint is complaining about FSF's address in the GPL license file; it seems
upstream might have an old license file?
~~~
$ rpmlint ./srpm-unpacked/rubygem-image_size.spec
srpm/rubygem-image_size-2.1.1-1.fc34.src.rpm
results/rubygem-image_size-2.1.1-1.fc35.noarch.rpm
== rpmlint session starts ==
rpmlint: 2.0.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
rubygem-image_size.noarch: E: incorrect-fsf-address
/usr/share/gems/gems/image_size-2.1.1/GPL
~~~
* `export RUBY_LIB=$(pwd)/lib` in %check does not do anything (or shouldn't)
- Ruby's manpage specifies that the correct variable name is `RUBYLIB`
- it does not seem to be required to run the test suite (I tested it)
* `%{nil}` is used. I am not really sure what it does? Why is it being supplied
to the rm -rf?
Small nits (not blockers):
* Doc subpackage could be noarch.
* You do not have to move the gemspec file in %prep.
The path a level above can be supplied as well; like so: `gem build
../%{gem_name}-%{version}.gemspec`.
* Consider using `gem2rpm`, which does most of the work for you in the case of
RubyGems in a standardized way.
* JFTR, the upstream's gemspec, Gemfile, and `spec/` test suite can be included
in the *-doc subpackage as it can be used for a reference.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 Jarek Prokop changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Flags||fedora-review? CC||jpro...@redhat.com Assignee|nob...@fedoraproject.org|jpro...@redhat.com Status|NEW |ASSIGNED --- Comment #1 from Jarek Prokop --- Taking for a review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
