[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||yaksa-0.2-3.fc37 Resolution|--- |ERRATA Last Closed||2023-04-25 18:33:09 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Oh, this was built a long time ago. I forgot to close the ticket. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Jerry James --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > Oh, I see Ben took in the meantime. If you have something else, I can do it. Well, it was my turn for a delay. :-) I have nothing else at the moment. Don't worry about it. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Oh, I see Ben took in the meantime. If you have something else, I can do it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- - Package contains bundled files from uthash-devel: src/external/yuthash.h and src/external/yutlist.h. Can it be unbundled? Done. - Note the rpmlint complaint about strange permission on yaksa.spec I think this is some artefact of rpmautospec. Locally the spec file has normal mode. Regardless, it should go away once the import to dist-git happens, since git doesn't track the full permission set anyway. Spec URL: https://in.waw.pl/~zbyszek/fedora/yaksa.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/yaksa-0.2-2.fc37.src.rpm -- > I could use a review of bug 2080472. I'll try to do it this weekend. Sorry for the delay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959
--- Comment #6 from Jerry James ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues
==
- Package contains bundled files from uthash-devel: src/external/yuthash.h and
src/external/yutlist.h. Can it be unbundled?
- Note the rpmlint complaint about strange permission on yaksa.spec
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License", "GNU General
Public License v3.0 or later", "BSD 1-Clause License". 210 files have
unknown license. Detailed output of licensecheck in
/home/jamesjer/2053959-yaksa/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yaksa-
devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upst
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Flags||fedora-review? Assignee|nob...@fedoraproject.org|loganje...@gmail.com --- Comment #5 from Jerry James --- I will take this review. If you are up for a python package, I could use a review of bug 2080472. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Benson Muite changed: What|Removed |Added CC||benson_mu...@emailplus.org --- Comment #4 from Benson Muite --- Thanks. Spec file and source RPM are accessible -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Ooops ;) Spec URL: https://in.waw.pl/~zbyszek/fedora/yaksa.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/yaksa-0.2-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Artur Frenszek-Iwicki changed: What|Removed |Added CC||fed...@svgames.pl --- Comment #2 from Artur Frenszek-Iwicki --- Both the spec and SRPM link give me a 403 Forbidden. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- Spec URL: https://in.waw.pl/~zbyszek/yaksa.spec SRPM URL: https://in.waw.pl/~zbyszek/yaksa-0.2-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2053959] Review Request: yaksa - High-performance library for noncontiguous data
https://bugzilla.redhat.com/show_bug.cgi?id=2053959 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Summary|Review Request: -|for noncontiguous data -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053959 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
