needinfo canceled: [Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
Product: Fedora Version: rawhide Component: Package Review Benson Muite has canceled Package Review 's request for Benson Muite 's needinfo: Bug 2121585: Review Request: janus - An open source general purpose WebRTC server. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #85 from Benson Muite --- Happy to finish the review. Would be great to get this into Fedora. -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Benson Muite changed: What|Removed |Added Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #85 from Benson Muite --- Happy to finish the review. Would be great to get this into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c85 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #83 from Benson Muite --- Pull request to use newer versions of jquery and other external assets: https://github.com/meetecho/janus-gateway/pull/3279 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c83 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #82 from Benson Muite --- Upstream has migrated to using lua-term which is in Fedora: https://github.com/meetecho/janus-gateway/issues/3272 https://packages.fedoraproject.org/pkgs/lua-term/lua-term/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c82 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #81 from Benson Muite --- A description of steps have taken to deploy Janus: https://github.com/nairobilug/nairobilug.or.ke/pull/201/files Some web applications like Apache or Nginx can run directly when installed. For Janus, choices of configuration options make this more difficult. One could enable all transports, but STUN server choice should be set by the person deploying. May want to examine choices made in other distros. Will see if can add more documentation to the .jcfg files upstream. It may be helpful to package some of the additional Javascript files and remove non-essential ones from the demos. FEdora had jquery 1: https://src.fedoraproject.org/rpms/js-jquery1/blob/f32/f/js-jquery1.spec And has newer versions: https://src.fedoraproject.org/rpms/js-jquery https://src.fedoraproject.org/rpms/js-jquery2 Will see if can make a pull request upstream -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c81 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #80 from Benson Muite --- Each Janus service has a set of default ports it uses. If running Janus without a reverse proxy, these ports need to be open. If using a reverse proxy, then the webserver needs to be able to connect to Janus. It may be helpful to modify SELinux configurations to allow for these. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c80 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #79 from Benson Muite --- html documentation downloads javascript and css files from Cloudflare, yet most of them are packaged. Demo files try to read /usr/share/font-awesome-web/css/ which will typically not be available when the demos are accessed from a remote website. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c79 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #78 from Renich Bon Ciric --- (In reply to Benson Muite from comment #76) > Related review: > https://bugzilla.redhat.com/show_bug.cgi?id=2239129 You rock. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c78 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #77 from Renich Bon Ciric --- Right on. Had to tweak that a little. The requires is for policycoreutils-python-utils, which would be a kind of a para-palindrome if it was named policycoreutils-python-utilscorepolicy. :D Bad joke, I know. Here're the resources: spec: https://renich.fedorapeople.org/janus/janus.spec srpm: https://renich.fedorapeople.org/janus/janus-1.2.0-3.fc38.src.rpm A test run and it seems to have worked. ~~~ [renich@desktop rpmbuild]$ sudo dnf --nogpgcheck --repofrompath=local,results/fedora-38-x86_64/ install janus-demos [sudo] password for renich: Sorry, try again. [sudo] password for renich: Added local repo from results/fedora-38-x86_64/ local 1.1 MB/s | 23 kB 00:00 Dependencies resolved. = PackageArchitecture Version Repository Size = Installing: janus-demosnoarch 1.2.0-3.fc38 local 1.3 M Installing dependencies: janus x86_64 1.2.0-3.fc38 local 356 k janus-plugins-audiobridge x86_64 1.2.0-3.fc38 local 122 k janus-plugins-echotest x86_64 1.2.0-3.fc38 local34 k janus-plugins-recordplay x86_64 1.2.0-3.fc38 local 200 k janus-plugins-sip x86_64 1.2.0-3.fc38 local97 k janus-plugins-streamingx86_64 1.2.0-3.fc38 local 4.0 M janus-plugins-textroom x86_64 1.2.0-3.fc38 local55 k janus-plugins-videocallx86_64 1.2.0-3.fc38 local39 k janus-plugins-videoroomx86_64 1.2.0-3.fc38 local 159 k sofia-sip x86_64 1.13.13-1.fc38 fedora 619 k usrsctpx86_64 1:0.9.5.0-6.fc38 fedora 258 k Transaction Summary = Install 12 Packages Total size: 7.2 M Total download size: 877 k Installed size: 12 M Is this ok [y/N]: y Downloading Packages: (1/2): usrsctp-0.9.5.0-6.fc38.x86_64.rpm 147 kB/s | 258 kB 00:01 (2/2): sofia-sip-1.13.13-1.fc38.x86_64.rpm 274 kB/s | 619 kB 00:02 --
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #76 from Benson Muite --- Related review: https://bugzilla.redhat.com/show_bug.cgi?id=2239129 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c76 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #75 from Benson Muite ---
For selinux permissions see:
https://fedoraproject.org/wiki/PackagingDrafts/SELinux
Probably does not make sense to create a new policy, since if one wants to run
demos, they are read by a web server.
Thus add:
Requires(post): policycoreutils-python
Requires(postun): policycoreutils-python
...
%post
semanage fcontext -a -t httpd_sys_content_t '%{_datadir}/%{name}/demos(/.*)?'
2>/dev/null || :
restorecon -R %{_datadir}/awstats/wwwroot/cgi-bin || :
%postun
if [ $1 -eq 0 ] ; then # final removal
semanage fcontext -d -t httpd_sys_content_t '%{_datadir}/%{name}/demos(/.*)?'
2>/dev/null || :
fi
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c75
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #74 from Benson Muite --- [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c74 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #73 from Renich Bon Ciric --- OK, here's here's what I did: - Moved .so files into their respective plugins. Plugins don't work without them. - Added lua-json as a dependency for the lua plugin. - Added plugin dependencies to janus-demos. - Added back the audiobridge plugin. spec: https://renich.fedorapeople.org/janus/janus.spec srpm: https://renich.fedorapeople.org/janus/janus-1.2.0-2.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c73 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #72 from Renich Bon Ciric --- Hey Benson! > When trying to run it on a Fedora 38 server, janus-devel seems to be needed. Yeah, you're right. the devel package contains all the plugins. I shouldn't have put those in the devel package. They're loaded at runtime if required. They should be package with each plugin, event handler, etc. > Service file works. Good to know. :) > audiobridge plugin seem to be missing. Yeah, it's not being built anymore. Tried looking for the reason somewhere but couldn't find it. > It may be helpful to get the demo package to explicitly require all needed > plugins Good idea. Will look into this. > May also want to set the folder for the demo package /usr/share/janus/demos > to have se-linux context for a webserver httpd_sys_content_t I'll look into the SELinux thingy as well. I dunno if demos is supposed to be served by a web server. It's just a local/static website. It's more of a documentation implementation so that one can see how it works. On other matters, versioned plugins (libjanus_http.so.2.0.0, for example) aren't being loaded; only unversioned ones are (which we don't ship). A workaround would be to synlink versioned to unversioned files but I don't think it's a good idea to do that. I already raised the issue with upstream: https://github.com/meetecho/janus-gateway/issues/3270 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c72 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #71 from Benson Muite --- Service file works. audiobridge plugin seem to be missing. It may be helpful to get the demo package to explicitly require all needed plugins May also want to set the folder for the demo package /usr/share/janus/demos to have se-linux context for a webserver httpd_sys_content_t -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c71 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #70 from Benson Muite --- When trying to run it on a Fedora 38 server, janus-devel seems to be needed. The service file also fails to start, but can start it on the command line -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c70 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #69 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6281436 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/06281436-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c69 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #68 from Fedora Review Service --- Created attachment 1983386 --> https://bugzilla.redhat.com/attachment.cgi?id=1983386&action=edit The .spec file difference from Copr build 5929568 to 6281436 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c68 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #67 from Renich Bon Ciric --- Hello again, So, I've: * Updated to v1.2.0. * Removed the audiobridge plugin. * Again, selectively including files generated by doxygen in Fedora 37, 38, 39 and rawhide. * Patched janus so it uses the system's cypher recommendations. SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.2.0-1.fc40.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121585%23c67 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #66 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5929568 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05929568-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #65 from Fedora Review Service --- Created attachment 1965307 --> https://bugzilla.redhat.com/attachment.cgi?id=1965307&action=edit The .spec file difference from Copr build 5580064 to 5929568 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #64 from Renich Bon Ciric --- OK, I've figured out how to do copr builds myself, hehe. Finally. In any case, will leave this here for now. I still need to try the patch for resolving "crypto-policy-non-compliance-openssl". Also, I would like to know how to solve so many "undefined-non-weak-symbol" errors. SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.3-1.fc38.src.rpm Latest build (with review): https://copr.fedorainfracloud.org/coprs/renich/janus/build/5929542/ I am not gone yet. I've just had a ton of work lately. Found some time to do this today. Will try hard to do this more regularly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Jakub Kadlčík changed: What|Removed |Added URL||https://janus.conf.meetecho ||.com/ --- Comment #63 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5580064 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05580064-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #62 from Jakub Kadlčík --- Created attachment 1947031 --> https://bugzilla.redhat.com/attachment.cgi?id=1947031&action=edit The .spec file difference from Copr build 5382837 to 5580064 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #61 from Renich Bon Ciric --- OK, here's a test. Lorenzo asked us to see if this was enough when it comes to "gethostbyname": SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-4.fc37.src.rpm If all goes well, this should solve the "binary-or-shlib-calls-gethostbyname" issue. Fingers crossed. In my test, it does. ;D [builder@bldr0 fc-rawhide]$ ls build.log janus-plugins-nosip-1.1.2-4.fc39.x86_64.rpm hw_info.log janus-plugins-nosip-debuginfo-1.1.2-4.fc39.x86_64.rpm installed_pkgs.log janus-plugins-recordplay-1.1.2-4.fc39.x86_64.rpm janus-1.1.2-4.fc39.src.rpm janus-plugins-recordplay-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-1.1.2-4.fc39.x86_64.rpm janus-plugins-sip-1.1.2-4.fc39.x86_64.rpm janus-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-sip-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-debugsource-1.1.2-4.fc39.x86_64.rpm janus-plugins-streaming-1.1.2-4.fc39.x86_64.rpm janus-demos-1.1.2-4.fc39.noarch.rpm janus-plugins-streaming-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-devel-1.1.2-4.fc39.x86_64.rpm janus-plugins-textroom-1.1.2-4.fc39.x86_64.rpm janus-doc-1.1.2-4.fc39.noarch.rpm janus-plugins-textroom-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-gelf-1.1.2-4.fc39.x86_64.rpm janus-plugins-videocall-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-gelf-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-videocall-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-mqtt-1.1.2-4.fc39.x86_64.rpm janus-plugins-videoroom-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-mqtt-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-videoroom-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-nanomsg-1.1.2-4.fc39.x86_64.rpm janus-plugins-voicemail-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-nanomsg-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-voicemail-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-rabbitmq-1.1.2-4.fc39.x86_64.rpm janus-tools-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-rabbitmq-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-tools-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-sample-1.1.2-4.fc39.x86_64.rpm janus-transports-http-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-sample-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-http-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-ws-1.1.2-4.fc39.x86_64.rpm janus-transports-mqtt-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-ws-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-mqtt-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-loggers-json-1.1.2-4.fc39.x86_64.rpm janus-transports-nanomsg-1.1.2-4.fc39.x86_64.rpm janus-loggers-json-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-nanomsg-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-audiobridge-1.1.2-4.fc39.x86_64.rpm janus-transports-pfunix-1.1.2-4.fc39.x86_64.rpm janus-plugins-audiobridge-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-pfunix-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-duktape-1.1.2-4.fc39.x86_64.rpm janus-transports-rabbitmq-1.1.2-4.fc39.x86_64.rpm janus-plugins-duktape-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-rabbitmq-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-echotest-1.1.2-4.fc39.x86_64.rpm janus-transports-websockets-1.1.2-4.fc39.x86_64.rpm janus-plugins-echotest-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-websockets-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-lua-1.1.2-4.fc39.x86_64.rpm root.log janus-plugins-lua-debuginfo-1.1.2-4.fc39.x86_64.rpm state.log [builder@bldr0 fc-rawhide]$ rpmlint *.rpm = rpmlint session starts = rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 59 janus-devel.x86_64: W: only-non-binary-in-usr-lib janus-demos.noarch: W: no-documentation janus-devel.x86_64: W: no-documentation janus.x86_64: W: incoherent-version-in-changelog 1.1.2-3 ['1.1.2-4.fc39', '1.1.2-4'] janus-doc.noarch: W: files-duplicate /usr/share/doc/janus/html/search/variables_10.js /usr/share/doc/ja
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #60 from Renich Bon Ciric --- Great! Less warnings. I have an untested patch for the SSL issue and we have a branch to test the gethostbyname issue. Once we do those, the only thing left is to figure out the: "undefined-non-weak-symbol" warning... no idea on that one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #58 from Jakub Kadlčík --- Created attachment 1941456 --> https://bugzilla.redhat.com/attachment.cgi?id=1941456&action=edit The .spec file difference from Copr build 5303569 to 5382837 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #59 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5382837 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05382837-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #57 from Renich Bon Ciric --- (In reply to Benson Muite from comment #56) > a) devel packages should have header files and .so libraries, other library > files .so.1 and .so.1.1.2 should be in main packages. Should the plugins > have devel packages? If not, plugin libraries should not be on ld path. A > method of listing private libraries which may work is described at: > https://lists.fedoraproject.org/pipermail/devel/2012-June/169190.html Hey Benson, nice to read you. :D Well, I failed to see which the listing method was. I've added the __provides_exclude_from and __requires_exclude_from macros to all .so files to avoid looking for dependencies there since they, indeed, are private libraries. (event handlers, loggers, plugins and transports). If you think I need to create devel packages for every plugin and include the .so files there, I will. No problem. I might've understood wrongly what you said. > b) no-documentation warnings are fine OK. Phew! > c) Ok on duplicates at this point. Can address this after other issues. It > is likely there are minor differences in the files. OK. > d) > rpmlint -e file-contains-date-and-time > file-contains-date-and-time: > Your file uses __DATE__ and __TIME__ which causes the package to rebuild when > not needed. > > rpmlint -e file-contains-current-date > file-contains-current-date: > Your file contains the current date, this may cause the package to rebuild in > excess. > > > Doxygen does not add a timestamp: > https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen. > cfg#L1219 > https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen. > cfg#L1846 > > However, footer has a date: > https://github.com/meetecho/janus-gateway/blob/master/docs/footer.html#L16 I've created a patch to remove the date from the footer. I'll include it in the next build. Hopefully, that takes care of most of the messages. > For record_play not sure what is causing this error: > https://github.com/meetecho/janus-gateway/blob/master/src/plugins/ > janus_recordplay.c I see there is an example date written in an example, right after the note: https://janus.conf.meetecho.com/docs/recordplay.html That might be triggering the warning, right? > For version, maybe it is better to get GitHub CI to generate this > information and have it distributed: > https://github.com/meetecho/janus-gateway/blob/master/src/version.h > https://stackoverflow.com/questions/1704907/how-can-i-get-my-c-code-to- > automatically-print-out-its-git-version-hash/1843783#1843783 version.c gets auto-generated after `make`. it's even ignored in .gitignore to this end. I have no idea of how it gets generated but, when it does, it has the current date. [root@bc8d0dcfefb2 janus]# cat src/version.c #include "version.h" const char *janus_build_git_sha = "e8d1395d3de9caa5e244605ec1a7281cd7d3ecf1"; const char *janus_build_git_time = "Wed Feb 1 05:08:47 UTC 2023"; int janus_version = 1102; const char *janus_version_string = "1.1.2"; const char *libnice_version_string = "0.1.19"; > It seems one can set SOURCE_DATE_EPOCH as an optional parameter before using > autogen > https://github.com/meetecho/janus-gateway/blob/master/src/Makefile.am#L178 > However, having this information in the release would likely enable more > efficient automated builds. I didn't really understand what you meant here. We should pass this SOURCE_DATE_EPOCH env var to autgen? Which date should we provide? The commit's date? OK, I know where version.c gets generated. Right bellow the link you gave me: https://github.com/meetecho/janus-gateway/blob/master/src/Makefile.am#L183. With gawk. :D What do we do with this? > e) Raised an issue on gethostbyname > https://github.com/meetecho/janus-gateway/issues/3156 Thank you very much for the help. :D > f) Further comments: > i) Consider adding make as a build dependency, cmake will bring it in, but > one might consider builds without cmake Done. It's been added to BuildRequires. > ii) Would it be better to use BoringSSL > https://boringssl.googlesource.com/boringssl/ instead of OpenSSL Well, the message in their own website is discouraging. "Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is.". I'd rather stick to openssl unless you think boring is better. The updated SPEC and SRPM: SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-3.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedorap
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #56 from Benson Muite --- a) devel packages should have header files and .so libraries, other library files .so.1 and .so.1.1.2 should be in main packages. Should the plugins have devel packages? If not, plugin libraries should not be on ld path. A method of listing private libraries which may work is described at: https://lists.fedoraproject.org/pipermail/devel/2012-June/169190.html b) no-documentation warnings are fine c) Ok on duplicates at this point. Can address this after other issues. It is likely there are minor differences in the files. d) rpmlint -e file-contains-date-and-time file-contains-date-and-time: Your file uses __DATE__ and __TIME__ which causes the package to rebuild when not needed. rpmlint -e file-contains-current-date file-contains-current-date: Your file contains the current date, this may cause the package to rebuild in excess. Doxygen does not add a timestamp: https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen.cfg#L1219 https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen.cfg#L1846 However, footer has a date: https://github.com/meetecho/janus-gateway/blob/master/docs/footer.html#L16 For record_play not sure what is causing this error: https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_recordplay.c For version, maybe it is better to get GitHub CI to generate this information and have it distributed: https://github.com/meetecho/janus-gateway/blob/master/src/version.h https://stackoverflow.com/questions/1704907/how-can-i-get-my-c-code-to-automatically-print-out-its-git-version-hash/1843783#1843783 It seems one can set SOURCE_DATE_EPOCH as an optional parameter before using autogen https://github.com/meetecho/janus-gateway/blob/master/src/Makefile.am#L178 However, having this information in the release would likely enable more efficient automated builds. e) Raised an issue on gethostbyname https://github.com/meetecho/janus-gateway/issues/3156 f) Further comments: i) Consider adding make as a build dependency, cmake will bring it in, but one might consider builds without cmake ii) Would it be better to use BoringSSL https://boringssl.googlesource.com/boringssl/ instead of OpenSSL -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #55 from Renich Bon Ciric --- Hello, I'll address the review's rpmlint warnings and errors here: > janus-devel.x86_64: W: only-non-binary-in-usr-lib There are several files here that might have to be part of the main package, as stated here (from https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages): "As an additional complication, some software generates unversioned shared objects which are not intended to be used as system libraries. These files are usually plugins or modular functionality specific to an application, and are not located in the ld library paths or cache. This means that they are not located directly in /usr/lib or /usr/lib64, or in a directory listed as a library path in /etc/ld.so.conf (or an /etc/ld.so.conf.d/config file). Usually, these unversioned shared objects can be found in a dedicated subdirectory under /usr/lib or /usr/lib64 (e.g. /usr/lib/purple-2/ is the plugin directory used for libpurple applications). In these cases, the unversioned shared objects do not need to be placed in a -devel package." In this case, these, in fact, are plugins and do live in a path listed as a library path. They also live in their own subdirectory. If you agree, I am moving these to the main package. Also, I think, these warnings should be ignored. > janus-demos.noarch: W: no-documentation There is, in fact, no documentation for demos. It's just an "offline website" that shows a demonstration of the plugin's capabilities. Let me know how to proceed here. > janus-devel.x86_64: W: no-documentation Devel does have a ton of documentation but it is packaged in the "doc" sub-package. I didn't find anything in the packaging guidelines that says I should forcibly include anything in the devel sub-package. I think this message should be ignored as well. Let me know how to proceed, please. > janus-doc.noarch: W: files-duplicate > /usr/share/doc/janus/html/search/variables_10.js > /usr/share/doc/janus/html/search/all_10.js Indeed, I have two cases of "duplicate files" here but this documentation is generated on-the-fly by doxygen. I don't know enough doxygen as to know if I can safely remove or merge these files. Let me know how to proceed with these, please. Nothing in the packaging guidelines either. I found nothing in the packaging guidelines in regards to duplicate documentation resources. The only duplication subject I could find was in regards to bundled libraries. > janus-doc.noarch: E: file-contains-date-and-time > /usr/share/doc/janus/html/recordplay.html > janus-doc.noarch: E: file-contains-current-date > /usr/share/doc/janus/html/voicemail.html As mentined above, the documentation package is generated by doxygen. All files will have the current date so, IMHO, that message should be ignored. About the files containing the current date, yes, this is, also, expected. One curious thing, though. When I run rpmlint against the doc subpackage, I don't get those messages; not even with the `--strict` flag. I wonder if this message is no longer useful and the builder's rpmlint version still has it? > janus.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/janus > SSL_CTX_set_cipher_list I've talked about this with upstream here: https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/YGXU4J0VAwAJ I've proposed a patch but, as said there, I am not a C developer. In any case, that conversation fell off. I'm gonna start a thread on their mailing list just about this to see if we can work it out. > janus-plugins-audiobridge.x86_64: W: binary-or-shlib-calls-gethostbyname > /usr/lib64/janus/plugins/libjanus_audiobridge.so.1.1.2 > janus-plugins-nosip.x86_64: W: binary-or-shlib-calls-gethostbyname > /usr/lib64/janus/plugins/libjanus_nosip.so.1.1.2 > janus-plugins-sip.x86_64: W: binary-or-shlib-calls-gethostbyname > /usr/lib64/janus/plugins/libjanus_sip.so.1.1.2 These I haven't mentioned, I think, to upstream. I'll see if I can get them to switch to getaddrinfo. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #53 from Jakub Kadlčík --- Created attachment 1940547 --> https://bugzilla.redhat.com/attachment.cgi?id=1940547&action=edit The .spec file difference from Copr build 5300635 to 5303569 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #54 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5303569 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05303569-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #52 from Renich Bon Ciric --- Ah, I forgot about rawhide, hehe. SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-2.fc37.src.rpm I tested this build on fc36, fc37 and rawhide this time. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #50 from Jakub Kadlčík --- Created attachment 1940528 --> https://bugzilla.redhat.com/attachment.cgi?id=1940528&action=edit The .spec file difference from Copr build 5238279 to 5300635 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #51 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5300635 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05300635-janus/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #49 from Renich Bon Ciric --- OK, i've: * updated to v1.1.2. * fixed the fc36 issue by selectively grabbing files for the RPM when fc36 is being used to package. * removed the libcurl patch since it's included in upstream. SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-1.fc37.src.rpm Fingers crossed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #48 from Renich Bon Ciric --- Thanks a lot, Jakub, for that. I see all X's, which is a good thing, for Rawhide and Fedora 37. For some reason, it didn't find some files in Fedora 36. It seems I'm suffering of what I mentined in this comment: ccomment #43. I'll see what I can find. doxygen might be to blame. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #47 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5238279 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2121585-janus/fedora-rawhide-x86_64/05238279-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #46 from Renich Bon Ciric --- OK, the mock build was failing due to a dependency issue: * I was requiring gstreamer1.0-plugins-good while it should've been gstreamer1-plugins-good. * Also, I had a needless dependency for js-jquery on the doc package. We agreed to use the bundled one (jquery v1.9.4) and, later on, see if upstream wants to upgrade to it. In any case, mock builds fine now. Can we try again? SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.1-5.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #44 from Jakub Kadlčík --- Created attachment 1935812 --> https://bugzilla.redhat.com/attachment.cgi?id=1935812&action=edit The .spec file difference from Copr build 5152862 to 5200691 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #45 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5200691 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2121585-janus/fedora-rawhide-x86_64/05200691-janus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #43 from Renich Bon Ciric --- Hey Benson! Happy new year and all that. ;D (In reply to Benson Muite from comment #41) > f) Perhaps ask on Fedora security list: > https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org/ OK. I'll take it into account. I'm waiting on upstream to see if a proposed patch fixes stuff. They're checking. I'll consult with the Fedora Security team afterwards. > Current version fails to build: > In file included from /usr/include/curl/curl.h:3195, > from turnrest.c:21: > turnrest.c: In function 'janus_turnrest_request': > turnrest.c:168:9: error: void value not ignored as it ought to be > 168 | curl_easy_setopt(curl, api_http_get ? CURLOPT_HTTPGET : > CURLOPT_ > POST, 1); > | > > Reported this https://github.com/meetecho/janus-gateway/issues/3131 Thank you, so much, for reporting this. I see they've fixed it and I've taken the patch and applied it. Thanks for the help. > g) Browsers such as Firefox and Chrome seem to ship with a configuration > specifically for Fedora. Maybe we could do the same for janus, have a Fedora > themed demo? I dunno how this will sit with upstream. They seem interested in their industrial design (or whatever that is called). My take would be to focus on packaging as is and, later on, we could ask upstream about this and see what they think. I'm all for it, though. So, spec and SRPM: SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.1-4.fc37.src.rpm I've tested the build with mock; using F37 and F36 profiles. The F37 build finished successfully. The F36 didn't. It reported some "files not found" which is kind of odd since I am using the same SRPM for both (same spec and all). I get this when trying to build on Fedora 36: # mock -r fedora-36-x86_64 ... ... Processing files: janus-doc-1.1.1-4.fc36.noarch error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_00.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_01.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_02.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_05.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_seld.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/splitbard.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_ad.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_bd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_sd.png RPM build errors: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_00.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_01.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_02.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_04_05.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg File not found:
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #42 from Benson Muite --- Issue https://github.com/meetecho/janus-gateway/issues/3131 is fixed, may want to either use a later commit/release or apply a patch. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #41 from Benson Muite --- f) Perhaps ask on Fedora security list: https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org/ Current version fails to build: In file included from /usr/include/curl/curl.h:3195, from turnrest.c:21: turnrest.c: In function 'janus_turnrest_request': turnrest.c:168:9: error: void value not ignored as it ought to be 168 | curl_easy_setopt(curl, api_http_get ? CURLOPT_HTTPGET : CURLOPT_ POST, 1); | Reported this https://github.com/meetecho/janus-gateway/issues/3131 g) Browsers such as Firefox and Chrome seem to ship with a configuration specifically for Fedora. Maybe we could do the same for janus, have a Fedora themed demo? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #40 from Renich Bon Ciric --- Hey Benson! Me again. Just formating the past comment with proper quotes. Sorry for the mistake. > a) If you do a build in copr, you can get output of fedora-review, see: OK, I'll try to do this in order to get the review so I can figure out and fix the issues presented. > b) jquery is packaged: > https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/ > The spec file has both: > Requires: js-jquery > and > Provides: bundled(js-jquery) = 1.9.1 > Is this reasonable? Could only the packaged js-jquery be used? I think it is. The docs require this old version of jquery (1.9.1 vs 3.6.0 which is what Fedora packaged). Upstream has a ticket where they upgraded to the newest version that didn't break their demos and documentation. I'll propose to upgrade to v3.6.0 and, when they do, update the packages to use what Fedora provides. I'll remove the Requires js-jquery for now. Do you agree? > c) None of the other javascript libraries seem to be packaged. Are any of > them likely to be used elsewhere? For example boostrap? In which case, could > they be packaged separately? Well, they could be packaged but, for now, I'd like to go with what Petr Mensik suggested here: https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/message/G4SR25UUCDF4EJCWUF5T5H4WENSUUO6B/ I'd like to do exactly that: * use the bundled js-query when possible (read above). * use bundled() for now and create bug tickets subsequently to create packages for those. The bootstrap one is a bit tricky. Janus' docs and demos use the ECMAScript part of bootstrap but not the CSS. The CSS is modified and is provided as a theme. That project is called Bootswatch: https://bootswatch.com/ In order to be consistent, I would have to package bootswatch and all the themes for Fedora. I am not saying no but I want to do this in a later occasion. IMHO, for now, we're good with the bundled() setup and, later on, I will submit packages for each and every one. Well, probably one exception; they use this node-js library from a different project. I would keep that one as bundled(). > d) $ rpmlint -e summary-too-long > summary-too-long: > The 'Summary:' must not exceed 80 characters. Right on. Will fix the summaries everywhere. > e) Demo and docs packages should probably be marked as noarch You're correct. I will mark them as so. > f) The cipher warning seems to come from line 491 in src/dtls.c see > https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/#_cc_applications > Probably an exemption or some coordination will be required with upstream. I will take this to upstream and see what they say. If that fails, I'll see what I can do with FESCo... if that's where one gets an exception granted. ;D > g) Maybe consider using this for The creative summit instead of Jitsi: > > https://communityblog.fedoraproject.org/youre-invited-to-the-creative-freedom-summit-hosted-by-the-fedora-design-team/ > > https://fedoraproject.org/wiki/Creative_Freedom_Summit_2023_Schedule > Would be happy to create a custom easily packaged theme. Err... sure. I wouldn't know where to start, hehe. I use janus as part of the communications stack that NextCloud's Talk requires. Let me know how can I help to do this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #39 from Renich Bon Ciric --- Hey Benson! > a) If you do a build in copr, you can get output of fedora-review, see: OK, I'll try to do this in order to get the review so I can figure out and fix the issues presented. b) jquery is packaged: https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/ The spec file has both: Requires: js-jquery and Provides: bundled(js-jquery) = 1.9.1 Is this reasonable? Could only the packaged js-jquery be used? I think it is. The docs require this old version of jquery (1.9.1 vs 3.6.0 which is what Fedora packaged). Upstream has a ticket where they upgraded to the newest version that didn't break their demos and documentation. I'll propose to upgrade to v3.6.0 and, when they do, update the packages to use what Fedora provides. I'll remove the Requires js-jquery for now. Do you agree? c) None of the other javascript libraries seem to be packaged. Are any of them likely to be used elsewhere? For example boostrap? In which case, could they be packaged separately? Well, they could be packaged but, for now, I'd like to go with what Petr Mensik suggested here: https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/message/G4SR25UUCDF4EJCWUF5T5H4WENSUUO6B/ I'd like to do exactly that: * use the bundled js-query when possible (read above). * use bundled() for now and create bug tickets subsequently to create packages for those. The bootstrap one is a bit tricky. Janus' docs and demos use the ECMAScript part of bootstrap but not the CSS. The CSS is modified and is provided as a theme. That project is called Bootswatch: https://bootswatch.com/ In order to be consistent, I would have to package bootswatch and all the themes for Fedora. I am not saying no but I want to do this in a later occasion. IMHO, for now, we're good with the bundled() setup and, later on, I will submit packages for each and every one. Well, probably one exception; they use this node-js library from a different project. I would keep that one as bundled(). d) $ rpmlint -e summary-too-long summary-too-long: The 'Summary:' must not exceed 80 characters. Right on. Will fix the summaries everywhere. e) Demo and docs packages should probably be marked as noarch You're correct. I will mark them as so. f) The cipher warning seems to come from line 491 in src/dtls.c see https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/#_cc_applications Probably an exemption or some coordination will be required with upstream. I will take this to upstream and see what they say. If that fails, I'll see what I can do with FESCo... if that's where one gets an exception granted. ;D g) Maybe consider using this for The creative summit instead of Jitsi: https://communityblog.fedoraproject.org/youre-invited-to-the-creative-freedom-summit-hosted-by-the-fedora-design-team/ https://fedoraproject.org/wiki/Creative_Freedom_Summit_2023_Schedule Would be happy to create a custom easily packaged theme. Err... sure. I wouldn't know where to start, hehe. I use janus as part of the communications stack that NextCloud's Talk requires. Let me know how can I help to do this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #38 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU General Public
License, Version 3", "MIT License", "BSD 3-Clause License". 442 files
have unknown license. Detailed output of licensecheck in
/home/fedora-packaging/2121585-janus/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 409600 bytes in 29 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in janus
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and re
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #37 from Renich Bon Ciric --- OK, finally, this should be the version that provides all bundled libraries while using jquery in docs and demos. Phew! That took a while. I've also added a: make check right after build. Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.1.1-2.fc37.src.rpm There were a lot of javascript and css resources being pulled from CDNs. I downloaded them all, put them in place and versioned them (because of name clashes between bootstrap-3.4.1 (bootstrap.min.css) and bootswatch-3.4.0 (bootstrap.min.css). I'll ask upstream to normalize this in the near future. In any case. Let me know what you think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #36 from Renich Bon Ciric --- Hello, I've updated to v1.1.1. Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.1.1-1.fc37.src.rpm I've been kind of busy. I am planning to finish the documentation and examples issue (resources being pulled from a CDN) this weekend. Just letting you know. :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #35 from Renich Bon Ciric --- Ah, sorry for that. Made sure no ducplicate files are present anymore. Took the chance to list all files and stop using whole directories. I, also, built it using the fc37 target: Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-5.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #34 from Benson Muite --- From fedora-review: RPM build warnings: File listed twice: /etc/janus/janus.jcfg File listed twice: /usr/lib/.build-id/01/5e83451daacf185e261b495dc8c71463be54 ff File listed twice: /usr/lib/.build-id/03/8ee15b9494b1d96857f7e2637a8c9aa0c11a e8 File listed twice: /usr/lib/.build-id/06/1fc9fedeff2ad8005d617c1c6f44503af5bc be File listed twice: /usr/lib/.build-id/0f/31a95390b207bb6ad7b50e70c52a5357322e a1 File listed twice: /usr/lib/.build-id/11/069fe29ae4ed6fcd53df791c217dfa69593e 9e File listed twice: /usr/lib/.build-id/16/baae4689156b02ce37018ebd55471d2ede95 86 File listed twice: /usr/lib/.build-id/1e/2af89e5c851ed2bd825f7f3780ed8212a23f 02 File listed twice: /usr/lib/.build-id/1f/e07a629dad38aec85cfd13ecbf518fcfd0a6 52 File listed twice: /usr/lib/.build-id/56/0a874975cc6da95a1a2d1614d058f26e8ab8 be File listed twice: /usr/lib/.build-id/5e/02f7d31eea15586ccd7cb4616a0905c0b087 f5 File listed twice: /usr/lib/.build-id/5e/752b2b4a8bfc09b65aca3331b1743af4765a c9 File listed twice: /usr/lib/.build-id/70/eada316e3d53e42e4f61f7f90e08bf676696 bb File listed twice: /usr/lib/.build-id/7a/51c52b9abb38de8b6684ceb46dd31065b403 98 File listed twice: /usr/lib/.build-id/86/c1353912f03b8daa46efd37891170769308a 08 File listed twice: /usr/lib/.build-id/92/2a12b64c01d93d22c89182bcfd606b5917c8 22 File listed twice: /usr/lib/.build-id/9a/cecaa2018b0619c806f29c128f8e2b82e49c 06 File listed twice: /usr/lib/.build-id/ab/ccdc38547e15a8ab99a8e0280aa41eeba74c 7c File listed twice: /usr/lib/.build-id/b5/1536bb0ac79b69a540563911ca3d953f3bae d3 File listed twice: /usr/lib/.build-id/c1/5b8a308ea61a433459cee7bbddac755b3341 89 File listed twice: /usr/lib/.build-id/c2/e6ced91ccae6f0d3e42497596c873b0162e9 97 File listed twice: /usr/lib/.build-id/c6/bea753c831d8d14bbb94bc5f4289de6a1eed 5f File listed twice: /usr/lib/.build-id/cd/c48948e17325e71ad55d0216861195e80051 b2 File listed twice: /usr/lib/.build-id/f4/735863009e68823bfe6e2c53107722fd871e f0 File listed twice: /usr/lib/.build-id/f6/39a096f253f97965a4d1da63c8fd62f76733 81 File listed twice: /usr/lib/.build-id/fb/f40b30a7ec978e5ac9320c3fa09a52f02274 d1 File listed twice: /usr/lib64/janus/events File listed twice: /usr/lib64/janus/events/libjanus_gelfevh.so File listed twice: /usr/lib64/janus/events/libjanus_gelfevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_gelfevh.so.1.0.1 File listed twice: /usr/lib64/janus/events/libjanus_mqttevh.so File listed twice: /usr/lib64/janus/events/libjanus_mqttevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_mqttevh.so.1.0.1 File listed twice: /usr/lib64/janus/events/libjanus_nanomsgevh.so File listed twice: /usr/lib64/janus/events/libjanus_nanomsgevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_nanomsgevh.so.1.0.1 File listed twice: /usr/lib64/janus/events/libjanus_rabbitmqevh.so File listed twice: /usr/lib64/janus/events/libjanus_rabbitmqevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_rabbitmqevh.so.1.0.1 File listed twice: /usr/lib64/janus/events/libjanus_sampleevh.so File listed twice: /usr/lib64/janus/events/libjanus_sampleevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_sampleevh.so.1.0.1 File listed twice: /usr/lib64/janus/events/libjanus_wsevh.so File listed twice: /usr/lib64/janus/events/libjanus_wsevh.so.1 File listed twice: /usr/lib64/janus/events/libjanus_wsevh.so.1.0.1 File listed twice: /usr/lib64/janus/loggers File listed twice: /usr/lib64/janus/loggers/libjanus_jsonlog.so File listed twice: /usr/lib64/janus/loggers/libjanus_jsonlog.so.1 File listed twice: /usr/lib64/janus/loggers/libjanus_jsonlog.so.1.0.1 File listed twice: /usr/lib64/janus/plugins File listed twice: /usr/lib64/janus/plugins/libjanus_audiobridge.so File listed twice: /usr/lib64/janus/plugins/libjanus_audiobridge.so.1 File listed twice: /usr/lib64/janus/plugins/libjanus_audiobridge.so.1.0.1 File listed twice: /usr/lib64/janus/plugins/libjanus_duktape.so File listed twice: /usr/lib64/janus/plugins/libjanus_duktape.so.1 File listed twice: /usr/lib64/janus/plugins/libjanus_duktape.so.1.0.1 File listed twice: /usr/lib64/janus/plugins/libjanus_echotest.so File listed twice: /usr/lib64/janus/plugins/libjanus_echotest.so.1 File listed twice: /usr/lib64/janus/plugins/libjanus_echotest.so.1.0.1 File listed twice: /usr/lib64/janus/plugins/libjanus_lua.so File listed twice: /usr/lib64/janus/plugins/libjanus_lua.so.1 File listed twice: /usr/lib64/janus/plugins/libjanus_lua.so.1.0.1 File listed twice: /usr/lib64/janus/plugins/libjanus_nosip.so File listed twice: /usr/lib64/janus/plugins/libjanus_nosip.so.1 File listed twice: /usr/lib64/janus/plugins/libjanus_nosip.so.1.0.1 File
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #33 from Renich Bon Ciric --- Err, sorry; wrong link for the SRPM: Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-4.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #32 from Renich Bon Ciric --- So, "today" came a little late, heh. :`) Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-3.fc36.src.rpm Fixed what you asked in your comment from 2022-11-14. Trying to find some time to change the dependency of jquery to Fedora's and mark the others as bundled(); as Petr Menšík suggested here: https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/message/G4SR25UUCDF4EJCWUF5T5H4WENSUUO6B/ What do you think, Benson? In any case, sorry for the huge delays. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #31 from Renich Bon Ciric ---
(In reply to Benson Muite from comment #30)
> For pulling in the main package dependency, perhaps use:
> Requires: %{name}%{?_isa} = %{version}-%{release}
> instead of
> Requires: %{name} = %{version}
Understood. I will do that today.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #30 from Benson Muite ---
For pulling in the main package dependency, perhaps use:
Requires: %{name}%{?_isa} = %{version}-%{release}
instead of
Requires: %{name} = %{version}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #29 from Benson Muite --- Ok. Fedora-review has problems with metapackages, so perhaps do that last. It may be helpful to see the web assets guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #28 from Renich Bon Ciric --- OK, fixes applied. The directories are now owned. Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-3.fc36.src.rpm I'm still working on figuring out the docs. I will see if I can submit a package review soon. Thank you for your help and your patience. :D -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #27 from Renich Bon Ciric --- (In reply to Benson Muite from comment #25) > Should the spec file have a Requires section? Requires brings in dependent > packages needed when using Janus. At the moment, > only BuildRequires are listed. > > Perhaps consider only adding demo files that have minimal Javascript > dependencies, or Javascript dependencies that are already packaged? Hello, Benson. Well, the tools package has a requirement. Outside of it, janus, mostly, is standalone, AFAIK. I'll double-check, though. (In reply to Benson Muite from comment #26) > Typically .so files go in -devel packages and are softlinks to .so.* files, > this also is true for subpackages. In this case, remember that the .so files (the versioned ones) are plugins. Very similar to NginX's modules. These are packaged in their respective sub-packages. I am hoping to add a meta-package so that all plugins can be installed easily. > Issues when running fedora-review: > a) > Note: Directories without known owners: /usr/include/janus/events, > /usr/share/janus/javascript, /usr/lib64/janus/plugins, > /usr/lib64/janus/transports, /usr/lib64/janus/events, > /usr/lib64/janus/loggers, /usr/share/janus/duktape, > /usr/include/janus, /usr/share/janus, /usr/include/janus/loggers, > /usr/include/janus/plugins, /usr/include/janus/transports, > /usr/lib64/janus, /usr/share/janus/streams, > /usr/share/janus/recordings, /etc/janus, /usr/share/janus/lua Ah, the directories. I will add them. Thanks for htis. > ... > /builddir/janus-plugins-textroom-debuginfo-1.1.0-1.fc38.x86_64.rpm > ERROR: Command failed: > # /usr/bin/systemd-nspawn -q -M d79e9c67ebb847689873e491ada18b81 -D > /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a > --capability=cap_ipc_lock --bind=/tmp/mock-resolv.yfyj9_8u:/etc/resolv.conf > --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash > --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir > --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin > --setenv=PROMPT_COMMAND=printf "\033]0;\007" > --setenv=PS1= \s-\v\$ --setenv=LANG=C.UTF-8 > --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot > ... It's not clear to me which command failed here and what the error was. :s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #26 from Benson Muite --- Typically .so files go in -devel packages and are softlinks to .so.* files, this also is true for subpackages. Issues when running fedora-review: a) Note: Directories without known owners: /usr/include/janus/events, /usr/share/janus/javascript, /usr/lib64/janus/plugins, /usr/lib64/janus/transports, /usr/lib64/janus/events, /usr/lib64/janus/loggers, /usr/share/janus/duktape, /usr/include/janus, /usr/share/janus, /usr/include/janus/loggers, /usr/include/janus/plugins, /usr/include/janus/transports, /usr/lib64/janus, /usr/share/janus/streams, /usr/share/janus/recordings, /etc/janus, /usr/share/janus/lua b) INFO: installing package(s): /builddir/janus-plugins-audiobridge-1.1.0-1.fc38.x86_64.rpm /builddir/janus-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-http-1.1.0-1.fc38.x86_64.rpm /builddir/janus-tools-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-recordplay-1.1.0-1.fc38.x86_64.rpm /builddir/janus-loggers-json-1.1.0-1.fc38.x86_64.rpm /builddir/janus-tools-1.1.0-1.fc38.x86_64.rpm /builddir/janus-loggers-json-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-nanomsg-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-videocall-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-echotest-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-duktape-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-voicemail-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-voicemail-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-duktape-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-rabbitmq-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-videoroom-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-streaming-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-lua-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-textroom-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-mqtt-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-pfunix-1.1.0-1.fc38.x86_64.rpm /builddir/janus-devel-1.1.0-1.fc38.x86_64.rpm /builddir/janus-debugsource-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-echotest-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-websockets-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-rabbitmq-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-sip-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-http-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-gelf-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-gelf-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-mqtt-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-nosip-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-rabbitmq-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-nosip-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-recordplay-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-websockets-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-streaming-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-ws-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-nanomsg-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-rabbitmq-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-nanomsg-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-sample-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-nanomsg-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-videoroom-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-videocall-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-audiobridge-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-sample-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-pfunix-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-eventhandlers-ws-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-mqtt-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-sip-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-lua-debuginfo-1.1.0-1.fc38.x86_64.rpm /builddir/janus-transports-mqtt-1.1.0-1.fc38.x86_64.rpm /builddir/janus-1.1.0-1.fc38.x86_64.rpm /builddir/janus-plugins-textroom-debuginfo-1.1.0-1.fc38.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M d79e9c67ebb847689873e491ada18b81 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.yfyj9_8u:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;\007" --setenv=PS1= \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 38 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/janus-plugins-au
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #25 from Benson Muite --- Should the spec file have a Requires section? Requires brings in dependent packages needed when using Janus. At the moment, only BuildRequires are listed. Perhaps consider only adding demo files that have minimal Javascript dependencies, or Javascript dependencies that are already packaged? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #24 from Renich Bon Ciric --- OK, I just presented the case to Lorenzo (upstream) and he doesn't like the doxygen => man approach. He didn't even know it existed. ;D https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/tQgtsCIQEAAJ In any case, I asked him to take a look at it later on if he wanted. For now, I will have to focus on packaging the documentation and demos with Fedora-provided web resources. Lorenzo doesn't want to loose the demos either so this approach is the best one for now. In any case, I have the v1.1.0 version packaged. The shared objects (plugins) are versioned now (independently from the package). Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-1.fc36.src.rpm In the meantime, I will work on patching the doxygen docs as well as the demo files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #23 from Benson Muite --- That is awesome. If only other documentation generation tools could also generate man pages. Upstream seems responsive. Perhaps work with them to have the man pages also generated in the Makefile. Probably an option can be passed on what documentation files to generate. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #22 from Renich Bon Ciric --- OK, that was a minor success! :D I was able to generate the man pages. I can create a patch to either just build the man pages and move them manually, or just do it the right way, tell upstream about it provide a patch. sh-5.1# ls -l docs/man/man3/ total 2656 -rw-r--r--. 1 root root 79912 Oct 5 00:46 CHANGELOG.3 -rw-r--r--. 1 root root 36182 Oct 5 00:46 COPYING.3 -rw-r--r--. 1 root root 2509 Oct 5 00:46 CREDITS.3 -rw-r--r--. 1 root root 2473 Oct 5 00:46 DEPS.3 -rw-r--r--. 1 root root 30322 Oct 5 00:46 FAQ.3 -rw-r--r--. 1 root root 38377 Oct 5 00:46 JS.3 -rw-r--r--. 1 root root 23884 Oct 5 00:46 README.3 -rw-r--r--. 1 root root 3960 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_.3 -rw-r--r--. 1 root root 840 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_events_.3 -rw-r--r--. 1 root root 366 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_loggers_.3 -rw-r--r--. 1 root root 1888 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_plugins_.3 -rw-r--r--. 1 root root 2998 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_postprocessing_.3 -rw-r--r--. 1 root root 865 Oct 5 00:46 _builddir_build_BUILD_janus-gateway-1.0.4_src_transports_.3 -rw-r--r--. 1 root root 16594 Oct 5 00:46 admin.3 -rw-r--r--. 1 root root 754 Oct 5 00:46 apierror.c.3 -rw-r--r--. 1 root root 7392 Oct 5 00:46 apierror.h.3 -rw-r--r--. 1 root root 46311 Oct 5 00:46 audiobridge.3 -rw-r--r--. 1 root root 11938 Oct 5 00:46 auth.3 -rw-r--r--. 1 root root 8319 Oct 5 00:46 auth.c.3 -rw-r--r--. 1 root root 7863 Oct 5 00:46 auth.h.3 -rw-r--r--. 1 root root 13094 Oct 5 00:46 config.c.3 -rw-r--r--. 1 root root 15134 Oct 5 00:46 config.h.3 -rw-r--r--. 1 root root 3167 Oct 5 00:46 core.3 -rw-r--r--. 1 root root 4165 Oct 5 00:46 debug.3 -rw-r--r--. 1 root root 5242 Oct 5 00:46 debug.h.3 -rw-r--r--. 1 root root 9463 Oct 5 00:46 deploy.3 -rw-r--r--. 1 root root 1829 Oct 5 00:46 dtls-bio.c.3 -rw-r--r--. 1 root root 2351 Oct 5 00:46 dtls-bio.h.3 -rw-r--r--. 1 root root 10336 Oct 5 00:46 dtls.c.3 -rw-r--r--. 1 root root 11330 Oct 5 00:46 dtls.h.3 -rw-r--r--. 1 root root 10625 Oct 5 00:46 duktape.3 -rw-r--r--. 1 root root 4553 Oct 5 00:46 echotest.3 -rw-r--r--. 1 root root 15177 Oct 5 00:46 eventhandler.h.3 -rw-r--r--. 1 root root 717 Oct 5 00:46 eventhandlerapi.3 -rw-r--r--. 1 root root 1411 Oct 5 00:46 eventhandlers.3 -rw-r--r--. 1 root root 4384 Oct 5 00:46 events.c.3 -rw-r--r--. 1 root root 4179 Oct 5 00:46 events.h.3 -rw-r--r--. 1 root root 1096 Oct 5 00:46 extended_report_block.3 -rw-r--r--. 1 root root 47032 Oct 5 00:46 ice.c.3 -rw-r--r--. 1 root root 51392 Oct 5 00:46 ice.h.3 -rw-r--r--. 1 root root 2303 Oct 5 00:46 ide.3 -rw-r--r--. 1 root root 16350 Oct 5 00:46 ip-utils.c.3 -rw-r--r--. 1 root root 19863 Oct 5 00:46 ip-utils.h.3 -rw-r--r--. 1 root root 2405 Oct 5 00:46 janus-cfgconv.c.3 -rw-r--r--. 1 root root 9142 Oct 5 00:46 janus-pp-rec.c.3 -rw-r--r--. 1 root root 22019 Oct 5 00:46 janus.c.3 -rw-r--r--. 1 root root 21746 Oct 5 00:46 janus.h.3 -rw-r--r--. 1 root root 11148 Oct 5 00:46 janus_audiobridge.c.3 -rw-r--r--. 1 root root 764 Oct 5 00:46 janus_audiobridge_message.3 -rw-r--r--. 1 root root 5625 Oct 5 00:46 janus_audiobridge_participant.3 -rw-r--r--. 1 root root 1635 Oct 5 00:46 janus_audiobridge_plainrtp_media.3 -rw-r--r--. 1 root root 4458 Oct 5 00:46 janus_audiobridge_room.3 -rw-r--r--. 1 root root 1842 Oct 5 00:46 janus_audiobridge_rtp_forwarder.3 -rw-r--r--. 1 root root 983 Oct 5 00:46 janus_audiobridge_rtp_relay_packet.3 -rw-r--r--. 1 root root 1283 Oct 5 00:46 janus_audiobridge_session.3 -rw-r--r--. 1 root root 1723 Oct 5 00:46 janus_av1_svc_context.3 -rw-r--r--. 1 root root 1123 Oct 5 00:46 janus_av1_svc_template.3 -rw-r--r--. 1 root root 9279 Oct 5 00:46 janus_callbacks.3 -rw-r--r--. 1 root root 970 Oct 5 00:46 janus_config.3 -rw-r--r--. 1 root root 1356 Oct 5 00:46 janus_config_container.3 -rw-r--r--. 1 root root 4243 Oct 5 00:46 janus_dtls_srtp.3 -rw-r--r--. 1 root root 9008 Oct 5 00:46 janus_duktape.c.3 -rw-r--r--. 1 root root 906 Oct 5 00:46 janus_duktape_async_event.3 -rw-r--r--. 1 root root 746 Oct 5 00:46 janus_duktape_callback.3 -rw-r--r--. 1 root root 3364 Oct 5 00:46 janus_duktape_data.h.3 -rw-r--r--. 1 root root 2005 Oct 5 00:46 janus_duktape_extra.c.3 -rw-r--r--. 1 root root 1963 Oct 5 00:46 janus_duktape_extra.h.3 -rw-r--r--. 1 root root 1290 Oct 5 00:46 janus_duktape_rtp_relay_packet.3 -rw-r--r--. 1 root root 4281 Oct 5 00:46 janus_duktape_session.3 -rw-r--r--. 1 root root 7039 Oct 5 00:46 janus_echotest.c.3 -rw-r--r--. 1 root root 746 Oct 5 00:46 janus_echotest_message.3 -rw-r--r--. 1 root root 3353 Oct 5 00:46 janus_echotest_session.3 -rw-r--r--. 1 root root 6207 Oct 5 00:46 janus_eventhandler.3 -rw-r--r--. 1 root root 5573 Oct 5 00:46 janu
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #21 from Renich Bon Ciric --- (In reply to Benson Muite from comment #20) > Thanks for this useful package which will make video conferencing easier. > Some of these are packaged. See for example: > https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/ Yeah, I took a look at this. The thing is that the jquery version required by the sites is way lower. This is why I don't know if it would be worthwhile to package. > bootswatch, bootstrap are the other javascript libraries needed for the > documentation. I am not reluctant to package those. But, maybe, I can do it iteratively. First, release a version without those (for now) and, eventually, add those sub-packages as I package the dependencies. I mean, the demo and doc websites live online. They would be useful for offline setups. I think we can live without them for now. > Doxygen also seems like it can generate man pages, > https://www.doxygen.nl/manual/starting.html#man_out Would this work here? This is a good idea. I'll try it out definitely. At least provide the man pages. > The examples have many more javascript dependencies that would need to be > packaged. Maybe these can be left out for now, or some exemption sought. In the case of the demos subpackage, those js files are kind of specific to the demo itself. I don't think they're wirth packaging. Their only value is when used in the demo sites; which resides online as well: https://janus.conf.meetecho.com/demos.html We don't loose much if we don't package those. We gain the ability to host them offline (for ourselves) if we include them. Let me try out the doxygen to man thing and I'll get back to you. Let me know what you think in the meantime. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #20 from Benson Muite --- Thanks for this useful package which will make video conferencing easier. Some of these are packaged. See for example: https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/ bootswatch, bootstrap are the other javascript libraries needed for the documentation. Doxygen also seems like it can generate man pages, https://www.doxygen.nl/manual/starting.html#man_out Would this work here? The examples have many more javascript dependencies that would need to be packaged. Maybe these can be left out for now, or some exemption sought. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #19 from Renich Bon Ciric --- OK, about the web assets and javascript... the amout of work in order to get the demos and docs sub-packages overwhelmed me for now. I am thinking of removing those in order to push that part of the RPM a bit so I can get some guidance from someone that has done this and maintained this for a while. I dunno if this applies to the docs subpackage; since it's a doxygen generated documentation website. It's supposed to be useful only internally or offline, if you ask me. In any case, I think I will be removing those two sub-packages for now, unless you advise differently. This will leave us only with the plugin/module versioning dilemma. What do you think? For now, here's the SRPM and spec file without doc and demos: Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.0.4-7.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #18 from Renich Bon Ciric --- Hello Benson, (In reply to Benson Muite from comment #15) > Doc package should have > BuildArch: noarch I will add the doc arch immediately. > Libraries need versioning, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries Yeah, well, in this case they're modules/plugins. Very similar to what nginx uses: https://src.fedoraproject.org/rpms/nginx/blob/f34/f/nginx.spec#_556 That said, upstream has agreed to version those. https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/QuL6uwDlAgAJ the only issue is that they're gonna add a three digit version: n.n.n. :S Any suggestions in this regard? (In reply to Benson Muite from comment #17) > The html documentation has javascript and webassets: > https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ > https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/ I will read on and fix this as well. Thank you! :D -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #17 from Benson Muite --- The html documentation has javascript and webassets: https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #15 from Benson Muite --- Doc package should have BuildArch: noarch Libraries need versioning, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #14 from Renich Bon Ciric --- (In reply to Benson Muite from comment #13) > Renamed since this is used when creating the repository. Thanks for > re-packaging and your engagement with upstream. Happy to do my part. Thank you as well. :D -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121585] Review Request: janus - An open source general purpose WebRTC server.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585 Benson Muite changed: What|Removed |Added Summary|Review Request: |Review Request: janus - An |janus-gateway - An open |open source general purpose |source general purpose |WebRTC server. |WebRTC server. | --- Comment #13 from Benson Muite --- Renamed since this is used when creating the repository. Thanks for re-packaging and your engagement with upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
