[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 Petr Salaba changed: What|Removed |Added Fixed In Version||perl-Alien-Brotli-0.2.2-3.f ||c38 Resolution|--- |RAWHIDE Status|ASSIGNED|CLOSED Last Closed||2023-02-06 17:23:39 --- Comment #16 from Petr Salaba --- Thank you for the review and repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #15 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Brotli -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 Michal Josef Spacek changed: What|Removed |Added Flags||fedora-review+ --- Comment #14 from Michal Josef Spacek --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok > rpm -qp --requires perl-Alien-Brotli-0.2.2-3.fc38.x86_64.rpm | sort | uniq > -c | grep -v rpmlib 1 brotli = 1.0.9 1 libbrotli = 1.0.9 1 perl(Alien::Base) 1 perl(Alien::Brotli) 1 perl(base) 1 perl(constant) 1 perl-libs 1 perl(namespace::autoclean) 1 perl(Path::Tiny) 1 perl(strict) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) > rpm -qp --provides perl-Alien-Brotli-0.2.2-3.fc38.x86_64.rpm | sort | uniq -c 1 perl(Alien::Brotli::Install::Files) 1 perl-Alien-Brotli(x86-64) = 0.2.2-3.fc38 1 perl(Alien::Brotli) = 0.2.2 1 perl-Alien-Brotli = 0.2.2-3.fc38 Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #12 from Jakub Kadlčík --- Created attachment 1940180 --> https://bugzilla.redhat.com/attachment.cgi?id=1940180&action=edit The .spec file difference from Copr build 5250868 to 5287425 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #13 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5287425 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161558-perl-Alien-Brotli/fedora-rawhide-x86_64/05287425-perl-Alien-Brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558
Petr Salaba changed:
What|Removed |Added
Flags|needinfo?(psal...@redhat.co |
|m) |
--- Comment #11 from Petr Salaba ---
(In reply to Michal Josef Spacek from comment #10)
> @psal...@redhat.com
>
> 1) License is bad:
> In LICENSE file:
> The MIT (X11) License
> In spec file:
> License:GPL-1.0-or-later OR Artistic-1.0-Perl
Fixed, changed license to MIT.
> 2) No .rpmlintrc with warnings:
> perl-Alien-Brotli-tests.noarch: W: no-documentation
Created a .rpmlintrc with this warning filtered
> 3) BuildRequires: findutils, make, bc
> I don't see usage of this packages.
> As i understand, make, bc is used in case of compiling, but not in our case
Removed findutils and bc from requirements, make is still required in the rpm
build process.
> 4) spec file rpmlint:
> perl-Alien-Brotli.spec:52: W: comparison-operator-in-deptoken 2>/dev/null)
> perl-Alien-Brotli.spec:53: W: comparison-operator-in-deptoken 2>/dev/null)
>
> There is brotli %(perl -e 'print qq{ = $1} if qx{brotli --version} =~
> m{([\d+\.]+)}' 2>/dev/null)
> Why we need this 2>/dev/null ?
> If we need, then we need to add to .rpmlintrc
This stderr redirection was not needed, if an error happens it should be
visible in the build process stderr stream.
Removed 2>/dev/null.
Spec URL:
https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli.spec
SRPM URL:
https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli-0.2.2-3.fc38.src.rpm
Requested .rpmlintrc URL:
https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli.rpmlintrc
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161558
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558
Michal Josef Spacek changed:
What|Removed |Added
Flags||needinfo?(psal...@redhat.co
||m)
--- Comment #10 from Michal Josef Spacek ---
@psal...@redhat.com
1) License is bad:
In LICENSE file:
The MIT (X11) License
In spec file:
License:GPL-1.0-or-later OR Artistic-1.0-Perl
2) No .rpmlintrc with warnings:
perl-Alien-Brotli-tests.noarch: W: no-documentation
3) BuildRequires: findutils, make, bc
I don't see usage of this packages.
As i understand, make, bc is used in case of compiling, but not in our case
4) spec file rpmlint:
perl-Alien-Brotli.spec:52: W: comparison-operator-in-deptoken 2>/dev/null)
perl-Alien-Brotli.spec:53: W: comparison-operator-in-deptoken 2>/dev/null)
There is brotli %(perl -e 'print qq{ = $1} if qx{brotli --version} =~
m{([\d+\.]+)}' 2>/dev/null)
Why we need this 2>/dev/null ?
If we need, then we need to add to .rpmlintrc
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161558
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #9 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5250868 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161558-perl-Alien-Brotli/fedora-rawhide-x86_64/05250868-perl-Alien-Brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #8 from Jakub Kadlčík --- Created attachment 1939097 --> https://bugzilla.redhat.com/attachment.cgi?id=1939097&action=edit The .spec file difference from Copr build 5239720 to 5250868 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #7 from Petr Salaba --- For update review in COPR: Spec URL: https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli.spec SRPM URL: https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli-0.2.2-2.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #6 from Michal Josef Spacek --- [copr-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 Michal Josef Spacek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mspa...@redhat.com CC||mspa...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #5 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5239720 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161558-perl-Alien-Brotli/fedora-rawhide-x86_64/05239720-perl-Alien-Brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #4 from Jakub Kadlčík --- Created attachment 1938571 --> https://bugzilla.redhat.com/attachment.cgi?id=1938571&action=edit The .spec file difference from Copr build 5239684 to 5239720 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #3 from Petr Salaba --- Updated files: Spec URL: https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli.spec SRPM URL: https://psalaba.fedorapeople.org/perl-Alien-Brotli/perl-Alien-Brotli-0.2.2-2.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161558] Review Request: perl-Alien-Brotli - Find and install the Brotli compressor
https://bugzilla.redhat.com/show_bug.cgi?id=2161558 --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5239684 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161558-perl-Alien-Brotli/fedora-rawhide-x86_64/05239684-perl-Alien-Brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161558 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
