[Bug 2165946] Review Request: qt6-qtwebview - WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #9 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtwebview -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview - WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 Jan Grulich changed: What|Removed |Added Summary|Review Request: |Review Request: |qt6-qtwebview- WebView |qt6-qtwebview - WebView |component |component -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946
Neal Gompa changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGNED|POST
--- Comment #8 from Neal Gompa ---
> %{_qt6_libdir}/libQt6WebView.so.6*
> %{_qt6_libdir}/libQt6WebViewQuick.so.6*
The soname glob isn't quite right, it should be "6{,.*}".
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
But this can be fixed on import.
Everything else is good, so...
PACKAGE APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2165946
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #7 from Jan Grulich --- >[!]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/lib64/cmake/Qt6Qml/QmlPlugins This should be fixed in qt6-qtdeclarative. > [!]: Package does not own files or directories owned by other packages. Fixed. > qt6-qtwebview.x86_64: E: description-line-too-long Qt WebView provides a way > to display web content in a QML application without necessarily Fixed. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview-6.4.2-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #6 from Jan Grulich --- (In reply to Neal Gompa from comment #5) > Also note that your BR: ninja-build isn't being used, since you're not > passing in "-GNinja" to cmake. From macros.qt6: >%_qt6_build_tool ninja > >%if "%_qt6_build_tool" == "ninja" \ >-GNinja \\\ >%else \ >-G"Unix Makefiles" \\\ >%endif \ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #5 from Neal Gompa --- Also note that your BR: ninja-build isn't being used, since you're not passing in "-GNinja" to cmake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 Neal Gompa changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946
--- Comment #4 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* BSD 3-Clause License",
"GNU Free Documentation License v1.3", "GNU General Public License,
Version 2", "GNU Lesser General Public License, Version 3", "*No
copyright* [generated file]", "BSD 3-Clause License", "GNU Library
General Public License v2 or later". 156 files have unknown license.
Detailed output of licensecheck in
/home/ngompa/2165946-qt6-qtwebview/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/lib64/cmake/Qt6Qml/QmlPlugins
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/lib64/qt6/examples(qt6-qtserialbus-examples, qt6-qtnetworkauth-
examples, qt6-qtwebengine-examples, qt6-qtsensors-examples,
qt6-qtscxml-examples, qt6-qtserialport-examples, qt6-qt3d-examples,
qt6-qtcharts-examples, qt6-qtbase-examples, qt6-qtvirtualkeyboard-
examples, qt6-qtpositioning-examples, qt6-qtwebsockets-examples,
qt6-qtconnectivity-examples, qt6-qtmultimedia-examples,
qt6-qtdeclarative-examples, qt6-qtdatavis3d-examples, qt6-qttools-
examples, qt6-qtsvg-examples, qt6-qtquick3d-examples,
qt6-qtwebchannel-examples, qt6-qtremoteobjects-examples)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #3 from Jan Grulich --- Fixed. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview-6.4.2-1.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 --- Comment #2 from Neal Gompa --- This package doesn't build. The build log indicates there is a missing dependency: -- Could NOT find XKB (missing: XKB_LIBRARY XKB_INCLUDE_DIR) (Required is at least version "0.5.0") -- Found WrapVulkanHeaders: /usr/include -- Configuring done CMake Error at /usr/lib64/cmake/Qt6Gui/Qt6GuiTargets.cmake:98 (set_target_properties): The link interface of target "Qt6::GuiPrivate" contains: XKB::XKB but the target was not found. Possible reasons include: * There is a typo in the target name. * A find_package call is missing for an IMPORTED target. * An ALIAS target is missing. Call Stack (most recent call first): /usr/lib64/cmake/Qt6Gui/Qt6GuiConfig.cmake:62 (include) /usr/lib64/cmake/Qt6/Qt6Config.cmake:167 (find_package) CMakeLists.txt:12 (find_package) -- Generating done -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 Neal Gompa changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ngomp...@gmail.com CC||ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165946] Review Request: qt6-qtwebview- WebView component
https://bugzilla.redhat.com/show_bug.cgi?id=2165946 Jan Grulich changed: What|Removed |Added Blocks||1917559 (qt6-reviews) Alias||qt6-qtwebview Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1917559 [Bug 1917559] Qt6-related package review tracker -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165946 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
