[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 Neal Gompa changed: What|Removed |Added Blocks||2167167 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2167167 [Bug 2167167] Review Request: budgie-desktop-defaults - Budgie Desktop Defaults for Fedora -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 Joshua Strobl changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2023-02-05 11:04:24 --- Comment #6 from Joshua Strobl --- Closing as this should now be in rawhide / testing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 --- Comment #5 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-backgrounds -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #4 from Neal Gompa --- The only real issue I see is that the spec text alignment in the preamble (the stuff before "%prep") is inconsistent. I'd like to see that cleaned up when you import. Otherwise though, this looks good to me! PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007
--- Comment #3 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Creative Commons CC0
1.0". 29 files have unknown license. Detailed output of licensecheck
in /home/ngompa/2166007-budgie-backgrounds/licensecheck.txt
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/backgrounds/budgie(budgie-desktop), /usr/share/gnome-
background-properties(desktop-backgrounds-basic, f31-backgrounds-
gnome, f33-backgrounds-gnome, gears-backgrounds, f30-backgrounds-
gnome, f32-backgrounds-gnome, fedora-workstation-backgrounds,
f34-backgrounds-gnome, f35-backgrounds-gnome, neon-backgrounds,
f29-backgrounds-gnome, solar-backgrounds, fedorainfinity-backgrounds,
f36-backgrounds-gnome, f28-backgrounds-gnome, f37-backgrounds-gnome)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source2: https://serebit.com/openpgp/git-at-
serebit-dot-com.asc
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 Neal Gompa changed: What|Removed |Added Flags||fedora-review? CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED --- Comment #2 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166007] Review Request: budgie-backgrounds - Default backgrounds for Budgie Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2166007 --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5377494 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2166007-budgie-backgrounds/fedora-rawhide-x86_64/05377494-budgie-backgrounds/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166007 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
