[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2023-03-08 06:35:05 --- Comment #20 from Fedora Update System --- FEDORA-2023-923ad1c218 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #19 from Fedora Update System --- FEDORA-2023-923ad1c218 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-923ad1c218 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #18 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/mepack -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #17 from Iñaki Ucar --- Thanks! Yes, I offered to package this libcscutils independently in the past, but they told me that they make an adhoc use of this, different projects may bundle slightly different versions for testing purposes, and they do not release it separately. So given that this is only for development purposes and won't end up in any user system, I agree with them that it makes little sense to waste downstream time in this. I also asked about the Octave interface, and it is not yet available as an Octave package, so that is why I don't build it. I'll look into it if this changes and improves. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 Benson Muite changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #16 from Benson Muite --- Package is approved. Though it could be made easier to use. Octave interface may be a useful addition for some users. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #15 from Benson Muite --- cscutils is used in several of their other projects: https://gitlab.mpi-magdeburg.mpg.de/mess/cmess-releases/-/tree/master/libcscutils https://gitlab.mpi-magdeburg.mpg.de/software/flexiblas-release/-/tree/master/libcscutils Maybe it should be packaged separately? Almost all examples use matrices stored in hdf5 format. The code does run, but have not checked correctness. Instructions for using it from Fortran without CMake would be helpful, for example gfortran mepack_example.f90 -I /usr/lib64/gfortran/modules/mepack/ -L /usr/lib64/ -lmepack -llapack -lblas The main reference: M. Köhler. 2021. Approximate Solution of Non-Symmetric Generalized Eigenvalue Problems and Linear Matrix Equation on HPC Platforms. Dissertation. Logos Verlag Berlin, Magdeburg, Germany. does not seem to be available for download, though one of the cited references Gardiner et al. is available: https://doi.org/10.1145/146847.146930 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #14 from Iñaki Ucar --- (In reply to Benson Muite from comment #13) > Can the files doc/naming.md and doc/tuning.md be packaged? These are part of the documentation, so they are included now as man pages. > The source also includes a library of additional helper routines, > libcscutils. Given that these are used in the examples, maybe it > is helpful to also package them. Some modifications are needed > to obtain shared libraries, in particular a static library > liblua.a is created, even if one sets CMake to create shared > libraries. Checking what is needed to change this. This is a helper library they use for many projects and should not be packaged according to the maintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #13 from Benson Muite --- Can the files doc/naming.md and doc/tuning.md be packaged? The source also includes a library of additional helper routines, libcscutils. Given that these are used in the examples, maybe it is helpful to also package them. Some modifications are needed to obtain shared libraries, in particular a static library liblua.a is created, even if one sets CMake to create shared libraries. Checking what is needed to change this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #12 from Iñaki Ucar --- Nice, thanks. Any other issues here? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #11 from Benson Muite --- Co-ownership of directories is possible, though here seems not needed: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package Made a pull request: https://src.fedoraproject.org/rpms/gcc/pull-request/39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
Jakub Kadlčík changed:
What|Removed |Added
URL||https://www.mpi-magdeburg.m
||pg.de/projects/%{name}
--- Comment #10 from Jakub Kadlčík ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5566266
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2166884-mepack/fedora-rawhide-x86_64/05566266-mepack/fedora-review/review.txt
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #9 from Jakub Kadlčík --- Created attachment 1946365 --> https://bugzilla.redhat.com/attachment.cgi?id=1946365=edit The .spec file difference from Copr build 5430987 to 5566266 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #8 from Iñaki Ucar --- Spec URL: https://iucar.fedorapeople.org/pkgs/mepack.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/mepack-1.0.3-1.fc37.src.rpm I didn't know it was so easy to build man pages, thanks. Updated above, with docs. Build: https://copr.fedorainfracloud.org/coprs/iucar/mepack/build/5566175/ About a), gfortran owns %_fmoddir, and that expands to /usr/lib64/gfortran/modules, so nobody owns /usr/lib64/gfortran. It should be owned by gfortran too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
--- Comment #7 from Benson Muite ---
a) Trying to understand why. Checking other Fortran packages.
b) Ok on not adding kernel-tools-lib-devel
c) Man pages are helpful, may not always be online when using the package.
Before doing the build could add:
sed -i `s/GENERATE_HTML = YES/GENERATE_HTML = NO/g'
doc/Doxyfile.in
sed -i `s/GENERATE_MAN = NO/GENERATE_MAN = YES/g'
doc/Doxyfile.in
Then in the CMake configure section add
-DDOC=ON
After the build, within the build directory there will be
doc/man/man3
This will need to be installed manually, so add
install doc/man/man3 %{_mandir}/man3
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
--- Comment #6 from Iñaki Ucar ---
(In reply to Benson Muite from comment #5)
> a) One further issue raised is:
> No known owner of /usr/lib64/gfortran
>
> Maybe should use:
> Requires: gcc-gfortran%{_isa}
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/
> #_packaging_of_fortran_programs
I already do that (line 44 of the SPEC), so I don't understand this warning. I
believe it's a false positive.
> b) Perhaps add kernel-tools-libs-devel as a build requirement to provide
> libcpupower.so and cpufreq.h
I asked the upstream maintainer about this and other libraries not found. He
told me that it's fine, they are not needed, they are just for some advanced
upstream testing.
> c) Can the documentation be build and packaged? It uses doxygen which can
> generate manpages if the
> doxyfile is modified slightly to turn off html documentation and turn on man
> page generation. This
> will add doxygen as a build requirement.
The same, I asked the upstream maintainer about the docs, because doxygen HTML
docs are a nightmare when it comes to the additional licenses that are included
as a result of the build. He told me to ignore the docs, and that he prefers to
just maintain an online version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
--- Comment #5 from Benson Muite ---
a) One further issue raised is:
No known owner of /usr/lib64/gfortran
Maybe should use:
Requires: gcc-gfortran%{_isa}
https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/#_packaging_of_fortran_programs
b) Perhaps add kernel-tools-libs-devel as a build requirement to provide
libcpupower.so and cpufreq.h
c) Can the documentation be build and packaged? It uses doxygen which can
generate manpages if the
doxyfile is modified slightly to turn off html documentation and turn on man
page generation. This
will add doxygen as a build requirement.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #4 from Iñaki Ucar --- Just a kind reminder. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #3 from Iñaki Ucar --- Thanks for the review. About the comments, a) There is no guideline about this, and different packages do different things. In my opinion, given that packages mepack and mepack64 won't be normally pulled manually (because it's a library, there's no executable or anything in there), I think it's better in this case to keep things simple and have a single -devel package with everything. b) Thanks for checking this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
--- Comment #2 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU General Public
License, Version 3", "GNU General Public License v3.0 or later", "GNU
Lesser General Public License v2.1 or later", "MIT License", "BSD
2-Clause License", "GNU General Public License v2.0 or later", "BSD
3-Clause License", "GNU Affero General Public License v3.0 or later".
811 files have unknown license. Detailed output of licensecheck in
/home/FedoraPackaging/reviews/mepack/review-mepack/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/gfortran
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} =
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5430987 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2166884-mepack/fedora-rawhide-x86_64/05430987-mepack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 Benson Muite changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|benson_mu...@emailplus.org CC||benson_mu...@emailplus.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
