[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Benson Muite changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2023-02-24 13:04:31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #12 from Benson Muite --- Thanks for the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #11 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinxygen -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Maxwell G changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Maxwell G changed: What|Removed |Added Flags|fedora-review? | Status|NEW |POST Assignee|nob...@fedoraproject.org|maxw...@gtmx.me --- Comment #10 from Maxwell G --- sed is part of the buildroot, so you don't really need to manually require it. Also, I'd add a comment saying that the license is handled by %pyproject_savefiles. Anyways: - License expression is valid and matches the sources. - License file is included and marked with %license (handled by %pyproject_save_files.) - License is allowed for Fedora. - Package complies with the new Python Packaging Guidelines and the general Packaging Guidelines - No relevant rpmlint errors - No bundled content - Package builds in mock - Unit tests are run in %check Package approved. Thanks to lichaoran for preforming the initial review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #9 from Maxwell G --- [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #8 from Benson Muite --- Thanks for the feedback. Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/python-sphinxgen/fedora-rawhide-x86_64/05543346-python-sphinxygen/python-sphinxygen.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-sphinxgen/fedora-rawhide-x86_64/05543346-python-sphinxygen/python-sphinxygen-1.0.0-1.fc39.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #7 from Maxwell G --- > python3-sphinxygen.noarch: E: non-executable-script > /usr/lib/python3.11/site-packages/sphinxygen/sphinxygen.py 644 /usr/bin/env > python3 You should both remove the executable bit and remove the shebang, it seems. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546
Maxwell G changed:
What|Removed |Added
CC||maxw...@gtmx.me
--- Comment #6 from Maxwell G ---
Thanks, lichaoran, for preforming an informal review and completing the
template. Here are some comments of my own:
> %global srcname sphinxygen
This macro is unnecessary and makes the specfile harder to read IMO. I'd use
the
literal values, but that's up to you.
> %global forgeurlhttps://gitlab.com/drobilla/sphinxygen
> Version:1.0.0
> %global tag %{version}
> %forgemeta
I'd avoid the forge macros outside of Go and Fonts packaging.
They aren't really maintained anymore.
> Name: python-%{srcname}
Optionally, remove %{srcname} here.
> URL:%forgeurl
> # Source from Pypi does not include all test files
> Source0:%{forgeurl}-/archive/v%{version}/%{srcname}-v%{version}.tar.gz
Optionally, remove %forgeurl here.
Also, you can replace Source0 with Source.
Manually numbering sources is no longer required.
> BuildRequires: gzip
No need to manually BuildRequire this.
> BuildRequires: python3dist(setuptools)
This is generated by %pyproject_buildrequires. You should remove it.
> %package -n python3-%{srcname}
Optionally, remove %{srcname}.
> Summary:%{summary}
> %{?python_provide:%python_provide python3-%{srcname}}
%python_provide is deprecated and unnecessary.
Let the generators handle this.
> %prep
> %autosetup -n %{srcname}-v%{version}
Optionally, remove %{srcname}.
> %build
> %pyproject_wheel
> #compress man page
> gzip doc/%{srcname}.1
Don't compress the manpage manually.
>
> mkdir -p %{buildroot}%{_mandir}/man1
> install doc/%{srcname}.1.gz %{buildroot}%{_mandir}/man1/
You should preserve mtimes by using `-p`. You could use:
install -Dpm 0644 doc/sphinxygen.1 -t %{builroot}%{_mandir}/man1/
> %files -n python3-%{srcname} -f %{pyproject_files}
> %doc README.md NEWS
> %{_bindir}/%{srcname}
Optionally, remove %{srcname}.
> %{_mandir}/man1/%{srcname}.1.gz
Replace this with
%{_mandir}/man1/%{srcname}.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2168546
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Benson Muite changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #5 from Benson Muite --- Thanks for taking the review. The licensing is ok, files with 0BSD are not packaged and do not end up in the binary RPM: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field Will update the file permissions. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546
--- Comment #4 from lichaoran ---
Some comments:
- python3-sphinxygen.noarch: W: spurious-executable-perm
/usr/share/man/man1/sphinxygen.1.gz
- source0 cannot be downloaded, maybe it should be Source0:
%{forgeurl}/-/archive/v%{version}/%{srcname}-v%{version}.tar.gz
--
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 0-Clause License", "Unknown or generated", "ISC License
BSD 0-Clause License", "ISC License". 6 files have unknown license.
Detailed output of licensecheck in /root/python-
sphinxygen/result/python-sphinxygen/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[?]: Package contains desktop file if it is a GUI application.
[?]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[?]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
[71/1940]
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://gitlab.com/drobilla/sphinxygen-/archive/v1.0.0/sphinxygen-v1.0.0.tar.gz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 --- Comment #3 from lichaoran --- > I think the license Sorry for may mistaken type :- > # All files under ISC, though some tests and > # unpackaged files are under 0BSD > License:ISC I think the license should also contain 0BSD as the licensecheck says: BSD 0-Clause License sphinxygen-v1.0.0/.clang-format sphinxygen-v1.0.0/LICENSES/0BSD.txt sphinxygen-v1.0.0/test/c/Doxyfile sphinxygen-v1.0.0/test/c/conf.py ISC License --- sphinxygen-v1.0.0/doc/sphinxygen.1 sphinxygen-v1.0.0/src/sphinxygen/sphinxygen.py sphinxygen-v1.0.0/test/c/include/testlib.h sphinxygen-v1.0.0/test/c/index.rst sphinxygen-v1.0.0/test/test_sphinxygen.py ISC License BSD 0-Clause License sphinxygen-v1.0.0/.reuse/dep5 sphinxygen-v1.0.0/meson.build sphinxygen-v1.0.0/pyproject.toml Unknown or generated sphinxygen-v1.0.0/.pylintrc sphinxygen-v1.0.0/CONTRIBUTING.md sphinxygen-v1.0.0/LICENSE sphinxygen-v1.0.0/MANIFEST.in sphinxygen-v1.0.0/NEWS sphinxygen-v1.0.0/README.md so maybe update the License field to mention both, like this: License:ISC AND 0BSD -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 lichaoran changed: What|Removed |Added Flags||fedora-review? --- Comment #2 from lichaoran --- > # All files under ISC, though some tests and > # unpackaged files are under 0BSD > License:ISC I think the license -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 lichaoran changed: What|Removed |Added CC||jkadl...@redhat.com, ||pkwarcr...@gmail.com --- Comment #1 from lichaoran --- Hi Benson, I'd like to take this ticket as my first review package, @Jaku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168546] ReviewRequest: python-sphinxygen - A script to read Doxygen XML output and emit ReST for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=2168546 Benson Muite changed: What|Removed |Added Blocks||2167178 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2167178 [Bug 2167178] Review Request: zix - A lightweight C99 portability and data structure library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168546 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
