[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 Steve Cossette changed: What|Removed |Added Resolution|--- |NEXTRELEASE Status|POST|CLOSED Last Closed||2023-05-21 18:12:14 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #22 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/arianna -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 Benson Muite changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(benson_muite@emai | |lplus.org) | Status|ASSIGNED|POST --- Comment #21 from Benson Muite --- Thanks. Approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #20 from Steve Cossette --- *Removed an "echo" line, sorry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #19 from Steve Cossette --- Re-updated with a "echo" line I added as a test in the spec... that doesn'T belong there anymore. [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 Steve Cossette changed: What|Removed |Added Flags||needinfo?(benson_muite@emai ||lplus.org) --- Comment #18 from Steve Cossette --- Done, I've done all the changes you asked for and some additional ones: - Removed the tests patch (Don't need a tests patch if we aren't running any tests, right?) - I also added a dependancy for cmale(KF5QuickCharts) after looking at recent commits in the project (Specifically this one: https://invent.kde.org/graphics/arianna/-/commit/d3c23509c7d17191b4af1ad9f6b870fa3e944ff3) Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
Benson Muite changed:
What|Removed |Added
Flags|needinfo?(benson_muite@emai |
|lplus.org) |
--- Comment #17 from Benson Muite ---
The basic tests work when using kde-src build to create the executable, but
it seems something more is needed when building within Fedora. Can probably
remove %ctest as it does not do anything. Seems very few KDE apps run tests.
Following
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
can you move the %check section after install and also use appstream-util
validate-relax:
%check
desktop-file-validate
%{buildroot}/%{_datadir}/applications/org.kde.arianna.desktop
appstream-util validate-relax --nonet
%{buildroot}%{_kf5_metainfodir}/org.kde.arianna.appdata.xml
Will need to add
BuildRequires: libappstream-glib
It built on aarch64:
https://copr.fedorainfracloud.org/coprs/fed500/arianna/build/5939566/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 Steve Cossette changed: What|Removed |Added Flags||needinfo?(benson_muite@emai ||lplus.org) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #16 from Steve Cossette --- (In reply to Benson Muite from comment #15) > Thanks for the update. Checking on the tests. Error from Fedora review: > > arianna.src: E: description-line-too-long An ebook reader and library > management app supporting ".epub" files. Arianna discovers your books > automatically, and sorts them by categories, genres and authors. > > For the description probably something like > > An ebook reader and library management app > > is sufficient? Agreed, updated spec/srpm with the shorter description. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #15 from Benson Muite --- Thanks for the update. Checking on the tests. Error from Fedora review: arianna.src: E: description-line-too-long An ebook reader and library management app supporting ".epub" files. Arianna discovers your books automatically, and sorts them by categories, genres and authors. For the description probably something like An ebook reader and library management app is sufficient? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #14 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5890559 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05890559-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #13 from Steve Cossette --- I have done the changes for qt5-webengine as you suggested. As far as the tests. I created a patch to uncomment them, but looking at mockbuild's output, I still don'T think tests are running for some reason... maybe something somewhere isn't wired in correctly to do tests? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #12 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5890527 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05890527-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #11 from Steve Cossette --- Spec URL: https://api.nicehomeservices.com/images/temp/arianna.spec SRPM URL: https://api.nicehomeservices.com/images/temp/arianna-1.0.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #10 from Steve Cossette --- [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #9 from Benson Muite --- a) Build failures due to missing Qt5Webengine https://copr.fedorainfracloud.org/coprs/fed500/arianna/build/5881414/ May want to add a line similar to: https://src.fedoraproject.org/rpms/qt5-qtwebengine/blob/rawhide/f/qt5-qtwebengine.spec#_128 b) Tests do not seem to run, commented out: https://invent.kde.org/graphics/arianna/-/blob/0bbb654231945704c0b288a2a3caf8f6d5b24a3b/src/autotests/CMakeLists.txt Should these be uncommented? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #7 from Fedora Review Service --- Created attachment 1962504 --> https://bugzilla.redhat.com/attachment.cgi?id=1962504&action=edit The .spec file difference from Copr build 5842133 to 5879608 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #8 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5879608 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05879608-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #6 from Benson Muite --- Spec URL: https://api.nicehomeservices.com/images/temp/arianna.spec SRPM URL: https://api.nicehomeservices.com/images/temp/arianna-1.0.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #4 from Steve Cossette --- Re-updated. Forgot %cmake_kf5, as this is a KDE app. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 --- Comment #3 from Steve Cossette --- Thanks for that! I have done all the required changes, and updated the src.rpm and spec. Let me know! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
--- Comment #2 from Benson Muite ---
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Creative Commons CC0
1.0", "*No copyright* BSD 2-Clause License", "*No copyright* GNU
General Public License, Version 3", "Creative Commons CC0 1.0 Creative
Commons Attribution-ShareAlike 4.0", "*No copyright* BSD 3-Clause
License", "Creative Commons Attribution-ShareAlike 4.0", "GNU General
Public License, Version 2", "GNU General Public License, Version 3",
"GNU Library General Public License, Version 2.0", "GNU Lesser General
Public License, Version 2.1", "GNU Lesser General Public License,
Version 3", "*No copyright* GNU Lesser General Public License, Version
3", "*No copyright* MIT License", "*No copyright* GNU Lesser General
Public License, Version 2.1", "*No copyright* GNU Library General
Public License, Version 2.0", "*No copyright* GNU General Public
License, Version 2". 30 files have unknown license. Detailed output of
licensecheck in
/home/FedoraPackaging/reviews/arianne/2188970-arianna/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/scalable/apps,
/usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970 Benson Muite changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|benson_mu...@emailplus.org CC||benson_mu...@emailplus.org Flags||fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2188970 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2188970] Review Request: arianna - EPub Reader for mobile devices
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
Fedora Review Service changed:
What|Removed |Added
URL||https://invent.kde.org/grap
||hics/%{name}
--- Comment #1 from Fedora Review Service
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5842133
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05842133-arianna/fedora-review/review.txt
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2188970
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
