[Bug 2222811] Review Request: apache-commons-jexl - Java Expression Language

2023-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=811

Jerry James  changed:

   What|Removed |Added

 Resolution|--- |NEXTRELEASE
   Fixed In Version||apache-commons-jexl-3.3-1.f
   ||c39
 Status|POST|CLOSED
Last Closed||2023-07-18 15:16:07



--- Comment #4 from Jerry James  ---
Version 3.3 has been built in Rawhide.  And, sure enough, I messed up the
changelog.  I have pushed another commit that should fix it.  It will go into
effect when the mass rebuild builds this package.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20811%23c4
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2222811] Review Request: apache-commons-jexl - Java Expression Language

2023-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=811

Jerry James  changed:

   What|Removed |Added

 Blocks||2223473





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2223473
[Bug 2223473] Review Request: apache-commons-configuration - Read configuration
data from a variety of sources
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=811
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2222811] Review Request: apache-commons-jexl - Java Expression Language

2023-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=811



--- Comment #3 from Jerry James  ---
Thank you for the review.  I somehow failed to realize this package had been in
Fedora before, so thanks for pointing that out too.  I'll try your suggestion
for preserving the changelog.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20811%23c3
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2222811] Review Request: apache-commons-jexl - Java Expression Language

2023-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=811

Fabio Valentini  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||decatho...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com



--- Comment #2 from Fabio Valentini  ---
fedora-review is broken in rawhide, so here's a manual review:

- package name matches other Apache commons-* projects
- latest version is packaged
- Summary / description are fine and correctly line-wrapped
- source archive contains only source files and no objectionable content
- source archive contains only files under Apache-2.0 license
- License matches upstream specification, license text included
- signature of source file verified with gpg
- Patch to replace one build dependency with another one documented and
justified
- BuildRequires look sane (though I could not verify them, xmvn-builddep seems
to be broken again)
- docs are built and included in a separate package
- removal of unnecessary maven plugins is fine and justified
- build uses standard mvn_build / mvn_install macros
- unit tests are run and are all successful
- included %files look sane
- looks good to me

Package APPROVED.

===

You can continue the unretirement process with releng.

Note that if you want to preserve pre-retirement changelog, you'll probably
need to be careful when converting to rpmautospec (I think running "rpmautospec
convert" immediately after the unretirement commit and then commiting your new
version on top of that should work).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=811

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20811%23c2
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2222811] Review Request: apache-commons-jexl - Java Expression Language

2023-07-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=811

Fedora Review Service  changed:

   What|Removed |Added

URL||https://commons.apache.org/
   ||proper/commons-jexl/



--- Comment #1 from Fedora Review Service  
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6170463
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-811-apache-commons-jexl/fedora-rawhide-x86_64/06170463-apache-commons-jexl/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20811%23c1
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue