[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 Ryan changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2023-11-06 09:47:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #25 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/qoi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c25 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #24 from Fedora Review Service --- Hello @errornointernet, since this is your first Fedora package, you need to get sponsored by a package sponsor before it can be accepted. A sponsor is an experienced package maintainer who will guide you through the processes that you will follow and the tools that you will use as a future maintainer. A sponsor will also be there to answer your questions related to packaging. You can find all active sponsors here: https://docs.pagure.org/fedora-sponsors/ I created a sponsorship request for you: https://pagure.io/packager-sponsors/issue/600 Please take a look and make sure the information is correct. Thank you, and best of luck on your packaging journey. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c24 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844
Artur Frenszek-Iwicki changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #23 from Artur Frenszek-Iwicki ---
Package is APPROVED. One thing you should change is to include the git commit
hash in the version information, like this:
> %global commit_short %(c="%{commit}"; echo "${c:0:7}")
> Version: 0^%{snapdate}.%{commit_short}
Or alternatively:
> %global commit_short %(c="%{commit}"; echo "${c:0:7}")
> Version: 0^%{snapdate}git%{commit_short}
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 11643 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #22 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6593848 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06593848-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c22 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #21 from Ryan --- Here you go .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06593843-qoi/qoi.spec .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06593843-qoi/qoi-0%5E20230911-2.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c21 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #20 from Artur Frenszek-Iwicki --- Hi Ryan, can you resubmit the COPR build, or post the spec & srpm somewhere else? Looks like the latest files got garbage-collected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c20 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #19 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6528072 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06528072-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c19 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #18 from Fedora Review Service --- Created attachment 1994089 --> https://bugzilla.redhat.com/attachment.cgi?id=1994089&action=edit The .spec file difference from Copr build 6512602 to 6528072 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c18 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #17 from Ryan --- Done, New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06525914-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06525914-qoi/qoi-0%5E20230911-2.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c17 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844
--- Comment #16 from Artur Frenszek-Iwicki ---
Looks good overall, just one minor issue:
You must add "Provides: qoi-static = %{version}-%{release}" to the -devel
package.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries
Please update the changelog as well and then we'll be golden.
Alternatively, consider switching to %autochangelog.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=844
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c16
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #15 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6512602 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06512602-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c15 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #14 from Fedora Review Service --- Created attachment 1993183 --> https://bugzilla.redhat.com/attachment.cgi?id=1993183&action=edit The .spec file difference from Copr build 6358052 to 6512602 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c14 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #13 from Ryan --- Fixed :) (also updated version) New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06512557-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06512557-qoi/qoi-0%5E20230911-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c13 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844
--- Comment #12 from Artur Frenszek-Iwicki ---
Hi Ryan, sorry for making you wait so long for a reply.
> %global commit 41e8f84bf68f7bb658430a37b5647c172d86e38e
> %global snapdate 20230828
>
> Version: %{snapdate}git%(c='%{commit}'; echo "${c:0:7}")
This will produce a package with version "20230828git...".
The recommended way is to use caret-versioning instead: "0^%{snapdate}..."
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstream_has_never_chosen_a_version
> %files
>
> %files tools
> ...
>
> %files devel
> ...
A setup like this will result in the build process producing an empty "qoi"
package that contains no files.
Remove the "%files" line - this will make it so the build produces only
qoi-devel and qoi-tools.
You can then drop "Requires: %{name}%{?isa} = %{version}-%{release}" from the
subpackages.
> %files tools
> %license LICENSE
> ...
> %files devel
>
> %changelog
Since -devel is independent from -tools, and it is possible to install only one
of those packages,
both of them should include a copy of the licence text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=844
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c12
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 Petr Menšík changed: What|Removed |Added Blocks||2209858 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2209858 [Bug 2209858] Review Request: timg - A terminal image and video viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #10 from Fedora Review Service --- Created attachment 1986237 --> https://bugzilla.redhat.com/attachment.cgi?id=1986237&action=edit The .spec file difference from Copr build 6172039 to 6358052 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c10 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #11 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6358052 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06358052-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c11 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #9 from Ryan --- Changes: - Bumped version - Moved binaries to -tools package - Moved LDFLAGS/CFLAGS to the end of the command New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06358041-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06358041-qoi/qoi-20230828git41e8f84-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 Artur Frenszek-Iwicki changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@svgames.pl --- Comment #8 from Artur Frenszek-Iwicki --- Overall the package looks good, just two suggestions from my side: Usually with library packages, the main package contains the dynamic libraries, and -devel the header files. Any extra tools can either go into the main package, or into a -tools subpackage. Since qoi is (currently?) a header-only library, I think it could be a good idea to move the tools into a -tools subpackage, and omit building the main package. This would enable you to make the devel package noarch and save users from having to install unneeded dependencies. In Makefile-ldflags.patch, you put LDFLAGS next to CFLAGS. It's usually best to place these at the end of the compiler invocation. Sorry for the long wait. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844
--- Comment #7 from Ryan ---
Thanks for your reply :)
> This does not include Fedora's LDFLAGS. You'll need to either modify the
> Makefile to include those in the gcc invocation, or call the compiler
> manually.
I have now added a patch (Makefile-ldflags.patch) for the Makefile to include
LDFLAGS.
Changes:
- Used `install -d` and `install -p` instead of `cp`
- Added `Requires: %{name}%{?isa} = %{version}-%{release}` to the -devel
package
- Added LDFLAGS patch
New .spec URL:
https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06176114-qoi/qoi.spec
New .srpm URL:
https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06176114-qoi/qoi-20230615git36190eb-3.fc39.src.rpm
Makefile-ldflags.patch:
https://github.com/ErrorNoInternet/rpm-specs/raw/main/qoi/Makefile-ldflags.patch
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=844
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c7
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844
Artur Frenszek-Iwicki changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
CC||fed...@svgames.pl
--- Comment #6 from Artur Frenszek-Iwicki ---
> %install
> mkdir -p %{buildroot}/%{_includedir}
> cp qoi.h %{buildroot}/%{_includedir}
1. You should aim to preserve file timestamps. You can use "cp -a" or "cp
--preserve=timestamps".
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
2. Using "cp" is fine, but I think that most .spec files use "install" instead.
"install -d" can also be used to create directories.
> %files devel
> %license LICENSE
> %doc README.md
The -devel package has a hard "Requires:" on the base package,
so these files can be omitted.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing
Also, looking at the copr build made by the review service:
> gcc -std=c99 -O3 -O2 -flto=auto -ffat-lto-objects -fexceptions -g
> -grecord-gcc-switches -pipe -Wall -Werror=format-security
> -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
> -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer qoiconv.c -o qoiconv
This does not include Fedora's LDFLAGS. You'll need to either modify the
Makefile to include those in the gcc invocation, or call the compiler manually.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=844
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c6
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #5 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6172039 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06172039-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #4 from Fedora Review Service --- Created attachment 1975737 --> https://bugzilla.redhat.com/attachment.cgi?id=1975737&action=edit The .spec file difference from Copr build 6171803 to 6172039 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #3 from Ryan --- *** Bug 846 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 --- Comment #2 from Ryan --- Updated .spec file to also include the -devel package. New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06172030-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06172030-qoi/qoi-20230615git36190eb-2.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2222844] Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression
https://bugzilla.redhat.com/show_bug.cgi?id=844 Fedora Review Service changed: What|Removed |Added URL||https://github.com/phobosla ||b/qoi --- Comment #1 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6171803 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-844-qoi/fedora-rawhide-x86_64/06171803-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20844%23c1 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
