[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2023-11-10 18:42:34 --- Comment #10 from Fedora Update System --- FEDORA-2023-3539704568 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c10 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2023-3539704568 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3539704568 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 --- Comment #8 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pycomposefile -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Ben Beasley changed: What|Removed |Added Flags||needinfo?(mhay...@redhat.co ||m) --- Comment #7 from Ben Beasley --- Don’t forget to import this! ;-) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c7 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Ben Beasley changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | --- Comment #6 from Ben Beasley --- - The spec file diff looks reasonable. - The spec file diff incorporates all feedback. - No new findings appear in the fedora-review template or the rpmlint output. The package is therefore APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432
--- Comment #5 from Ben Beasley ---
--- srpm-unpacked/python-pycomposefile.spec 2023-09-28 20:00:00.0
-0400
+++ python-pycomposefile.spec 2023-10-26 11:24:46.293124109 -0400
@@ -9,11 +9,15 @@
License:MIT
URL:https://github.com/smurawski/pycomposefile
-Source: %{pypi_source %{srcname}}
+Source: %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz
# Added a PR to make a license file in the repository.
# https://github.com/smurawski/pycomposefile/pull/27
-Source1:
https://patch-diff.githubusercontent.com/raw/smurawski/pycomposefile/pull/27.patch
+Patch: %{url}/pull/27.patch
+
+# Remove src from test import
+# https://github.com/smurawski/pycomposefile/pull/30
+Patch: %{url}/pull/30.patch
BuildArch: noarch
BuildRequires: python3-devel
@@ -36,18 +40,25 @@
%prep
%autosetup -p1 -n %{srcname}-%{version}
-cp %{SOURCE1} .
%generate_buildrequires
+# Work around an upstream bug with the version number.
+# https://github.com/smurawski/pycomposefile/issues/29
+export BUILD_TAG='%{version}'
+cd src/
%pyproject_buildrequires
%build
+export BUILD_TAG='%{version}'
+cd src/
%pyproject_wheel
%install
+export BUILD_TAG='%{version}'
+cd src/
%pyproject_install
# Remove the installed tests.
@@ -57,26 +68,17 @@
%check
-%pyproject_check_import -e tests.service.test_service_environment
+%pyproject_check_import
%if %{with tests}
-
-# Some test files refer to ./src instead of ./pycomposefile.
-sed 's/src.pycomposefile/pycomposefile/' -i tests/**/*.py
-
-%pytest -k "\
-not test_service_with_list_environment_file \
-and not test_service_with_resolved_environment_variables \
-and not test_service_with_single_environment_file \
-and not test_service_with_long_syntax \
-and not test_service_with_single_secret"
-
+%pytest
%endif
%files -n python3-%{srcname} -f %{pyproject_files}
%doc README.md
+%license LICENSE
%changelog
-%autochangelog
\ No newline at end of file
+%autochangelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2241432
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c5
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Ben Beasley changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Ben Beasley changed: What|Removed |Added Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #4 from Ben Beasley --- Thanks! I’ll revisit this sometime after the weekend. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Fedora Review Service changed: What|Removed |Added URL||https://github.com/smurawsk ||i/pycomposefile --- Comment #3 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6500106 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2241432-python-pycomposefile/fedora-rawhide-x86_64/06500106-python-pycomposefile/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Major Hayden 🤠 changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) --- Comment #2 from Major Hayden 🤠 --- Thanks Ben! Spec URL: https://mhayden.fedorapeople.org/python-pycomposefile.spec SRPM URL: https://mhayden.fedorapeople.org/python-pycomposefile-0.0.30-1.fc40.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432
--- Comment #1 from Ben Beasley ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- The version in the metadata is wrong:
$ rpm -q --provides -p
results/python3-pycomposefile-0.0.30-1.fc40.noarch.rpm
python-pycomposefile = 0.0.30-1.fc40
python3-pycomposefile = 0.0.30-1.fc40
python3.12-pycomposefile = 0.0.30-1.fc40
python3.12dist(pycomposefile) = 0.0.1~a1
python3dist(pycomposefile) = 0.0.1~a1
You can fix this by overriding it with
export BUILD_TAG='%{version}'
preferably (for consistency) in all of %generate_buildrequires, %build, and
%install.
You can reference:
Incorrect version number in setup.py
https://github.com/smurawski/pycomposefile/issues/29
- If you switch to the GitHub archive, something like
Source: %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz
then you can run the tests that you are currently skipping. See:
Source tarball on PyPi is missing sample directory
https://github.com/smurawski/pycomposefile/issues/28
Now you can remove all of the test skips. But you will have to add
cd src/
before %pyproject_buildrequires, %pyproject_wheel, and %pyproject_install.
- In %prep, this is unnecessary, and looks like it was left over from before
you opened a PR for the license file:
cp %{SOURCE1} .
- Regarding
# Some test files refer to ./src instead of ./pycomposefile.
sed 's/src.pycomposefile/pycomposefile/' -i tests/**/*.py
I proposed the change upstream in
https://github.com/smurawski/pycomposefile/pull/30
Consider
Patch: %{url}/pull/30.patch
instead of sed.
- The SRPM and spec file are not quite synchronized.
= Notes =
- Adding the LICENSE file in a patch might normally be dubious, but I think it
is OK because the PR was approved and merged upstream, and adding it is the
right thing to do.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
License file is added in a PR, but the PR was approved and merged
upstream, so this seems OK.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "*No copyright* MIT License", "Unknown or
generated". 46 files have unknown license. Detailed output of
licensecheck in /home/ben/Downloads/review/2241432-python-
pycomposefile/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match t
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Ben Beasley changed: What|Removed |Added Status|NEW |ASSIGNED CC||c...@musicinmybrain.net Flags||fedora-review? Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241432 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files
https://bugzilla.redhat.com/show_bug.cgi?id=2241432 Major Hayden 🤠 changed: What|Removed |Added Blocks||2240840 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2240840 [Bug 2240840] azure-cli-2.53.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241432 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
