[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Jon Ciesla changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA Flag|fedora-review? |fedora-review+ --- Comment #16 from Jon Ciesla 2010-04-30 14:35:59 EDT --- Fantastic. APPROVED! Thank you so much! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225250
--- Comment #15 from Milos Jakubicek 2010-04-29 17:19:49
EDT ---
(In reply to comment #14)
> Ok, fresh review:
>
> [l...@paguroidea SPECS]$ rpmlint -i ../SRPMS/antlr-2.7.7-9.fc12.src.rpm
>
> The spelling errors are fine, but I'd like to see an explanation as to why the
> tarball was modified and what steps were taken. Ideally, the comments should
> contain exact instructions for deriving this tarball from upstream.
I found out that the only differences was that the antlr.jar file was removed
which is anyway assured by:
find . -name "*.jar" -exec rm -f {} \;
in %prep.
=> completely unnecessary, I removed that and uploaded the original tarball.
> [l...@paguroidea SPECS]$ rpmlint -i ../RPMS/*/antlr*
>
> antlr-javadoc.noarch: W: dangerous-command-in-%post rm
> antlr-javadoc.noarch: W: dangerous-command-in-%postun rm
Both %post and %postun have been removed (a relict from jpackage %ghosting of
javadoc).
> antlr-manual.noarch: E: world-writable
> /usr/share/doc/antlr-manual-2.7.7/Makefile 0666
> A file or directory in the package is installed with world writable
> permissions, which is most likely a security issue.
>
> antlr-manual.noarch: W: spurious-executable-perm
> /usr/share/doc/antlr-manual-2.7.7/Makefile.in
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable. Verify if the executable bits are
> desired, and remove if not.
Both Makefile and Makefile.in removed, it didn't make any sense for them to be
installed.
> antlr-manual.noarch: W: spurious-executable-perm
> /usr/share/doc/antlr-manual-2.7.7/csharp-runtime.html
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable. Verify if the executable bits are
> desired, and remove if not.
Fixed.
> antlr-tool.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/antlr-tool-2.7.7/LICENSE.txt
> This file has wrong end-of-line encoding, usually caused by creation or
> modification on a non-Unix system. It could prevent it from being displayed
> correctly in some circumstances.
Fixed.
> If there is any documentation that could be put in the C++ subpackage, please
> do so. What about the .hpp files? I assume there's a good reason they're not
> in a -devel package, but it should be commented on in the spec.
Yes, added. I also generated the doxygen documentation, but it's quite big so I
put it into a -C++-docs package.
I hope all the issues have been addressed, please check the current devel
branch, thank you!
Koji build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2146995
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 --- Comment #14 from Jon Ciesla 2010-04-29 10:21:57 EDT --- Ok, fresh review: [l...@paguroidea SPECS]$ rpmlint -i ../SRPMS/antlr-2.7.7-9.fc12.src.rpm antlr.src: W: spelling-error Summary(en_US) ANother -> Another, Anther, An other The value of this tag appears to be misspelled. Please double-check. antlr.src: W: spelling-error %description -l en_US recognizers -> recognizer, recognizes, recognize rs The value of this tag appears to be misspelled. Please double-check. antlr.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers The value of this tag appears to be misspelled. Please double-check. antlr.src: W: invalid-url Source0: antlr-2.7.7-RHCLEAN.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 0 errors, 4 warnings. The spelling errors are fine, but I'd like to see an explanation as to why the tarball was modified and what steps were taken. Ideally, the comments should contain exact instructions for deriving this tarball from upstream. [l...@paguroidea SPECS]$ rpmlint -i ../RPMS/*/antlr* antlr-C++.i686: W: spelling-error Summary(en_US) parsers -> parser, parses, parers The value of this tag appears to be misspelled. Please double-check. antlr-C++.i686: W: spelling-error %description -l en_US parsers -> parser, parses, parers The value of this tag appears to be misspelled. Please double-check. antlr-C++.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/ANTLRUtil.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/CharInputBuffer.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/NoViableAltException.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/CommonAST.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/CharScanner.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/IOException.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/CommonASTWithHiddenTokens.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/TokenStreamRetryException.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/TreeParserSharedInputState.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/CircularQueue.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/TokenBuffer.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/TokenStreamRecognitionException.hpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/LLkParser.hpp A development file (usually source code) is located in
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 --- Comment #13 from Milos Jakubicek 2010-04-29 09:53:36 EDT --- Jon, yesterday I did a major cleanup of the devel branch, most of the applicable points at the top of the bug should be resolved now -- could you maybe revisit now? Thank you in advance. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Jon Ciesla changed: What|Removed |Added CC||xja...@fi.muni.cz --- Comment #12 from Jon Ciesla 2010-04-29 09:26:53 EDT --- Adding new owner to CC. Please check current devel branch against the above concerns. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Caius 'kaio' Chance changed: What|Removed |Added CC||ccha...@redhat.com --- Comment #11 from Caius 'kaio' Chance 2010-04-28 21:22:29 EDT --- Sorry for my wrong bug info changing. And ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Jason Tibbitts changed: What|Removed |Added Summary|Package Review: antlr |Merge Review: antlr --- Comment #10 from Jason Tibbitts 2010-02-24 22:11:28 EST --- This is definitely a merge review and the summary should not have been changed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Caius 'kaio' Chance changed: What|Removed |Added CC|ccha...@redhat.com | --- Comment #8 from Caius 'kaio' Chance 2010-02-24 03:15:05 EST --- Could someone re-provide the srpm and spec file for package review? Please check out the latest package and review guidelines on FedoraProject wiki. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
