Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225877
--- Comment #1 from Ondrej Vasik 2010-03-09 10:19:17 EST ---
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- MUST: rpmlint must be run on every package. The output should be posted in
the review
[re...@localhost devel]$ rpmlint guile.spec guile*.rpm i386/guile-*.rpm
guile.src: W: spelling-error Summary(en_US) extensibility -> sensibility,
reprehensibility, comprehensibility
guile.src: W: spelling-error %description -l en_US GNU's -> G Nu's, Gnu's,
GNP's
guile.src: W: spelling-error %description -l en_US extensibility ->
sensibility, reprehensibility, comprehensibility
guile-devel.i386: W: spelling-error Summary(en_US) extensibility ->
sensibility, reprehensibility, comprehensibility
guile-devel.i386: W: spelling-error %description -l en_US extensibility ->
sensibility, reprehensibility, comprehensibility
guile-devel.i386: W: no-documentation
guile.i386: W: spelling-error Summary(en_US) extensibility -> sensibility,
reprehensibility, comprehensibility
guile.i386: W: spelling-error %description -l en_US GNU's -> G Nu's, Gnu's,
GNP's
guile.i386: W: spelling-error %description -l en_US extensibility ->
sensibility, reprehensibility, comprehensibility
guile.i386: W: devel-file-in-non-devel-package
/usr/lib/libguile-srfi-srfi-13-14-v-3.so
guile.i386: W: devel-file-in-non-devel-package
/usr/lib/libguile-srfi-srfi-60-v-2.so
guile.i386: W: devel-file-in-non-devel-package
/usr/lib/libguile-srfi-srfi-4-v-3.so
guile.i386: W: devel-file-in-non-devel-package
/usr/lib/libguilereadline-v-17.so
guile.i386: W: dangling-relative-symlink /usr/share/guile/1.8/slib ../../slib
guile.i386: W: devel-file-in-non-devel-package
/usr/lib/libguile-srfi-srfi-1-v-3.so
guile.i386: W: dangerous-command-in-%trigger rm
guile.i386: W: dangerous-command-in-%trigger rm
4 packages and 1 specfiles checked; 0 errors, 17 warnings.
[re...@localhost devel]$ rpmlint --version
rpmlint version 0.94 Copyright (C) 1999-2007 Frederic Lepied, Mandriva
Spelling errors are ok, .so files should go to devel, main package should
contain just the versioned libs.
Dangling symlink - /usr/share/guile/1.8/slib points to /usr/share/slib - which
is not owned by guile and doesn't exist if slib package doesn't exist. This
symlink is ghosted and triggers do create it, so it probably could be removed.
+ MUST: package named according to the Package Naming Guidelines
+ MUST: The spec file name must match the base package %{name}
+ MUST: The package must meet the Packaging Guidelines .
+ MUST: The package licensed with a Fedora approved license and meets the
Licensing Guidelines
+ MUST: The License field in the package spec file matches the actual
license
Info documentation is licensed under OFSFDL (see
https://fedoraproject.org/wiki/Licensing/OldFSFDocLicense ) , install-sh
scripts (. , ./build-aux/ ./guile-readline/install-sh) have BSD like license
(probably MIT).
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Included
+ MUST: The spec file must be written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task
$wget ftp://ftp.gnu.org/pub/gnu/guile/guile-1.8.7.tar.gz
--2010-03-09 16:07:33-- ftp://ftp.gnu.org/pub/gnu/guile/guile-1.8.7.tar.gz
=> „guile-1.8.7.tar.gz.1“
Překládám ftp.gnu.org… 140.186.70.20
Navazuje se spojení s ftp.gnu.org|140.186.70.20|:21… spojeno.
Probíhá přihlašování jako anonymous… Přihlášeno!
==> SYST ... hotovo. ==> PWD ... hotovo.
==> TYPE I ... hotovo.==> CWD (1) /pub/gnu/guile ... hotovo.
==> SIZE guile-1.8.7.tar.gz ... 4026804
==> PASV ... hotovo. ==> RETR guile-1.8.7.tar.gz ... hotovo.
Délka: 4026804 (3,8M) (není směrodatné)
100%[==>] 4 026 804350K/s za 13s
2010-03-09 16:07:48 (296 KB/s) – „guile-1.8.7.tar.gz.1“ uložen [4026804]
[re...@localhost devel]$ md5sum guile-1.8.7.tar.gz*
991b5b3efcbbc3f7507d05bc42f80a5e guile-1.8.7.tar.gz
991b5b3efcbbc3f7507d05bc42f80a5e guile-1.8.7.tar.gz.1
= MATCHES
+ MUST: The package successfully compiles and builds into binary rpms on at
least one primary architecture
- tested on i686, no problems
0 MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch
+ MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines
0 MUST: The spec file handles locales properly. This is done by using the
%find_lang macro
+ MUST: Every binary RPM package (or subpackage) which stores shared libra
