[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225969
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
CC||tcall...@redhat.com
Flag||fedora-review?
--- Comment #13 from Tom spot Callaway tcall...@redhat.com 2010-10-25
15:52:39 EDT ---
The kernel is a rather unique package for Fedora. It does a few unique things:
* It makes heavy use of macros, notably, to generate files sections and apply
patches.
* Its Release is dynamically generated.
* It has multiple architecture specific sections
* It has specific conflicts, all to prevent conflicts with older userspace
components.
* It uses the buildroot starting in %prep, in %build, and in %install.
Normally, this would be very bad form, but the complexity of the kernel
actually makes it simpler to permit this use. In any other package, this would
mandate reworking, so please, don't copy this behavior.
With that stated, here is the first part of a review (against rawhide
2.6.36-1.fc15):
== Part 1: rpmlint ==
kernel.src: W: name-repeated-in-summary C kernel
kernel.x86_64: W: name-repeated-in-summary C kernel
(Given that the Summary is The Linux kernel, I think this is safe to ignore)
kernel.src: W: spelling-error %description -l en_US vmlinuz - drumlin,
Kremlin, kremlin
kernel.x86_64: W: spelling-error %description -l en_US vmlinuz - drumlin,
Kremlin, kremlin
kernel-debuginfo-common-x86_64.x86_64: W: spelling-error %description -l en_US
subpackages - sub packages, sub-packages, prepackages
kernel-devel.x86_64: W: spelling-error %description -l en_US makefiles - make
files, make-files, makefast
kernel-headers.x86_64: W: spelling-error Summary(en_US) glibc - glib, glib c,
glitch
kernel-headers.x86_64: W: spelling-error %description -l en_US userspace -
user space, user-space, users pace
kernel-headers.x86_64: W: spelling-error %description -l en_US glibc - glib,
glib c, glitch
(False positives, safe to ignore)
kernel.src: W: strange-permission merge.pl 0755L
kernel.src: W: strange-permission find-provides 0755L
(Odd permissions, but not faulty. Safe to ignore.)
kernel.src:221: E: hardcoded-library-path in /usr/lib/debug
(This is the correct debuginfo path for all targets, safe to ignore.)
kernel.src:386: W: macro-in-comment %nobuildarches
kernel.src:432: W: macro-in-comment %post
kernel.src:1002: W: macro-in-comment %{vanillaversion}
kernel.src:1003: W: macro-in-comment %{kversion}
kernel.src:1005: W: macro-in-comment %{kversion}
kernel.src:1883: W: macro-in-comment %{image_install_path}
(Packagers should avoid using macros in comments, but this is a minor error.
The easy fix here is to %% comment out any macros in comments, to prevent
unexpected and random behavior.)
kernel.src:485: W: unversioned-explicit-obsoletes kernel-smp
(I'm not sure there is an appropriate version here. This one can probably die
off in a release or so anyways.)
kernel.src:757: W: unversioned-explicit-obsoletes glibc-kernheaders
kernel-headers.x86_64: W: self-obsoletion glibc-kernheaders obsoletes
glibc-kernheaders = 3.0-46
(To resolve these two items, adjust the spec to read: Obsoletes:
glibc-kernheaders 3.0-46)
kernel.src:940: E: use-of-RPM_SOURCE_DIR
(The kernel's custom patch macro needs to use RPM_SOURCE_DIR, and is exempt
from any restrictions here.)
kernel.src:944: W: deprecated-grep [u'egrep']
kernel.src:1379: W: deprecated-grep [u'egrep']
kernel.src:1576: W: deprecated-grep [u'fgrep']
kernel.src:1602: W: deprecated-grep [u'egrep']
(Should be changed to grep -E or grep -F, as egrep and fgrep are
deprecated.)
kernel.src:975: W: rpm-buildroot-usage %prep make
INSTALL_FW_PATH=$RPM_BUILD_ROOT/lib/firmware firmware_install \
kernel.src:1470: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT%{debuginfodir}/boot
kernel.src:1471: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT%{debuginfodir}/%{image_install_path}
kernel.src:1473: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT/%{image_install_path}
kernel.src:1474: W: rpm-buildroot-usage %build install -m 644 .config
$RPM_BUILD_ROOT/boot/config-$KernelVer
kernel.src:1475: W: rpm-buildroot-usage %build install -m 644 System.map
$RPM_BUILD_ROOT/boot/System.map-$KernelVer
kernel.src:1479: W: rpm-buildroot-usage %build dd if=/dev/zero
of=$RPM_BUILD_ROOT/boot/initramfs-$KernelVer.img bs=1M count=20
kernel.src:1482: W: rpm-buildroot-usage %build cp arch/$Arch/boot/zImage.stub
$RPM_BUILD_ROOT/%{image_install_path}/zImage.stub-$KernelVer || :
kernel.src:1485: W: rpm-buildroot-usage %build
$RPM_BUILD_ROOT/%{image_install_path}/$InstallName-$KernelVer
kernel.src:1486: W: rpm-buildroot-usage %build chmod 755
$RPM_BUILD_ROOT/%{image_install_path}/$InstallName-$KernelVer
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 --- Comment #12 from Rakesh Pandit rpan...@redhat.com 2010-07-09 02:40:43 EDT --- Ok, but closing with resolution to currentrelease and setting flag 'fedora-review' to + does not sync with your justification. No one reviewed it here at least. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Status|ASSIGNED|NEW Flag|fedora-review+ | --- Comment #7 from Robert Scheck red...@linuxnetz.de 2010-07-08 02:49:55 EDT --- Jeff, dumb Red Hat employee! You are not allowed to close this review before a reviewer has set fedora-review+ (and did a qualified package review according to our Fedora Packaging guidelines); clearing flag... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 --- Comment #8 from Rakesh Pandit rpan...@redhat.com 2010-07-08 03:21:00 EDT --- @Robert Refrain from using this language. It is not acceptable and does not help either. @Jeff Why would you set fedora-review `+` if no review has happened and close it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 --- Comment #9 from Jeff Garzik jgar...@redhat.com 2010-07-08 03:42:44 EDT --- The reasons were stated in comment #6. It is a profound waste of resources to open reviews for packages that have been merged for over a decade. This is even more clear when this bugzilla lays untouched for over three years. Fedora has hundreds of not-yet-merged packages that _really do_ need review. The kernel is not one of them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2010-07-08 04:34:36 EDT --- Jeff, I suppose when you say packages that have been merged for over a decade, you are knowing this already = https://fedoraproject.org/wiki/Merge_Reviews -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 --- Comment #11 from Jeff Garzik jgar...@redhat.com 2010-07-08 14:21:51 EDT --- Yes, existing packages can be reviewed. It is patently obvious from the activity on this bugzilla that nobody cares enough to do anything except let this entry sit around and clutter to list of packages to be reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 Jeff Garzik jgar...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED CC||jgar...@redhat.com Resolution||CURRENTRELEASE Flag||fedora-review+ --- Comment #4 from Jeff Garzik jgar...@redhat.com 2010-07-08 00:17:57 EDT --- this merge review BZ for kernel pkg is outdated and a bit pointless at this point :) closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225969] Merge Review: kernel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225969 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED CC||panem...@gmail.com Resolution|CURRENTRELEASE | --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2010-07-08 00:22:38 EDT --- So what is outdated here mean? Do you plan to open new bugzilla for kernel package review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
