[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #37 from Jon Ciesla 2012-01-26 13:48:52 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #36 from Jon Ciesla 2011-10-18 11:58:18 EDT --- I still see 2.x. Any ETA? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #35 from Jon Ciesla 2011-06-20 11:55:36 EDT --- Agreed, please post here when you get 3.x in rawhide, and I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226117
--- Comment #34 from Jan Kaluža 2011-06-20 02:34:57 EDT ---
Thank you for adding me into CC, I didn't know about this merge review (Maybe I
should start searching for my packages names from time to time).
If I understand this review well, it is about changing the directory structure
and whole packaging process to fit better Fedora guidelines, right?
As I've checked it so far, there's for example problem with
"/usr/lib/mailman/Mailman/mm_cfg.py". Config files really should not be in
/usr/lib. This is not easily fixable unless you start doing some magic like
importing python files from /etc/mailman/. (Bug 683763)
There is also problem with /etc/mailman/mm_cfg.py symlink, because if you run
"rpmbuild" locally, it will generate "/etc/mailman/mm_cfg.pyo" and
"/etc/mailman/mm_cfg.pyc". Current Mailman package workarounds it using
"%{configdir}/mm_cfg.*" in %files section, but those files should not be there.
Interesting thing is that those files are not generated when building using
Koji.
The solution for it is to byte-compile everything manually instead of
/etc/mailman/ directory or to finish this RFE http://rpm.org/ticket/837 .
> Considering the pace here it might be more efficient and realistic to work
> with
> upstream to ensure that 3.0 will be more suitable for packaging according to
> our guidelines.
I think this is better idea probably. Mailman 3 fixes lot of things and I think
they won't release alpha versions forever and if I consider this review request
is here for 4.5 years...
However, I will check the changes in .spec mentioned in this bug more closely
to see what exactly changed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #33 from Mads Kiilerich 2011-06-19 09:23:40 EDT --- Note that it seems like upstream might finish their 3.0 rewrite "Really Soon Now". It has a different architecture and will require completely different packaging. Considering the pace here it might be more efficient and realistic to work with upstream to ensure that 3.0 will be more suitable for packaging according to our guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 Nils Philippsen changed: What|Removed |Added CC||jkal...@redhat.com --- Comment #32 from Nils Philippsen 2011-06-17 12:02:54 EDT --- Adding the current maintainer to Cc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #31 from Jon Ciesla 2011-06-17 10:58:38 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #30 from Jon Ciesla 2011-03-31 12:40:36 EDT --- . .. which is resolevd. So where are we now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226117
--- Comment #29 from Daniel Novotny 2010-04-20 07:59:57
EDT ---
Nils, thanks for your comment and solution. I have made a bug for this:
https://bugzilla.redhat.com/show_bug.cgi?id=583966
(In reply to comment #28)
> Apparently the _libdir thing hasn't been reverted completely. Please apply the
> following where applicable (I found it being a problem on F-13, but it should
> be an issue from F-12 on when built on 64bit):
>
> - 8< -
> --- mailman.spec 25 Mar 2010 14:31:26 - 1.92
> +++ mailman.spec 19 Apr 2010 13:53:11 -
> @@ -263,7 +263,7 @@ cp -r %{mmbuilddir}/doc $RPM_BUILD_ROOT%
> mkdir -p $RPM_BUILD_ROOT%{_bindir}
> install -m755 %{SOURCE8} $RPM_BUILD_ROOT%{_bindir}
> # set library path in mailman-update-cfg script.
> -sed -i 's,@libdir@,%{_libdir},g' $RPM_BUILD_ROOT%{_bindir}/mailman-update-cfg
> +sed -i 's,@mmdir@,%{mmdir},g' $RPM_BUILD_ROOT%{_bindir}/mailman-update-cfg
>
> # remove dir/files from $RPM_BUILD_ROOT that we aren't shipping
> rm -rf $RPM_BUILD_ROOT%{varmmdir}/icons
> --- mailman-update-cfg 22 Jul 2009 11:30:13 - 1.2
> +++ mailman-update-cfg 19 Apr 2010 13:53:11 -
> @@ -10,4 +10,4 @@
>
> import py_compile
>
> -py_compile.compile("@libdir@/mailman/Mailman/mm_cfg.py")
> +py_compile.compile("@mmdir@/Mailman/mm_cfg.py")
> - >8 -
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226117
Nils Philippsen changed:
What|Removed |Added
CC||nphil...@redhat.com
--- Comment #28 from Nils Philippsen 2010-04-19 09:57:32
EDT ---
Apparently the _libdir thing hasn't been reverted completely. Please apply the
following where applicable (I found it being a problem on F-13, but it should
be an issue from F-12 on when built on 64bit):
- 8< -
--- mailman.spec 25 Mar 2010 14:31:26 - 1.92
+++ mailman.spec 19 Apr 2010 13:53:11 -
@@ -263,7 +263,7 @@ cp -r %{mmbuilddir}/doc $RPM_BUILD_ROOT%
mkdir -p $RPM_BUILD_ROOT%{_bindir}
install -m755 %{SOURCE8} $RPM_BUILD_ROOT%{_bindir}
# set library path in mailman-update-cfg script.
-sed -i 's,@libdir@,%{_libdir},g' $RPM_BUILD_ROOT%{_bindir}/mailman-update-cfg
+sed -i 's,@mmdir@,%{mmdir},g' $RPM_BUILD_ROOT%{_bindir}/mailman-update-cfg
# remove dir/files from $RPM_BUILD_ROOT that we aren't shipping
rm -rf $RPM_BUILD_ROOT%{varmmdir}/icons
--- mailman-update-cfg 22 Jul 2009 11:30:13 - 1.2
+++ mailman-update-cfg 19 Apr 2010 13:53:11 -
@@ -10,4 +10,4 @@
import py_compile
-py_compile.compile("@libdir@/mailman/Mailman/mm_cfg.py")
+py_compile.compile("@mmdir@/Mailman/mm_cfg.py")
- >8 -
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #25 from Daniel Novotny 2010-01-13 10:44:56 EST --- OK, new release: http://people.fedoraproject.org/~dnovotny/f/mailman.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=1918980 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #24 from Jon Ciesla 2010-01-13 09:39:12 EST --- (In reply to comment #23) > (In reply to comment #22) > > Ok, thanks, looks great. Any thoughts on #13 and #15? > IMHO Radek has a good point. The executable files in mailman's bin directory > are all python scripts, so it doesn't matter if they are in lib or lib64, they > are not binaries. The best solution I can think of is to revert this change > and > document in the spec why this is an exception to rpmlint "error" message. +1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226117] Merge Review: mailman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #23 from Daniel Novotny 2010-01-13 07:06:24 EST --- (In reply to comment #22) > Ok, thanks, looks great. Any thoughts on #13 and #15? IMHO Radek has a good point. The executable files in mailman's bin directory are all python scripts, so it doesn't matter if they are in lib or lib64, they are not binaries. The best solution I can think of is to revert this change and document in the spec why this is an exception to rpmlint "error" message. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
