[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-09-06 04:17:47 --- Comment #9 from Parag AN(पराग) panem...@gmail.com 2010-09-06 04:17:47 EDT --- Thanks! I see you have updated srpm in rawhide. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2010-08-09 01:07:03 EDT --- Looks good now. After you build this updated srpm in rawhide, I will approve this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #6 from Avesh Agarwal avaga...@redhat.com 2010-08-03 12:32:32 EDT --- I verified the patch as per fedora guidelines, and it seems fine. I have also added the explanation for the extra C flags, and changelog entry too. Right now I can not commit to F14 (seems frozen), otherwise will make a new build soon based on the patch. Thanks for the patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #7 from Avesh Agarwal avaga...@redhat.com 2010-08-03 12:37:53 EDT --- Updated srpm is here: http://people.redhat.com/avagarwa/files/pam_passwdqc/pam_passwdqc-1.0.5-7.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2010-08-02 11:07:51 EDT --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 Avesh Agarwal avaga...@redhat.com changed: What|Removed |Added CC||sgr...@redhat.com --- Comment #5 from Avesh Agarwal avaga...@redhat.com 2010-08-02 11:12:46 EDT --- I am looking into these. will get back to you soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-07-24 09:40:15 EDT --- 1) rpmlint reported pam_passwdqc.src: W: spelling-error Summary(en_US) Pluggable - Plug gable, Plug-gable, Plugged pam_passwdqc.src: W: spelling-error %description -l en_US pam - map, Pam, pan pam_passwdqc.src: W: spelling-error %description -l en_US passwdqc - password, passageway, passivised pam_passwdqc.src: W: spelling-error %description -l en_US passwd - passed pam_passwdqc.src: W: spelling-error %description -l en_US passphrases - pass phrases, pass-phrases, paraphrases pam_passwdqc.i686: W: spelling-error Summary(en_US) Pluggable - Plug gable, Plug-gable, Plugged pam_passwdqc.i686: W: spelling-error %description -l en_US pam - map, Pam, pan pam_passwdqc.i686: W: spelling-error %description -l en_US passwdqc - password, passageway, passivised pam_passwdqc.i686: W: spelling-error %description -l en_US passwd - passed pam_passwdqc.i686: W: spelling-error %description -l en_US passphrases - pass phrases, pass-phrases, paraphrases == This can be ignored. 2)timestamps should be preserved.Use INSTALL=install -p when installing to preserve timestamps. 3) I will suggest this pacakge to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install 4) Should follow https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2010-07-24 09:42:15 EDT --- Created an attachment (id=434142) -- (https://bugzilla.redhat.com/attachment.cgi?id=434142) pam_passwdqc-spec-cleanup.patch please add changelog entry when applying above patch in devel branch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226226] Merge Review: pam_passwdqc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226226 --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2010-07-24 10:26:21 EDT --- Also, As per https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags , please add comment in spec why you need extras flags. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
