[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2010-09-07 10:48:58 EDT --- ssorce ping otherwise I will commit the patch and close this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #6 from Simo Sorce sso...@redhat.com 2010-09-07 11:28:22 EDT --- Please proceed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-09-08 01:17:09 --- Comment #7 from Parag AN(पराग) panem...@gmail.com 2010-09-08 01:17:09 EDT --- Thanks. Built in pam_smb-1.1.7-12.fc15 closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2010-08-09 00:59:49 EDT --- ssorce ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2010-08-02 11:08:24 EDT --- ssorce ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com, ||sso...@redhat.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2010-07-24 10:36:41 EDT --- Created an attachment (id=434150) -- (https://bugzilla.redhat.com/attachment.cgi?id=434150) pam_smb-spec-cleanup.patch add changelog entry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226227] Merge Review: pam_smb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226227 --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-07-24 10:35:49 EDT --- 1) rpmlint reported pam_smb.src: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers. pam_smb.src: W: spelling-error %description -l en_US pam - map, Pam, pan pam_smb.src: W: spelling-error %description -l en_US smb - sob, sub, Sm pam_smb.i686: W: summary-ended-with-dot C A Pluggable Authentication Module (PAM) for use with SMB servers. pam_smb.i686: W: spelling-error %description -l en_US pam - map, Pam, pan pam_smb.i686: W: spelling-error %description -l en_US smb - sob, sub, Sm 2 packages and 0 specfiles checked; 0 errors, 6 warnings. == Fix needed for summary and rest can be ignored. 2)timestamps should be preserved.Use install -p when installing to preserve timestamps. 3) I will suggest this package to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install 4) Buildroot is wrong and not needed now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
