[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #25 from Harald Hoyer har...@redhat.com 2011-04-08 04:05:01 EDT --- (In reply to comment #24) Did you push the changes? oops .. done :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA Flag|fedora-review? |fedora-review+ Last Closed||2011-04-08 08:59:22 --- Comment #26 from Jon Ciesla l...@jcomserv.net 2011-04-08 08:59:22 EDT --- Ah, there we are. Thanks so much! APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #23 from Harald Hoyer har...@redhat.com 2011-04-06 04:53:47 EDT --- (In reply to comment #22) Ok, once the space/tab thing is fixed, I'm good. The rest is justified, I think, and the source URL was apparently a fluke, because it works for me now and the md5sum matches. already untabifyied in git master. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #24 from Jon Ciesla l...@jcomserv.net 2011-04-06 08:55:12 EDT --- Did you push the changes? udev.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. [limb@bamboo udev]$ git log commit 8df68695ff06d05f52b7187c24fa27969a5036c5 Merge: 0b0304c 58624e4 Author: Harald Hoyer har...@redhat.com Date: Thu Mar 31 18:32:08 2011 +0200 Merge branch 'f15/master' commit 58624e426ed9b5d2b26f4a428cdc5cb8e4e6d4bf Author: Harald Hoyer har...@redhat.com Date: Thu Mar 31 18:30:08 2011 +0200 udev.spec: removed gtk-doc commit cbf7ac132cb5c8c9c7169c763df6714c5ad45b17 Author: Harald Hoyer har...@redhat.com Date: Wed Mar 30 17:36:11 2011 +0200 removed libxslt buildreq and touch man pages, to prevent rebuild commit 8cf0c7defa5e033369d66ac319ed380c3fe73882 Author: Harald Hoyer har...@redhat.com Date: Thu Mar 31 17:58:51 2011 +0200 - fixed udev-trigger.service commit 0b0304cfe18782b99aaa0814f9610d7ec91fcc2b Author: Harald Hoyer har...@redhat.com Date: Thu Mar 31 17:58:51 2011 +0200 - fixed udev-trigger.service -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #22 from Jon Ciesla l...@jcomserv.net 2011-04-04 14:57:12 EDT --- Ok, once the space/tab thing is fixed, I'm good. The rest is justified, I think, and the source URL was apparently a fluke, because it works for me now and the md5sum matches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #21 from Harald Hoyer har...@redhat.com 2011-04-01 03:38:50 EDT
---
(In reply to comment #20)
Cool, thanks!
Starting over on current rawhide SRPM:
udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line
182)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
right.. will fix!
udev.src: W: invalid-url Source0:
ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 urlopen
error ftp error: [Errno 111] Connection refused
The value should be a valid, public HTTP, HTTPS, or FTP URL.
huh? loads fine!
$ wget ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2
--2011-04-01 09:39:27--
ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2
= `udev-167.tar.bz2.1'
Resolving ftp.kernel.org... 130.239.17.4, 199.6.1.164
Connecting to ftp.kernel.org|130.239.17.4|:21... connected.
Logging in as anonymous ... Logged in!
== SYST ... done.== PWD ... done.
== TYPE I ... done. == CWD (1) /pub/linux/utils/kernel/hotplug ... done.
== SIZE udev-167.tar.bz2 ... 594474
== PASV ... done.== RETR udev-167.tar.bz2 ... done.
Length: 594474 (581K) (unauthoritative)
These are the only things not addressed above.
These are new, and I'm imagining are ok:
udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
yes, that's needed
udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev
File is hard linked across directories. This can cause problems in
installations where the directories are located on different devices.
huh?
# Deprecated, but keep the ownership
%ghost %dir /var/lib/udev
%ghost %dir %{_sysconfdir}/udev/makedev.d/
udev.i686: W: no-manual-page-for-binary start_udev
Each executable in standard binary directories should have a man page.
that's ok, nobody should use it
Otherwise, it looks good.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #19 from Harald Hoyer har...@redhat.com 2011-03-31 12:52:15 EDT --- (In reply to comment #16) In attempting to take a look at this, I ran across: checking for USBUTILS... configure: error: Package requirements (usbutils = 0.82) were not met: Looks like the BuildRequires should be versioned. done... $ grep usbutils udev.spec BuildRequires: usbutils = 0.82 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #20 from Jon Ciesla l...@jcomserv.net 2011-03-31 13:20:21 EDT --- Cool, thanks! Starting over on current rawhide SRPM: udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. udev.src: W: invalid-url Source0: ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 urlopen error ftp error: [Errno 111] Connection refused The value should be a valid, public HTTP, HTTPS, or FTP URL. These are the only things not addressed above. These are new, and I'm imagining are ok: udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev File is hard linked across directories. This can cause problems in installations where the directories are located on different devices. udev.i686: W: no-manual-page-for-binary start_udev Each executable in standard binary directories should have a man page. Otherwise, it looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #18 from Jon Ciesla l...@jcomserv.net 2011-03-31 12:40:46 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #17 from Jon Ciesla l...@jcomserv.net 2010-04-29 16:10:50 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
