[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DUPLICATE Last Closed|2011-04-18 12:49:08 |2011-07-18 06:22:32 --- Comment #45 from Rahul Sundaram methe...@gmail.com 2011-07-18 06:22:32 EDT --- I have gotten a new review request opened since this is 722874a blocker for what I am working on and you seem to be busy. I would be happy to work with you and get you sponsored however when you have more time. Do drop me a mail when you are free. Thanks. *** This bug has been marked as a duplicate of bug 722874 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #46 from Oded Arbel o...@geek.co.il 2011-07-18 18:14:10 EDT --- Thanks. It was important to get this package into Fedora and as that was done, I have no complaints :-) I'd like to work on more Fedora packages but as you can tell I'm currently way too busy. I will drop you a note when I can do some more work, Thanks for being patient with me as much as you have been. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #44 from Rahul Sundaram methe...@gmail.com 2011-07-16 05:30:32 EDT --- Kindly update. I am waiting on this for my project (https://fedoraproject.org/wiki/Askbot) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #43 from Rahul Sundaram methe...@gmail.com 2011-07-13 04:09:57 EDT --- Do a scratch build via koji or a mock build locally. Run rpmlint on the spec file, srpm and binary rpm. In particular the changelog should be something along the lines of * Tue Jul 12 2011 Oded Arbel o...@geek.co.il - 0.90-2 Dist tag shouldn't be explicitly specified in the changelog. Meanwhile I have filed a request to sponsor you https://fedorahosted.org/fesco/ticket/643 I recommend you create a profile page in the Fedora wiki and drop a note in the ticket with your Fedora account system name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #36 from Rahul Sundaram methe...@gmail.com 2011-07-12 05:06:31 EDT --- I am going to give this 2 more days and close this review request and open my own to make forward progress in this since this happens to be a dependency for Askbot, which I am packaging. I would happy to assist in Oded Arbel getting sponsored when he is more free. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #39 from Oded Arbel o...@geek.co.il 2011-07-12 16:57:24 EDT --- For some reason I can't obsolete Ruben Kerkhof original spec. Please disregard it and review my updated spec, which is the later attachment. TIA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #37 from Oded Arbel o...@geek.co.il 2011-07-12 16:55:16 EDT --- I'm sorry for taking a long time on this. Its been a hectic couple of weeks but I'm here now. I'll try to respond quickly from now on. Rahul - I've reviewed your notes in comment #30, but it seems that almost none of them are relevant to the updated spec file (attachment #2). The only one that is relevant is the one about the comments, which I think are still useful but nonetheless at your request they have been removed, and the one about %defattr that I also removed. Run rpmlint on spec file, srpm and binary rpm and fix the warnings and errors as applicable. rpmlint complains that tokenizer is not spelled correctly. I'm not sure whether an official English dictionary recognizes the word tokenizer, but its what upstream uses to describe the project so I'm leaving it in. Everything else is clean. I would also suggest doing a scratch build under koji and posting a link here. Unfortunately I do not have access to a working Koji setup, and last time I tried to do that I gave up two days later due to it being too difficult and not enough time. SRPM: http://rpms.geek.co.il/fc15/SRPMS/python-html5lib-0.90-2.fc15.src.rpm RPM: http://rpms.geek.co.il/fc15/x86_64/python-html5lib-0.90-2.fc15.noarch.rpm The spec file will be attached to this ticket. Thank you and please let me know if there's anything else to change. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Oded Arbel o...@geek.co.il changed: What|Removed |Added Attachment #496915|0 |1 is obsolete|| --- Comment #38 from Oded Arbel o...@geek.co.il 2011-07-12 16:56:23 EDT --- Created attachment 512515 -- https://bugzilla.redhat.com/attachment.cgi?id=512515 Updated spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added AssignedTo|ru...@rubenkerkhof.com |methe...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Comment #40 from Rahul Sundaram methe...@gmail.com 2011-07-12 17:34:08
EDT ---
This is unusual
Provides: %{modulename} = %{version}
It bloats the metadata. Is it necessary? consider removing
in %install stage, rm -rf $RPM_BUILD_ROOT is redundant.
Add Build Requires on python-devel and RPM would pick up the requires
automatically. You can remove the explicit requires.
%files can be reduced to
%doc examples README
%{python_sitelib}/%{modulename}
Ideally, upstream should update README to explicitly mention the license and
you must contact upstream to ask them to include a copy of the license. Fix
these and I will get you approved
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Oded Arbel o...@geek.co.il changed: What|Removed |Added Attachment #512515|0 |1 is obsolete|| --- Comment #42 from Oded Arbel o...@geek.co.il 2011-07-12 18:22:23 EDT --- Created attachment 512535 -- https://bugzilla.redhat.com/attachment.cgi?id=512535 Updated spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Comment #41 from Oded Arbel o...@geek.co.il 2011-07-12 18:21:49 EDT ---
(In reply to comment #40)
This is unusual
Provides: %{modulename} = %{version}
It bloats the metadata. Is it necessary? consider removing
I think its useful because people may want to depend on html5lib instead of
python-html5lib, but I see that no one else is doing this - so I removed it.
in %install stage, rm -rf $RPM_BUILD_ROOT is redundant.
OK.
Add Build Requires on python-devel and RPM would pick up the requires
automatically. You can remove the explicit requires.
I don't agree - html5lib is a pure python implementation and does not require
python-devel to build or run, so there's no need to force the user to install
it. python-setuptools on the other hand is required for building the package
but requiring python-devel will not cause it to be installed.
As for the explicit run-time requirement on python, RPM indeed picks that up
automatically, so I removed this explicit requirement.
%files can be reduced to
%doc examples README
%{python_sitelib}/%{modulename}
I need to add %{python_sitelib}/%{modulename}-*.egg-info otherwise it complains
that these files are not installed but not packaged. I'm not an expert on
Python and I'm not sure what the egg-info files are, but I have a feeling they
are important. Regarding the other lines, I'm pretty sure I had a good reason
to do it but I can't figure it out now so I cleaned it up.
Ideally, upstream should update README to explicitly mention the license and
you must contact upstream to ask them to include a copy of the license.
I've asked on the project's Google group a couple of times to include a license
file, but with very little response. I've now opened an issue on that in their
issue tracker (http://code.google.com/p/html5lib/issues/detail?id=188) but I
doubt it will get any better response. If this is requirement is a must and the
package cannot get into Fedora without fulfilling it, then we will just have to
wait. If upstream doesn't get back on that issue within a week or so, I'll open
up a personal email campaign ;-)
Updated RPM files are in the links above, updated SPEC file will be attached
shortly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #35 from Rahul Sundaram methe...@gmail.com 2011-07-09 04:43:57 EDT --- Any update? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #34 from Rahul Sundaram methe...@gmail.com 2011-06-30 02:32:55 EDT --- Ping again. I would like to move forward here since this package is a dependency for something I am working on. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #32 from Rahul Sundaram methe...@gmail.com 2011-06-27 11:38:44 EDT --- Any update? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #33 from Oded Arbel o...@geek.co.il 2011-06-27 12:38:40 EDT --- (In reply to comment #32) Any update? Thanks for taking the time to review the package. I apologize that I have not made any response yet - I'm busy doing other urgent things, but I will get back to this tomorrow. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #31 from Rahul Sundaram methe...@gmail.com 2011-06-23 09:54:29 EDT --- Also you can remove %defattr as that is redundant now as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #30 from Rahul Sundaram methe...@gmail.com 2011-06-23 09:53:07 EDT --- I am not a sponsor but I will do a final review and see if I can get someone to sponsor you. I have some comments: * Must not define dist in your spec file. * Must replace %define with %global in all applicable cases in this spec * You are defining a macro called section and only using it once. Seems useless * Don't need to define python_sitelib or buildroot in the spec * No need for %clean section anymore * Remove all commented out lines. They just clutter the spec file Run rpmlint on spec file, srpm and binary rpm and fix the warnings and errors as applicable. Also ensure that you post a link to both the spec and the srpm next time. Verify that it works under mock. I would also suggest doing a scratch build under koji and posting a link here. Do ask if anything above is not clear to you. I am mether in #fedora-devel if you have any questions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||methe...@gmail.com Resolution||CANTFIX Last Closed|2010-02-21 06:14:02 |2011-04-18 12:49:08 --- Comment #27 from Rahul Sundaram methe...@gmail.com 2011-04-18 12:49:08 EDT --- This seems to be a dead review for a long time. I am closing this since I am going to open a new review request for the same software (need it as a dependency of a software that I would like to see in Fedora). Oded Arbel, if you are still interested in being a Fedora package maintainer, drop a me a mail and I will find a way to get you sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|CANTFIX | --- Comment #28 from Rahul Sundaram methe...@gmail.com 2011-04-18 12:56:11 EDT --- On second thought, the last comment has been about four months back and does have a assigned reviewer. I will give it say a week time before closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #25 from Matthew Miller mat...@mattdm.org 2010-12-15 15:55:48 EST --- The tests are failing because there are tons of deprecation warnings, and the tests are (justifiably) run with warnings made into errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #26 from Matthew Miller mat...@mattdm.org 2010-12-15 15:57:41 EST --- Also — the current version is 0.90, as of January 2010. I thought that might fix up the deprecation warnings, but no such luck. http://code.google.com/p/html5lib/downloads/detail?name=html5lib-0.90.zip -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Oded Arbel o...@geek.co.il changed: What|Removed |Added Attachment #464828|0 |1 is obsolete|| --- Comment #24 from Oded Arbel o...@geek.co.il 2010-12-12 12:15:09 EST --- Created attachment 468243 -- https://bugzilla.redhat.com/attachment.cgi?id=468243 Updated spec file according to comments Thanks for the comments :-) (In reply to comment #23) Replace %define modulename htmllib with %global modulename htmllib: Done. The %define python_sitelib isn't needed anymore (since F-13): Done. The same goes for the BuildRoot tag and the %clean section: Done. I should really sit down and read the packaging guidelines from top to bottom. What's with all the #---? Please drop them. Its from a template I use for creating new spec files - in my company we expect developers to maintain their own spec files and I find it helps newbies. I've removed them. We're on F-14 now, so that conditional isn't needed. Done. The %files section is a bit too general for my taste. Adding files explicitly helps you by breaking the build when newer versions of htmllib decide to drop/add files. I've changed the %files section to specifically list all the python packages that are expected to exist (as I've seen some other python RPMs do). It's not a lot more specific then your example, I hope that's OK. In the %pre section: isn't needed, that's handled by the %setup macro. Removed. And what about the tests? You should run them in a %check section, if possible. I've added %check with the tests, but on my system almost all of them fail. I'm not an html5lib developer so I'm not sure who's at fault here, so I commented it out in the mean time. I'll check whats up with that when I have the time. SRPM and precompiled binary for Fedora 14 are again available at http://rpms.geek.co.il/fc14/SRPMS/python-html5lib-0.11-2.fc14.src.rpm and http://rpms.geek.co.il/fc14/x86_64/python-html5lib-0.11-2.fc14.noarch.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Blocks|201449(FE-DEADREVIEW) |177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Comment #23 from Ruben Kerkhof ru...@rubenkerkhof.com 2010-12-12 08:29:53
EST ---
Hi Odel,
Some comments:
Replace %define modulename htmllib with %global modulename htmllib:
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
The %define python_sitelib isn't needed anymore (since F-13):
https://fedoraproject.org/wiki/Packaging:Python#Macros
The same goes for the BuildRoot tag and the %clean section:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
What's with all the #---?
Please drop them.
%if 0%{?fedora} = 8
BuildRequires: python-setuptools-devel
%else
BuildRequires: python-setuptools
%endif
We're on F-14 now, so that conditional isn't needed.
The %files section is a bit too general for my taste.
Adding files explicitly helps you by breaking the build when newer versions of
htmllib decide to drop/add files. So something like:
%files
%defattr(-,root,root,0755)
%doc examples README
%{python_sitelib}/%{modulename}
%{python_sitelib}/%{modulename}-*.egg-info
In the %pre section:
rm -rf %{modulename}-%{version}
isn't needed, that's handled by the %setup macro.
And what about the tests? You should run them in a %check section, if possible.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Matthew Miller mat...@mattdm.org changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||mat...@mattdm.org Resolution|NOTABUG | Keywords||Reopened --- Comment #22 from Matthew Miller mat...@mattdm.org 2010-12-08 15:32:27 EST --- Reopening. See comment #21. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #21 from Oded Arbel o...@geek.co.il 2010-12-05 07:04:17 EST --- Created attachment 464828 -- https://bugzilla.redhat.com/attachment.cgi?id=464828 Updated spec for python-html5lib Sorry for taking a long while with this (3 years :-( ), but here is an updated spec for python-html5lib 0.11, with the zip issue fixed. SRPM and precompiled binary for Fedora 14 are available at http://rpms.geek.co.il/fc14/SRPMS/python-html5lib-0.11-1.fc14.src.rpm and http://rpms.geek.co.il/fc14/x86_64/python-html5lib-0.11-1.fc14.noarch.rpm. Thanks for Matthew Miller for nudging me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|fedora-review?, | |needinfo?(o...@geek.co.il) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
