[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2010-09-30 13:08:21 EDT --- drraw-2.2-0.6.b2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drraw-2.2-0.6.b2.fc14 |drraw-2.2-0.6.b2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drraw-2.2-0.6.b2.fc13 |drraw-2.2-0.6.b2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2010-09-23 08:54:18 EDT --- drraw-2.2-0.6.b2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2010-09-21 20:35:58 EDT --- drraw-2.2-0.6.b2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2010-09-21 20:33:54 EDT --- drraw-2.2-0.6.b2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drraw-2.2-0.6.b2.fc12 |drraw-2.2-0.6.b2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drraw-2.2-0.6.b2.fc12 Resolution||ERRATA Last Closed||2010-09-21 20:34:01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2010-09-15 14:28:41 EDT --- drraw-2.2-0.6.b2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update drraw'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2010-09-14 18:26:05 EDT --- drraw-2.2-0.6.b2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-08-26 08:43:00 EDT --- drraw-2.2-0.6.b2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-08-26 08:43:05 EDT --- drraw-2.2-0.6.b2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-08-26 08:43:10 EDT --- drraw-2.2-0.6.b2.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2010-08-26 14:35:24 EDT --- drraw-2.2-0.6.b2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update drraw'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/drraw-2.2-0.6.b2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #16 from Kevin Fenzi ke...@tummy.com 2010-08-23 16:53:52 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Xavier Bachelot xav...@bachelot.org 2010-08-20 06:44:53 EDT --- New Package SCM Request === Package Name: drraw Short Description: Web based presentation front-end for RRDtool Owners: xavierb Branches: f12 f13 f14 el5 el6 InitialCC: Thanks a lot for the review Rafael :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #15 from Rafael Aquini aqu...@linux.com 2010-08-20 14:25:31 EDT --- Xavier, Please, consider including man pages for drraw before shipping it to testing, as it is a SHOULD item on review process. Regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #12 from Xavier Bachelot xav...@bachelot.org 2010-08-19 11:02:13 EDT --- Rafael, New package with your comments addressed : http://www.bachelot.org/fedora/SPECS/drraw.spec http://www.bachelot.org/fedora/SRPMS/drraw-2.2-0.6.b2.fc13.src.rpm Thanks for the selinux fix (this is still untested though). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Rafael Aquini aqu...@linux.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Rafael Aquini aqu...@linux.com 2010-08-19 20:20:53 EDT --- Xavier, Tanks for replying promptly, and also thanks for addressing the NEEDSWORK suggested. As a result, drraw has been built correctly in mock and koji, and also it has installed and worked fine in my test system. http://koji.fedoraproject.org/koji/taskinfo?taskID=2413481 IMHO this package looks OK, and I'm approving it. Regards. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #11 from Xavier Bachelot xav...@bachelot.org 2010-08-16 10:10:55 EDT --- (In reply to comment #10) Xavier, It's been a week since I've posted a formal review to this package of yours without having a single reply from you. Please, let me know if you are facing any difficulty to finish this work, and tell me how can I help you. If you, for instance, just lost your interest in getting this work reviewed, let me aware as well. Regards. Hi Rafael, Thanks for the review. I'm just back from a 2 weeks vacation with no internet access. I've not lost interest and I'll submit a new srpm addressing the issues you outlined asap (probably before the end of the week). Regards, Xavier -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473348
Rafael Aquini aqu...@linux.com changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|aqu...@linux.com
Flag||fedora-review?
--- Comment #9 from Rafael Aquini aqu...@linux.com 2010-08-02 12:54:28 EDT ---
Xavier,
I'm assigning this bug to me, and proceeding the formal review as follows.
Good:
* Package is named drraw which follows the upstream project name
* spec file naming follows package naming
* License in spec and sources is BSD which is open source
* License text included in the tarball so no need to include one.
* Spec is legible and American English
* http://web.taranis.org/drraw/dist/drraw-2.2b2.tar.gz
* Source matches upstream
* No locale files
* No shared libraries
* No bundled libraries
* Not relocatable
* No directories created unowned
* No duplicate files
* Default permissions are set
* Package is code
* No large documentation
* No %doc files are used at runtime
* No header files
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8
Needswork:
* Patch files should have upstream issues opened to look good for our purposes
* rpmlint complains about macros in comments:
drraw.src:68: W: macro-in-comment %{SOURCE2}
drraw.src:88: W: macro-in-comment %doc
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
* Minor adjusts needed to sections %post %unpost at -selinux subpackage:
%post selinux
semanage fcontext -a -t httpd_sys_script_exec_t '%{_datadir}/%{name}(/.*)?'
2/dev/null || :
semanage fcontext -a -t httpd_sys_rw_content_t
'%{_localstatedir}/lib/%{name}(/.*)?' 2/dev/null || :
restorecon -R %{_datadir}/%{name} %{_localstatedir}/lib/%{name} || :
%postun selinux
if [ $1 -eq 0 ] ; then
semanage fcontext -d -t httpd_sys_script_exec_t '%{_datadir}/%{name}(/.*)?'
2/dev/null || :
semanage fcontext -d -t httpd_sys_rw_content_t
'%{_localstatedir}/lib/%{name}(/.*)?' 2/dev/null || :
fi
* Test builds in mock koji
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Rafael Aquini aqu...@linux.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #8 from Xavier Bachelot xav...@bachelot.org 2010-08-01 09:43:57 EDT --- (In reply to comment #7) PING It's been more than a year with no progress; This bug should be closed soon if there is no response, shouldn't it? The review is not assigned to anyone. The only reported issue for now is about the SE Linux stuff. I tried to blindly addressed it by adding a -selinux subpackage with what I think is the correct fix. However, I wasn't able to test it, that's why I said blindly. I don't know much when it comes to SE Linux, but I believe the proposed change in comment #6 is not the proper fix. If someone step up to the plate for the review, I'll setup a VM and take another look at the SE Linux issue, but I don't think this is a blocker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
