[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Status|MODIFIED|ASSIGNED CC||supercyp...@gmail.com AssignedTo|nob...@fedoraproject.org|supercyp...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476523
--- Comment #14 from Chen Lei supercyp...@gmail.com 2010-08-31 07:46:44 EDT
---
1.
BuildRequires: python-devel
Requires: python2-devel
Choose either python2-devel or python-devel
2.
Group: Development/Languages
-
Group: Development/Libraries
3.
%check
%{__python} setup.py test
I suggest to remove %check section and BuildRequires: python-zope-testing from
all zope packages, circuitous dependencies is unacceptable for zope modules.
Things will become very complicated if we want to update zope version for
stable fedora releases.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #15 from Robin Lee robinlee.s...@gmail.com 2010-08-31 11:58:00 EDT --- 3.6.1-2 Spec URL: http://cheeselee.fedorapeople.org/python-zope-proxy.spec SRPM URL: http://cheeselee.fedorapeople.org/python-zope-proxy-3.6.1-2.fc13.src.rpm Changes: - Remove %%check section - Group changed from Development/Languages to Development/Libraries - BR: python-devel renamed to python2-devel, python-zope-testing removed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #16 from Thomas Spura toms...@fedoraproject.org 2010-08-31 12:15:43 EDT --- (In reply to comment #13) I now take over this review request. Please open your own review request and close this one as a dublicate of the new one. See: http://www.fedora.redhat.com/wiki/Policy_for_stalled_package_reviews (You are resubmitting this package...) Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DUPLICATE Last Closed||2010-08-31 12:57:44 --- Comment #18 from Robin Lee robinlee.s...@gmail.com 2010-08-31 12:57:44 EDT --- *** This bug has been marked as a duplicate of bug 629014 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED AssignedTo|robinlee.s...@gmail.com |nob...@fedoraproject.org --- Comment #13 from Robin Lee robinlee.s...@gmail.com 2010-08-31 01:03:06 EDT --- I now take over this review request. Spec URL: http://cheeselee.fedorapeople.org/python-zope-proxy.spec SRPM URL: http://cheeselee.fedorapeople.org/python-zope-proxy-3.6.1-1.fc13.src.rpm Changes: - Update to 3.6.1 - Requirement: python-zope-filesystem removed, python-zope-interface added - Spec cleaned up - -devel subpackage set to noarch, added python2-devel as requirement - Include the license rpmlint results: $ rpmlint ./python-zope-event.spec ./python-zope-event.spec: W: no-cleaning-of-buildroot %clean ./python-zope-event.spec: W: no-buildroot-tag ./python-zope-event.spec: W: no-%clean-section 0 packages and 1 specfiles checked; 0 errors, 3 warnings. $ rpmlint ./python-zope-proxy-3.6.1-1.fc13.src.rpm python-zope-proxy.src: W: no-cleaning-of-buildroot %clean python-zope-proxy.src: W: no-buildroot-tag python-zope-proxy.src: W: no-%clean-section 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint ./python-zope-proxy-3.6.1-1.fc13.i686.rpm python-zope-proxy.i686: W: private-shared-object-provides /usr/lib/python2.6/site-packages/zope/proxy/_zope_proxy_proxy.so _zope_proxy_proxy.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./python-zope-proxy-devel-3.6.1-1.fc13.noarch.rpm python-zope-proxy-devel.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./python-zope-proxy-debuginfo-3.6.1-1.fc13.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added AssignedTo|fab...@bernewireless.net|robinlee.s...@gmail.com --- Comment #12 from Robin Lee robinlee.s...@gmail.com 2010-06-16 12:54:48 EDT --- The spec file is well-structured. Few notes: * According to upstream setup.py, this package should require python-zope-interface. * The two sed commands are not necessary since the files are with proper EOL. * The -devel package should require python-devel, or more accurately python2-devel. And it should be marked noarch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #11 from Conrad Meyer kon...@tylerc.org 2010-06-08 00:28:44 EDT --- http://konradm.fedorapeople.org/fedora/SPECS/python-zope-proxy.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-zope-proxy-3.6.0-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #10 from Thomas Spura toms...@fedoraproject.org 2010-06-06 11:34:59 EDT --- (In reply to comment #9) Sorry I missed the latest comment. I will try to finish the review soon. @Fabian: Any progress here? If you don't want to continue this one, I can take it :) @Conrad: A new version from upstream with some changes e.g. different source (now a zip file etc) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #9 from Fabian Affolter fab...@bernewireless.net 2010-04-08 09:19:00 EDT --- Sorry I missed the latest comment. I will try to finish the review soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476523 --- Comment #8 from Conrad Meyer kon...@tylerc.org 2010-02-15 06:06:38 EST --- The tests pass and it seems to not cause any problems when imported in python's interactive mode. Without *.c and *.h files: http://konradm.fedorapeople.org/fedora/SPECS/python-zope-proxy.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-zope-proxy-3.5.0-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476523] Review Request: python-zope-proxy - Generic Transparent Proxies
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476523
--- Comment #7 from Thomas Spura toms...@fedoraproject.org 2010-01-29
08:05:37 EST ---
I usualy include *.c and *.h in the main package, if they are below
%{python_sitelib/arch}, because it's likely, that the main package requires
this at runtime.
If other packages could/should build against these *.c and *.h, it would be
better to place them in %{_includedir} at upstream directly. Because they
didn't to that, I assume, that it's just needed internally.
Could you test, if the package also works without the installed *.c and *.h?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
