[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|emacs-color-theme-6.6.0-4.e |emacs-color-theme-6.6.0-4.e |l5 |l6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2011-03-09 13:27:32 EST --- emacs-color-theme-6.6.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2011-03-07 13:23:12 EST --- emacs-color-theme-6.6.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||emacs-color-theme-6.6.0-4.e ||l5 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2011-02-21 11:28:34 EST --- emacs-color-theme-6.6.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/emacs-color-theme-6.6.0-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2011-02-19 06:57:52 EST --- emacs-color-theme-6.6.0-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/emacs-color-theme-6.6.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Arun SAG saga...@gmail.com changed: What|Removed |Added CC||npajk...@redhat.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #21 from Arun SAG saga...@gmail.com 2011-02-17 13:39:39 EST --- Package Change Request == Package Name: emacs-color-theme New Branches: el5 el6 Owners: sagarun (I'd like to have this package on EPEL) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #22 from Jason Tibbitts ti...@math.uh.edu 2011-02-17 13:45:05 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #20 from Jason Tibbitts ti...@math.uh.edu 2010-06-16 18:04:15 EDT --- Please file change requests to add new branches to existing packages; to do otherwise confuses the automation we have in place. http://fedoraproject.org/wiki/CVS_admin_requests#Package_Change_Requests_for_existing_packages I've created the new branch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #19 from Arun SAG saga...@gmail.com 2010-06-15 11:51:07 EDT --- New Package CVS Request === Package Name:emacs-color-theme Short Description: Color themes for Emacs Owners: sagarun Branches: F12 (I need to push this package for F12, Kindly create a F12 branch) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #18 from Kevin Fenzi ke...@tummy.com 2010-05-12 13:12:43 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Arun SAG saga...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #16 from Jonathan Underwood jonathan.underw...@gmail.com 2010-05-11 13:10:01 EDT --- OK, great. 6.6.0-3 builds fine in mock, passes review, and functions properly. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Arun SAG saga...@gmail.com 2010-05-11 13:17:35 EDT --- New Package CVS Request === Package Name:emacs-color-theme Short Description: Color themes for Emacs Owners: sagarun Branches: F13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #15 from Arun SAG saga...@gmail.com 2010-05-10 11:58:35 EDT --- Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-color-theme.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-color-theme-6.6.0-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #14 from Arun SAG saga...@gmail.com 2010-05-09 08:52:19 EDT --- Hi, I will update this package in upcoming week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #10 from Filippo Argiolas fargio...@gnome.org 2010-04-17 11:48:46 EDT --- Unfortunately, I have very little time to dedicate to this thing, if anyone wants to pick up where I've left I'll be more than glad! Otherwise I will probably look at the pointed issues but not anytime soon. Answering some questions: - patches weren't upstreamed - emacs-goodies didn't exist at the time I wrote the spec file. Arun, would you like to split color-themes from your package and maintain an independent package for it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #11 from Arun SAG saga...@gmail.com 2010-04-17 14:25:35 EDT --- Filippo, I will remove color-themes from emacs-goodies in next update. Let me pick up from where you left :-) Spec URL: http://sagarun.fedorapeople.org/SPECS/emacs-color-theme.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/emacs-color-theme-6.6.0-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501101
--- Comment #12 from Jonathan Underwood jonathan.underw...@gmail.com
2010-04-17 16:06:27 EDT ---
Arun, great to see you're picking the package up, and that you've tackled all
the points in the review.
A few small things:
1/ For F-13 onwards, the %clean section is unnecessary:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
2/ The Buildroot tag isn't needed, and you don't need to do rm -rf %{buildroot}
in %install:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
3/ The patches still need a spec file comment regarding their upstream status:
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
Also - should this package not have a startup file (in %{_emacs_sitestartdir})
?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added CC||jonathan.underw...@gmail.co ||m --- Comment #8 from Jonathan Underwood jonathan.underw...@gmail.com 2010-04-05 21:17:52 EDT --- Rebuilding packages in mock works fine. rpmlint output on resulting packages: $ rpmlint *.rpm emacs-color-theme.noarch: W: spelling-error %description -l en_US customizations - customization, customization's, customization s emacs-color-theme.src: W: spelling-error %description -l en_US customizations - customization, customization's, customization s These can be ignored. emacs-color-theme.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 15) - This needs fixing (untabify the spec file) emacs-color-theme-el.noarch: W: spelling-error Summary(en_US) Elisp - Lisp, Elise, Elisa emacs-color-theme-el.noarch: W: spelling-error %description -l en_US elisp - lisp, e lisp, Elise -- Ignore these emacs-color-theme-el.noarch: W: no-documentation --- This is fine, ignore. 3 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501101
--- Comment #9 from Jonathan Underwood jonathan.underw...@gmail.com
2010-04-05 21:42:05 EDT ---
The package needs updating to comply with the most recent emacs packaging
guidelines: http://fedoraproject.org/wiki/Packaging:Emacs
Specifically, in the spec file:
1/ Remove the pkgconfig stuff
2/ Update the macros to use the new names eg %{emacs_version}-{_emacs_version}
etc
3/ Don't buildrequire emacs-el
4/ Add comments about the patches - have they been sent upstream, if so when.
Give URLs to upstream bugzilla or mailing list archives if appropriate
5/ Spec file legibility is compromised by having lines commented out,
particularly ones which begin with macros - commenting a macro may not always
disable it! Please remove the unneeded commented code lines from the spec file.
In addition, note that color-theme is already included in the emacs-goodies
package which is already in Fedora. Personally I would like to see color-theme
packaged separately from the goodies collection (which contains a lot of nasty
elsip of low quality). Once this passes review you'll need to coordinate with
the emacs-goodies package owner to remove the color theme stuff from that
package.
Formal Review:
Key:
[X] All is OK.
[A] Needs action
[A] MUST: rpmlint must be run on every package. The output should be posted in
the review.
---See comment #8 for things that need fixing.
[X] MUST: The package must be named according to the Package Naming Guidelines
.
[X] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
[A] MUST: The package must meet the Packaging Guidelines .
--- See the points above
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[A] MUST: The License field in the package spec file must match the actual
license.
---color-theme.el states that the files is GPLv2+, but the spec file says
GPLv2. This needs clarifying.
[X]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[X] MUST: The spec file must be written in American English. [5]
[A] MUST: The spec file for the package MUST be legible. [6]
--- See point above about removing the commented out lines
[X] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Packaged source md5sum:
a4de73c236a6af11ab378bfe18dabcca color-theme-6.6.0.tar.gz
Upstream md5sum:
a4de73c236a6af11ab378bfe18dabcca color-theme-6.6.0.tar.gz
[X] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[X] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[X] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[X] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[X] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[X] MUST: Packages must NOT bundle copies of system libraries.[11]
[X] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[X] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[X] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. [14]
[X] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
[A] MUST: Each package must consistently use macros. [16]
Please use the correct macros from the most recent Emacs add-on
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|jonathan.underw...@gmail.co ||m -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
