[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-08-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #28 from Fedora Update System  
2010-08-06 15:56:18 EDT ---
wsdlpull-1.23-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-08-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||wsdlpull-1.23-3.el5
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA

--- Comment #27 from Fedora Update System  
2010-07-21 16:01:48 EDT ---
wsdlpull-1.23-3.el5 has been pushed to the Fedora EPEL 5 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update wsdlpull'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/wsdlpull-1.23-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #25 from Fedora Update System  
2010-07-19 17:26:16 EDT ---
wsdlpull-1.23-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/wsdlpull-1.23-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #26 from Fedora Update System  
2010-07-19 17:26:38 EDT ---
wsdlpull-1.23-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/wsdlpull-1.23-3.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #24 from Fedora Update System  
2010-07-19 17:24:40 EDT ---
wsdlpull-1.23-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/wsdlpull-1.23-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #23 from Kevin Fenzi  2010-07-19 00:44:07 EDT ---
CVS done (by process-cvs-requests.py).

We no longer do F11 branches (it's end of life)
We aren't yet doing F14 branches. 

Otherwise, all done. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #22 from Denis Arnaud  2010-07-18 
18:24:42 EDT ---
(In reply to comment #16)
> The only thing remaining is to submit the patches upstream (to Vivek).

All the patches have been committed to the WSDLPull official repository, and
integrated in the new release, namely 1.24. That latter has to be approved by
the project owner, namely Vivek Krishna. Once it will be done, I will of course
update the Fedora packaging CVS repository with that last version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #21 from Denis Arnaud  2010-07-18 
06:03:10 EDT ---
(In reply to comment #20)
> Once you get access figured out, please reset the fedora-cvs flag to ? and 
> add a CVS request here.

New Package CVS Request
===
Package Name: wsdlpull
Short Description: C++ Web Services client library
Owners: denisarnaud
Branches: F-11 F-12 F-13 EL-5 EL-6 # F-14 (if available)
InitialCC: denisarnaud
===

I can manage the CVS request from a network server (not my home desktop on
which I experiment Koji connection issues) I own.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Denis Arnaud  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #20 from Kevin Fenzi  2010-07-16 13:28:50 EDT ---
Once you get access figured out, please reset the fedora-cvs flag to ? and 
add a CVS request here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #19 from Patrick Monnerat  2010-07-16 13:20:46 
EDT ---
No hurry for me. I won't take your baby just before birth :-)
If you have infrastructure access problems, check if your certificate is not
outdated... Also last week I had several CVS/Koji connection problems: I
reported them to the infrastructure trac system
(https://fedorahosted.org/fedora-infrastructure/), they answered very kindly
and they mended it.
Else you better ask for help on some mailing list, but in any case you should
be able to do the job yourself.
Good luck.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #18 from Denis Arnaud  2010-07-15 
14:43:35 EDT ---
(In reply to comment #17)
> SHOULD: All patches should have an upstream bug link or comment
> Why don't you simply leave them at
>   http://sourceforge.net/tracker/?group_id=96736&atid=615730
> and reference patch reports here?

Yes, but apparently, the whole communication (including bugs and patches)
should go through the dedicated Yahoo! group:
http://tech.groups.yahoo.com/group/wsdlpull/ . I can of course create bug
tickets, but they may never be read by the person they should reach.

So, I have sent an email to Vivek (upstream owner), providing him with the
three patches.
[Note that I have (Vivek gave me, last year) access rights to publish packages
on Sourceforge
(http://sourceforge.net/projects/wsdlpull/files/binaries/wsdlpull%201.23/), but
no write access on the CVS repository]

I'll keep the specification file updated with latest debates around those
patches.


> Package approved

Thanks for that extensive review!
Now, I am unable to interact with the secured Koji server:
http://lists.fedoraproject.org/pipermail/packaging/2010-July/007283.html
I've fought hours and hours to find a work around (having tried on several
Fedora distributions, thanks to VirtualBox, with several distinct user
accounts), but could not.

So, do not hesitate to create the package in CVS yourself. Otherwise, I'm
afraid I won't be able to create it myself :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Denis Arnaud  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Patrick Monnerat  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|denis.arnaud_fed...@m4x.org |p...@datasphere.ch
   Flag||fedora-review+

--- Comment #17 from Patrick Monnerat  2010-07-15 11:39:27 
EDT ---
rpmlint output:
  wsdlpull.spec: W: no-buildroot-tag
  wsdlpull.src: W: spelling-error %description -l en_US serializer ->
serialize, serializes, serialized
  wsdlpull.src: W: no-buildroot-tag
  wsdlpull.x86_64: W: spelling-error %description -l en_US serializer ->
serialize, serializes, serialized
  wsdlpull.x86_64: W: shared-lib-calls-exit /usr/lib64/libxmlpull.so.1.0.23
e...@glibc_2.2.5
  wsdlpull-devel.x86_64: W: no-documentation
  5 packages and 1 specfiles checked; 0 errors, 6 warnings.

  Can be safely ignored. (the exit call in the code is not a packaging problem:
I suggest you talk with upstream about possible removal and/or
replacement).

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321987

Review:

OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  source files match upstream:
wsdlpull-1.23.tar.bz2
  sha1: 7b61549e18bf0e9aae68bfb76264f6e58c8a8d7b
  md5: 68ba60913b5860cae1a07ee8ccdd43cf
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches all the actual licenses.
OK  license is open source-compatible.
OK  license text included in package.
OK  All BuildRequires are needed.
OK  %clean is present.
OK  The package meets the Packaging Guidelines.
OK  package builds in Koji (rawhide).
OK  package installs properly.
OK  rpmlint is OK
OK  final provides and requires are sane:
rpm -q --provides -p wsdlpull-1.23-3.fc12.x86_64.rpm 
  libschema.so.1()(64bit)  
  libwsdl.so.1()(64bit)  
  libxmlpull.so.1()(64bit)  
  wsdlpull = 1.23-3.fc12
  wsdlpull(x86-64) = 1.23-3.fc12
rpm -q --requires -p wsdlpull-1.23-3.fc12.x86_64.rpm 
  /sbin/ldconfig  
  /sbin/ldconfig  
  libc.so.6()(64bit)  
  libc.so.6(GLIBC_2.2.5)(64bit)  
  libc.so.6(GLIBC_2.3.4)(64bit)  
  libc.so.6(GLIBC_2.4)(64bit)  
  libcurl.so.4()(64bit)  
  libgcc_s.so.1()(64bit)  
  libgcc_s.so.1(GCC_3.0)(64bit)  
  libm.so.6()(64bit)  
  libpthread.so.0()(64bit)  
  libpthread.so.0(GLIBC_2.2.5)(64bit)  
  libschema.so.1()(64bit)  
  libstdc++.so.6()(64bit)  
  libstdc++.so.6(CXXABI_1.3)(64bit)  
  libstdc++.so.6(CXXABI_1.3.1)(64bit)  
  libstdc++.so.6(GLIBCXX_3.4)(64bit)  
  libstdc++.so.6(GLIBCXX_3.4.11)(64bit)  
  libstdc++.so.6(GLIBCXX_3.4.9)(64bit)  
  libwsdl.so.1()(64bit)  
  libxmlpull.so.1()(64bit)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rtld(GNU_HASH)  
  rpmlib(PayloadIsXz) <= 5.2-1
rpm -q --provides -p wsdlpull-devel-1.23-3.fc12.x86_64.rpm 
  wsdlpull-devel = 1.23-3.fc12
  wsdlpull-devel(x86-64) = 1.23-3.fc12
rpm -q --requires -p wsdlpull-devel-1.23-3.fc12.x86_64.rpm 
  libschema.so.1()(64bit)  
  libwsdl.so.1()(64bit)  
  libxmlpull.so.1()(64bit)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  wsdlpull = 1.23-3.fc12
  rpmlib(PayloadIsXz) <= 5.2-1
rpm -q --provides -p wsdlpull-doc-1.23-3.fc12.noarch.rpm 
  wsdlpull-doc = 1.23-3.fc12
rpm -q --requires -p wsdlpull-doc-1.23-3.fc12.noarch.rpm 
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(PayloadIsXz) <= 5.2-1
OK  %check is not present; no test suite upstream.
OK  shared libraries are added to the regular linker search paths: ldconfig
properly called in %post and %postun
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code and allowed content.
OK  There is a separate -doc subpackage for the documentation.
OK  %docs are not necessary for the proper functioning of the package.
OK  headers are in the -devel subpackage.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.
OK  filenames are all valid UTF-8.


SHOULD: All patches should have an upstream bug link or comment
Why don't you simply leave them at
  http://sourceforge.net/tracker/?group_id=96736&atid=615730
and reference patch reports here ?

Package approved

-- 
Configure bugmail: https://bugzilla.red

[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

Denis Arnaud  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|denis.arnaud_fed...@m4x.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #15 from Denis Arnaud  2010-07-14 
04:32:10 EDT ---
(In reply to comment #13)
> http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
> This is not mandatory, but you planned to submit patches upstream and you
> forgot to do it. I suggest you do it now and insert the links to the upstream
> patch reports in your comments.

Yes, of course, I knew that one :)
I'll keep upstream (Vivek Krishna) updated, and include the corresponding
references within the specification file.


> From comment 6:
> > You should use xargs option -r in
> > find . -name 'CVS' -print | xargs rm -rf
> > find . -name 'a.out' -print | xargs rm -f
> > in prevision of future versions not containing the targets.
> 
> You did not apply this change. Any reason for that ?

Sorry for that. I did not understand it the first time: I thought you were
referring to the -r option of the rm command, not of the xargs command... I now
understand that that GNU extension to xargs is pretty useful when there is no
CVS directory or a.out file.


> > I've left the %doc in the -devel sub-package, though.
> Please read
> http://lists.fedoraproject.org/pipermail/devel/2010-July/138487.html and
> http://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files

Yes, I knew both items above. But duplicating files is tolerated... and
prevents rpmlint from issuing the following warning:
 wsdlpull-devel.x86_64: W: no-documentation
 The package contains no documentation (README, doc, etc). You have to include
 documentation files.

So, I removed the duplicated documentation files, and the warning is back. But
it has no importance, hasn't it?


.../...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #16 from Denis Arnaud  2010-07-14 
04:32:43 EDT ---
(In reply to comment #13)
> Buildroot is no longer needed:
> http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

You are right, and I did not remember that one. I've changed the BuildRoot tag
line by:
 %{?el5:BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XX)}
which is apparently the recommended option for EPEL 5 packaging
(http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag).

However, rpmlint reports a warning here:
 wsdlpull.src: W: no-buildroot-tag

But, as explained in that warning description, all is fine with a version of
rpm greater than 4.6. Which is of course the case for all the active Fedora
distributions and for EPEL 6 as well (but not for EPEL distributions for
version 5 downwards).


> You can save the "BuildRequires: dos2unix" by replacing the call to dos2unix 
> by
> 
> sed -i -e 's/\r$//'

Yes, you are right. Even better, your solution sounds more Unix than that DOS
file converter...


The only thing remaining is to submit the patches upstream (to Vivek).


Thanks for your feedback.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #14 from Denis Arnaud  2010-07-14 
04:27:40 EDT ---
Spec: http://denisarnaud.fedorapeople.org/wsdlpull/123/wsdlpull.spec
SRPM:
http://denisarnaud.fedorapeople.org/wsdlpull/123/wsdlpull-1.23-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #13 from Patrick Monnerat  2010-07-12 07:00:55 
EDT ---
Some more things:

http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
This is not mandatory, but you planned to submit patches upstream and you
forgot to do it. I suggest you do it now and insert the links to the upstream
patch reports in your comments.

>From comment 6:
> You should use xargs option -r in
> find . -name 'CVS' -print | xargs rm -rf
> find . -name 'a.out' -print | xargs rm -f
> in prevision of future versions not containing the targets.

You did not apply this change. Any reason for that ?

> I've left the %doc in the -devel sub-package, though.
Please read
http://lists.fedoraproject.org/pipermail/devel/2010-July/138487.html and
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files

Buildroot is no longer needed:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

You can save the "BuildRequires: dos2unix" by replacing the call to dos2unix by

sed -i -e 's/\r$//'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #12 from Denis Arnaud  2010-07-11 
16:50:11 EDT ---
Spec: http://denisarnaud.fedorapeople.org/wsdlpull/123/wsdlpull.spec
SRPM:
http://denisarnaud.fedorapeople.org/wsdlpull/123/wsdlpull-1.23-2.fc13.src.rpm

I eventually did it :)
Normally, all your feedbacks
(https://bugzilla.redhat.com/show_bug.cgi?id=502686#c6) have been taken into
account. I've renamed the two generated binaries, namely wsdl and schema, into
respectively wsdlpull and wsdlpull-schema, so as to avoid any name conflict.

I've left the %doc in the -devel sub-package, though.

Moreover, Fedora 13's rpmlint is stricter, and I have worked on reducing
warnings. For instance, I had to add man pages (which I will of course submit
upstream).

Koji was migrated to a new version of software (v1.4, I believe) this week-end,
and I could therefore not submit any task to it.

Do not hesitate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #11 from Denis Arnaud  2010-06-11 
14:37:15 EDT ---
If you don't mind keeping those files around, it would be nice, as I do not
want to give up (at least for now!).
Thanks for your renewed support :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #10 from Patrick Monnerat  2010-06-11 12:14:17 
EDT ---
libcurl only transmits data on IP-based protocols: there is no support for SOAP
or XML.

And I do not want to take your package: I started reviewing it (see comment 6)
and I just want to know if the files I keep locally about this in-progress
review will have a future, or if I can delete them (friday is housekeeping day
:-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #9 from Denis Arnaud  2010-06-11 
12:06:39 EDT ---
(In reply to comment #8)
> ... very long week-end indeed :-)

You're right!
I still think it makes sense to have that package into Fedora, even though
libcurl (http://curl.haxx.se/libcurl/) seems to represent a viable alternative.

But as I have not so much free time these days, if you want to take the
responsibility of that package, do not hesitate...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #8 from Patrick Monnerat  2010-06-11 11:32:25 
EDT ---
Ping ?
... very long week-end indeed :-)
Are you still interested in importing this package into Fedora ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review