[Bug 508351] Review Request: josm - java openstreetmap editor
https://bugzilla.redhat.com/show_bug.cgi?id=508351 Cédric OLIVIER cedric.oliv...@free.fr changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #75 from Cédric OLIVIER cedric.oliv...@free.fr --- Package Change Request == Package Name: josm New Branches: epel7 Owners: cquad mcepl -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
https://bugzilla.redhat.com/show_bug.cgi?id=508351 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #76 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #73 from Fedora Update System upda...@fedoraproject.org 2010-06-29 11:29:11 EDT --- josm-0-0.8.3329svn.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|josm-0-0.8.3329svn.fc12 |josm-0-0.8.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #74 from Fedora Update System upda...@fedoraproject.org 2010-06-29 11:30:34 EDT --- josm-0-0.8.3329svn.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #71 from Fedora Update System upda...@fedoraproject.org 2010-06-23 13:39:09 EDT --- josm-0-0.8.3329svn.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update josm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #72 from Fedora Update System upda...@fedoraproject.org 2010-06-23 13:51:13 EDT --- josm-0-0.8.3329svn.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update josm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #60 from Leif Gruenwoldt lei...@gmail.com 2010-06-22 10:15:00 EDT --- Trying josm from fedora updates-testing repo this morning On startup I get: $ josm Warning: the revision file '/REVISION' is missing. Warning: no preference 'proxy.policy' found. The proxy will not be used. The side effect of this seems to be that the splash screen on startup says Version UNKNOWN and then the intial intro help window pane says Strange version - You should update! FYI, $ rpm -q josm josm-0-0.6.3329svn.fc13.noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #61 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-22 10:41:19 EDT --- It's done : https://admin.fedoraproject.org/updates/josm-0-0.7.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #62 from Benjamín Valero Espinosa benjaval...@gmail.com 2010-06-22 10:59:51 EDT --- (In reply to comment #61) It's done : https://admin.fedoraproject.org/updates/josm-0-0.7.3329svn.fc13 This works! Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger than the one generated by the authors (4 MB)? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #63 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-06-22 12:28:49 EDT --- Created an attachment (id=426002) -- (https://bugzilla.redhat.com/attachment.cgi?id=426002) Wrapper script for josm, with classpath definition -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 ELMORABITY Mohamed pikachu.2...@gmail.com changed: What|Removed |Added CC||pikachu.2...@gmail.com --- Comment #64 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-06-22 12:30:33 EDT --- (In reply to comment #62) Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger than the one generated by the authors (4 MB)? Because this package is not valid, accorded to the guidelines. It embeds dependencies, whereas it is forbidden: https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software Upstream voluntarily embeds metadata-extractor.jar (see build.xml). This should not be the case. Moreover, I don't understand why you also embed commons-codec.jar and ant.jar with your patch josm-0-bzip2.patch. Please don't embed dependencies, you'd better modify your wrapper to set these dependencies in the classpath. By the way, is commons-codec really required? If ant is called in the code, I can't find any call to commons-codec. So: 1) remove the patch josm-0-bzip2.patch 2) try to remove (with a patch for example) the following line in build.xml: zipfileset src=lib/metadata-extractor-2.3.1-nosun.jar / 3) replace your wrapper script with the one attached in this review (josm.wrapper) 4) add ant and metadata-extractor as Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #65 from Alex Lancaster al...@users.sourceforge.net 2010-06-22 13:16:18 EDT --- (In reply to comment #64) (In reply to comment #62) Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger than the one generated by the authors (4 MB)? Because this package is not valid, accorded to the guidelines. It embeds dependencies, whereas it is forbidden: https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software That shouldn't be the case according to the review in comment #49, it claims: + The package does NOT bundle copies of system libraries. It appears that the reviewer may have missed that jars were still being bundled, even though it seems that from comment #2 some bundled jars were identified and (apparently) removed around comment #4, but some may have been added since. 4) add ant and metadata-extractor as Requires. Actually the installation pulls in the metadata-extractor as a separate package so the Requires appear OK, it's just that the .class files for that package are duplicated inside josm.jar, so apparently the packager didn't remove them properly from the created josm.jar This needs to be fixed before this bug is closed as it appears the package passed review prematurely. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #66 from Alex Lancaster al...@users.sourceforge.net 2010-06-22 13:17:38 EDT --- Just to show the duplication: $ jar tvf /usr/share/java/josm.jar |grep metadata|head -10 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/ 1128 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/DefaultTagDescriptor.class 12498 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Directory.class 1947 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Metadata.class 695 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataException.class 247 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataReader.class 2936 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/SampleUsage.class 1801 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Tag.class 574 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/TagDescriptor.class 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/exif/ $ jar tvf /usr/share/java/metadata-extractor.jar|grep metadata|head -10 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/ 1128 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/DefaultTagDescriptor.class 12498 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Directory.class 1947 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Metadata.class 695 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataException.class 247 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataReader.class 2936 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/SampleUsage.class 1801 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Tag.class 574 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/TagDescriptor.class 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/exif/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #67 from Alex Lancaster al...@users.sourceforge.net 2010-06-22 13:26:18 EDT --- Likewise issues with commons-codec (provided within the jakarta-commons-codec package): $ jar tvf josm.jar |grep apache|head -10 0 Tue Jan 01 00:00:00 EST 1980 org/apache/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/ 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryDecoder.class 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryEncoder.class 588 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/CharEncoding.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Decoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/DecoderException.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Encoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/EncoderException.class $ jar tvf /usr/share/java/commons-codec.jar|grep apache|head -10 0 Tue Jan 01 00:00:00 EST 1980 org/apache/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/ 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryDecoder.class 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryEncoder.class 588 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/CharEncoding.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Decoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/DecoderException.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Encoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/EncoderException.class -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #70 from Fedora Update System upda...@fedoraproject.org 2010-06-22 16:00:48 EDT --- josm-0-0.8.3329svn.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #69 from Fedora Update System upda...@fedoraproject.org 2010-06-22 15:58:43 EDT --- josm-0-0.8.3329svn.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #54 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-16 10:16:41 EDT --- Package updated to the last tested josm revision. http://cedric.olivier.free.fr/rpms/josm-3329-1/josm-0-0.1.3329svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3329-1/josm.spec Manual sub-package's description has been removed. Here is the related rpmlint output : rpmlint SPECS/josm.spec SPECS/josm.spec: W: invalid-url Source0: josm-0.3329svn.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint SRPMS/josm-0-0.1.3329svn.fc13.src.rpm josm.src: W: spelling-error %description -l en_US metadata - meta data, meta-data, metatarsus josm.src: W: strange-permission josm-generate-tarball.sh 0755L josm.src: W: invalid-url Source0: josm-0.3329svn.tar.gz 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #55 from Peter Lemenkov lemen...@gmail.com 2010-06-16 10:28:41 EDT --- Ok, I don't see any other issues, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #56 from Peter Lemenkov lemen...@gmail.com 2010-06-16 10:58:02 EDT --- Two missing things before you'll request cvs (easy-to-fix): - you should increase (sub)version each time when you're updating svn revisions (look at specfile changelog): 0-0.1.3329svn 0-0.4.3208svn should have been 0-0.5.3329svn - define - %global (just cosmetic) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #57 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-16 12:06:58 EDT --- Update released : http://cedric.olivier.free.fr/rpms/josm-3329-5/josm-0-0.5.3329svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3329-5/josm.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Cédric OLIVIER cedric.oliv...@free.fr changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #58 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-16 17:03:07 EDT --- New Package CVS Request === Package Name: josm Short Description: An editor for OpenStreetMap (OSM) Owners: cquad Branches: F-11 F-12 F-13 InitialCC: cquad -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #53 from Peter Lemenkov lemen...@gmail.com 2010-06-15 03:52:41 EDT --- Bogus manual sub-package's description still exists. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #52 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-14 15:41:36 EDT --- Thanks, It's now changed : http://cedric.olivier.free.fr/rpms/josm-3208-4/josm-0-0.4.3208svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3208-4/josm.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #48 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-11 14:59:54 EDT --- Thanks, It's now corrected : http://cedric.olivier.free.fr/rpms/josm-3208-3/josm-0-0.3.3208svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3208-3/josm.spec Here is the related rpmlint output : rpmlint SPECS/josm.spec SPECS/josm.spec: W: invalid-url Source0: josm-0.3208svn.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint SRPMS/josm-0-0.3.3208svn.fc13.src.rpm josm.src: W: spelling-error %description -l en_US metadata - meta data, meta-data, metatarsus josm.src: W: invalid-url Source0: josm-0.3208svn.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508351
--- Comment #49 from Peter Lemenkov lemen...@gmail.com 2010-06-11 15:55:58
EDT ---
Koji scratchbuild for F-13:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2245550
One note - I'm suspecting that description and definition of 'manual'
sub-package is a leftover, so it should be removed.
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent:
Sulaco ~/Desktop: rpmlint josm-*
josm.noarch: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
josm.noarch: W: file-not-utf8 /usr/share/doc/josm-0/CONTRIBUTION
josm-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs,
Java-docs, Javanese
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Sulaco ~/Desktop:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+/- The package meets the Packaging Guidelines, except issue with sub-package
'manual' mentioned above.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source (by checking
the sources, generated from attached script)
Sulaco ~/tmp: diff -ru josm-0 josm-0.from_script/
Sulaco ~/tmp: ls
josm-0 josm-0.from_script
Sulaco ~/tmp:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files (except javadoc)
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
+ The package includes a %{name}.desktop file, and that file is properly
installed with desktop-file-install in the %install section.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please, fix/comment issue with 'manual' sub-package, and I'll continue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #50 from Thibault North thibault.no...@gmail.com 2010-06-11 16:02:18 EDT --- Thanks! Oh well, I've introduced an small error in your SPEC with my previous sed line: sed -i 's/\r//g' CONTRIBUTION (no 'e' param, that's not perl !) Otherwise a file CONTRIBUTIONe is created and nothing happens. Sorry for that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #51 from Thibault North thibault.no...@gmail.com 2010-06-11 16:12:00 EDT --- This: josm.noarch: W: file-not-utf8 /usr/share/doc/josm-0/CONTRIBUTION Can be fixed using this: http://fedoraproject.org/wiki/Common_Rpmlint_issues#file-not-utf8 (But the source encoding should be found, considering iso8859-1 will let a few weird chars) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508351
--- Comment #47 from Thibault North thibault.no...@gmail.com 2010-06-07
10:29:09 EDT ---
Hi,
I've just tried that SPEC and it looks good.
TODO, imho :
- Please just remove the commented lines (macro could be interpreted anyways;
ok that shouldn't be a problem in that spec.)
- I guess josm-generate-tarball.sh should be 0755.
- The file /usr/share/doc/josm-0/CONTRIBUTION should be fixed using sed -ie
's/\r//g' CONTRIBUTION
Glad to see this package being included !
Here is the related rpmlint output :
[tno...@grouchy tmp]$ rpmlint
/home/tnorth/rpmbuild/SRPMS/josm-0-0.2.3208svn.fc12.src.rpm
josm.src: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
josm.src: W: strange-permission josm-generate-tarball.sh 0744
josm.src:20: W: macro-in-comment %{name}
josm.src:20: W: macro-in-comment %{svn_revision}
josm.src:110: W: macro-in-comment %{buildroot}
josm.src:110: W: macro-in-comment %{_bindir}
josm.src:111: W: macro-in-comment %SOURCE1
josm.src:111: W: macro-in-comment %{buildroot}
josm.src:111: W: macro-in-comment %{_bindir}
josm.src:111: W: macro-in-comment %{name}
josm.src:112: W: macro-in-comment %{buildroot}
josm.src:112: W: macro-in-comment %{_bindir}
josm.src:112: W: macro-in-comment %{name}
josm.src:118: W: macro-in-comment %{buildroot}
josm.src:118: W: macro-in-comment %{_mandir}
josm.src:119: W: macro-in-comment %SOURCE4
josm.src:119: W: macro-in-comment %{buildroot}
josm.src:119: W: macro-in-comment %{_mandir}
josm.src:120: W: macro-in-comment %{buildroot}
josm.src:120: W: macro-in-comment %{_mandir}
josm.src:120: W: macro-in-comment %{name}
josm.src: W: invalid-url Source0: josm-0.3208svn.tar.gz
1 packages and 0 specfiles checked; 0 errors, 22 warnings.
[tno...@grouchy tmp]$ rpmlint
/home/tnorth/rpmbuild/RPMS/noarch/josm-0-0.2.3208svn.fc12.noarch.rpm
josm.noarch: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
josm.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/josm-0/CONTRIBUTION
josm.noarch: W: file-not-utf8 /usr/share/doc/josm-0/CONTRIBUTION
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[tno...@grouchy tmp]$ rpmlint
/home/tnorth/rpmbuild/RPMS/noarch/josm-javadoc-0-0.2.3208svn.fc12.noarch.rpm
josm-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs,
Java-docs, Javanese
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #46 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-03 14:45:39 EDT --- It was a little mistake in the install section. I was done an install -d 755 Source. So a 755 directory was made wrongly. It's now corrected : http://cedric.olivier.free.fr/rpms/josm-3208-2/josm-0-0.2.3208svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3208-2/josm.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #45 from Alex Lancaster al...@users.sourceforge.net 2010-05-29 23:10:54 EDT --- (In reply to comment #44) Unblocking FE-NEEDSPONSOR - I just sponsored Cédric OLIVIER. OK, now that you are his sponsor, you need to complete the formal review. (All sponsors must be the reviewer of the sponsorees first package). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #43 from Cédric OLIVIER cedric.oliv...@free.fr 2010-05-14 03:30:34 EDT --- It's done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #44 from Peter Lemenkov lemen...@gmail.com 2010-05-14 03:34:59 EDT --- Unblocking FE-NEEDSPONSOR - I just sponsored Cédric OLIVIER. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508351
--- Comment #40 from Cédric OLIVIER cedric.oliv...@free.fr 2010-05-13
11:45:56 EDT ---
Sorry for this long silence, you can find an update with the last tested
version :
http://cedric.olivier.free.fr/rpms/josm-3208-1/josm-0-0.1.3208svn.fc12.src.rpm
http://cedric.olivier.free.fr/rpms/josm-3208-1/josm.spec
oauth is disabled until maven is updated on fedora or an other solution is
found.
org.apache.tools.bzip2 is removed from source file and it is ant package which
is used.
org.apache.commons.codec is removed from source file to use
jakarta-commons-codec package.
Actually theses jar files are added to josm final jar, is there a method to
link dynamically theses jar files ?
I don't know if it is possible to use %find_lang macro with this package. I
don't know how, because lange file aren't names %{name}.lang, but lang.po
rpmlint output :
josm.src: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
josm.src: W: strange-permission josm-generate-tarball.sh 0744
josm.src: W: invalid-url Source0: josm-0.3208svn.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
josm-generate-tarball is executable because it is needed to get source code
invalid-url : source code only available on svn (without tag)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #41 from Peter Lemenkov lemen...@gmail.com 2010-05-13 23:43:01 EDT --- I'll review it. Cedric, what is your FAS account? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #42 from Peter Lemenkov lemen...@gmail.com 2010-05-13 23:48:42 EDT --- Ah, just found - Cedric, please, add yourself to 'Fedora Packages CVS Commit' group, and I'll sponsor you: https://admin.fedoraproject.org/accounts/group/view/packager -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #37 from Guido Grazioli guido.grazi...@gmail.com 2010-04-10 05:21:11 EDT --- (In reply to comment #36) I tried this and it seems mockito is not yet available in Fedora. Anyway it seems that JOSM is using v1.1 while latest upstream is v1.2.1.1. Are these two API compatible? AFAIK Fedora should package the latest version. mockito itself depends on hamcrest (v1.1 already packaged) and objenesis (needs packager). Anyway, arent those tools only needed for code testing, ala junit? (pls correct me if i am wrong). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #38 from Guido Grazioli guido.grazi...@gmail.com 2010-04-10 11:20:39 EDT --- objenesis (www.objenesis.org) in turn depends on maven-plugin-timestamp (http://code.google.com/p/maven-timestamp-plugin): im working to package those two. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #39 from Guido Grazioli guido.grazi...@gmail.com 2010-04-10 13:50:49 EDT --- Review request for maven-timestamp-plugin: bug 581164 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #28 from Cédric OLIVIER cedric.oliv...@free.fr 2010-04-09 04:30:28 EDT --- Hello, I am sorry for this long time without update. My connectivity issues are resolved for two weeks ago. I have checked needs for update, there is a new dependence : signpost-core. It is a google code project : http://code.google.com/p/oauth-signpost/ I can't compile it because maven 2.0.11 seems needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #29 from Andrea Musuruane musur...@gmail.com 2010-04-09 05:13:29 EDT --- I'm glad to hear you are back. It seems to me that Apache bzip2 is also required. How do you want to go on? Maybe some of the 15 people in CC can help in packaging those dependencies. Can you also update the package to fix the above issues? Anyway, you have to follow this guideline to get sponsored: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group I suggest you to start ASAP :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #30 from Bill McGonigle bill-bugzilla.redhat@bfccomputing.com 2010-04-09 11:25:15 EDT --- I can't compile it because maven 2.0.11 seems needed. Hrm, maven 2.0.9 was released two years ago, but 2.0.8 is tagged for f13 and has been maintained as recently as September. I suppose that means there's some reason Fedora isn't tracking maven2 upstream (?), which might be a problem. I'll drop the maintainer a message to get some feedback. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #32 from Andrea Musuruane musur...@gmail.com 2010-04-09 13:06:06 EDT --- Debian has a patch to disable oauth: http://patch-tracker.debian.org/package/josm/0.0.svn3094-1 Another possibility is to make a build.xml file for ant to build oauth. Unluckily I haven't the required skills to do it myself but maybe some in CC has them. BTW, the other Debian patches look interesting too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #33 from Jeffrey C. Ollie j...@ocjtech.us 2010-04-09 13:14:31 EDT --- Please do not disable OAuth, until OSM can get some SSL security going your OSM password is sent in the clear every time you upload some changes. With OAuth your password is only sent in the clear once when the OAuth tokens are set up, thus reducing the risk that your OSM password is compromised. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #34 from D Haley my...@yahoo.com 2010-04-09 15:21:23 EDT --- Created an attachment (id=405625) -- (https://bugzilla.redhat.com/attachment.cgi?id=405625) oauth build xml example build with ant -f build-core.xml Dont forget to build your classpath with export CLASSPATH=`build-classpath junit mockito commons-codec` Of course you need all those jars installed via yum. Place build-core.xml in ./oauth/signpost/ , resultant jar is in ./signpost-code/dist/lib/signpost-core.jar -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #35 from D Haley my...@yahoo.com 2010-04-09 15:24:28 EDT --- Sorry, somehow this disappared from my above post: I built this under opensuse, as I am without a fedora box at the moment. There is no reasons it should be specific. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #36 from Andrea Musuruane musur...@gmail.com 2010-04-09 17:56:38 EDT --- (In reply to comment #33) Please do not disable OAuth, until OSM can get some SSL security going your OSM password is sent in the clear every time you upload some changes. With OAuth your password is only sent in the clear once when the OAuth tokens are set up, thus reducing the risk that your OSM password is compromised. The password is still sent in clear text as you noticed, even if only once per session. I believe there is little value added until a secure channel (e.g. https) will be used. (In reply to comment #34) Created an attachment (id=405625) -- (https://bugzilla.redhat.com/attachment.cgi?id=405625) [details] oauth build xml example I tried this and it seems mockito is not yet available in Fedora. Anyway it seems that JOSM is using v1.1 while latest upstream is v1.2.1.1. Are these two API compatible? AFAIK Fedora should package the latest version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #26 from Andrea Musuruane musur...@gmail.com 2010-04-08 08:35:22 EDT --- Ping again. I will close this bug as NOTABUG if no response is received within one week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #27 from Bill McGonigle bill-bugzilla.redhat@bfccomputing.com 2010-04-08 11:55:24 EDT --- Cédric OLIVIER said above he'd be having connectivity issues and it appears those aren't resolved. There are 15 people on the cc: list, so perhaps we need to find another maintainer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #25 from Andrea Musuruane musur...@gmail.com 2010-02-07 06:43:44 EST --- Ping. Any update about this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
