[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #34 from sawrub 2010-05-06 22:21:16 EDT --- @Christoph : Ok Have filed bug : https://bugzilla.redhat.com/show_bug.cgi?id=589826 to take care of the issue. @Hicham : There is only single copy of the plugin installed, via YUM. Also running and quiting rhythmbox from Console is working fine, its just through GUI the issue is with. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Christoph Wickert changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA --- Comment #33 from Christoph Wickert 2010-05-06 17:59:32 EDT --- This is not the place to discuss bugs, this is the review only. Please file a new bug against the proper package because people will hardly find a bug in rhythmbox-equalizer in the 'Package Review' component. BTW: I can quit rythmbox with the plugin enabled just fine, even if the equalizer windows is opened. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #32 from Hicham HAOUARI 2010-05-06 14:10:52 EDT --- also if you have two copies of the plugin ( ie system-wide and user one ) try removing the user plugin as it may cause trouble. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #30 from sawrub 2010-05-06 14:06:49 EDT --- Though disabling the plugin all works fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #31 from Hicham HAOUARI 2010-05-06 14:07:26 EDT --- try starting rhythmbox from the console and then try quitting and grab any useful output in case of quit failure. i don't have this issue in here -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 sawrub changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA | --- Comment #29 from sawrub 2010-05-06 14:00:45 EDT --- Rhythmbox fails to Quit with the plugin enabled. Besides that the plugin is working fine. Installed: rhythmbox-equalizer.x86_64 0:1.3-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #27 from Fedora Update System 2010-05-05 23:39:40 EDT --- rhythmbox-equalizer-1.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #28 from Fedora Update System 2010-05-05 23:42:41 EDT --- rhythmbox-equalizer-1.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Fedora Update System changed: What|Removed |Added Fixed In Version|rhythmbox-equalizer-1.3-2.f |rhythmbox-equalizer-1.3-2.f |c13 |c11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Fedora Update System changed: What|Removed |Added Fixed In Version|rhythmbox-equalizer-1.3-2.f |rhythmbox-equalizer-1.3-2.f |c11 |c12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #26 from Fedora Update System 2010-05-05 03:25:01 EDT --- rhythmbox-equalizer-1.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rhythmbox-equalizer-1.3-2.f ||c13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #25 from Fedora Update System 2010-05-04 17:29:03 EDT --- rhythmbox-equalizer-1.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rhythmbox-equalizer-1.3-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #23 from Fedora Update System 2010-05-04 17:24:14 EDT --- rhythmbox-equalizer-1.3-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rhythmbox-equalizer-1.3-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #24 from Fedora Update System 2010-05-04 17:27:16 EDT --- rhythmbox-equalizer-1.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rhythmbox-equalizer-1.3-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #22 from Kevin Fenzi 2010-05-03 22:43:31 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #21 from Thomas Kowaliczek 2010-05-01 11:53:50 EDT --- Thank you Cwickert :) You know i´m not the best reviewer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #20 from Hicham HAOUARI 2010-05-01 10:12:05 EDT --- thanks Christoph, i will fix this upon initial import -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #19 from Christoph Wickert 2010-05-01 10:06:21 EDT --- No problem, you are welcome. BTW: The license tag is wrong, should be GPLv2+ instead of GPLv2, see http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#.22or_later_version.22_licenses -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #18 from Hicham HAOUARI 2010-05-01 10:03:57 EDT --- Thanks Christoph for helping this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #17 from Christoph Wickert 2010-05-01 09:58:34 EDT --- (In reply to comment #14) > This is beyond the scope of this ticket. Indeed, but as you maintain a plugin that might benefit from this change, you could take care of this. Arch independent plugins should go to /usr/share/rhythmobx/plugins, just like in Firefox. Filed as https://bugzilla.gnome.org/show_bug.cgi?id=617373 upstream. Please CC yourself to that bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Hicham HAOUARI changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #15 from Hicham HAOUARI 2010-05-01 09:50:46 EDT --- New Package CVS Request === Package Name: rhythmbox-equalizer Short Description: An Equalizer Plugin for Rhythmbox Owners: hicham Branches: F-11 F-12 F-13 InitialCC: hicham -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #14 from Hicham HAOUARI 2010-05-01 09:48:32 EDT --- (In reply to comment #13) > (In reply to comment #11) > > > rhythmbox-equalizer.x86_64: E: no-binary > > > rhythmbox-equalizer.x86_64: W: only-non-binary-in-usr-lib > > > > This package would have been ideally noarch, but since it installs files in > > arch dependant directories, there is no way to remove those warnings. > > Doesn't that mean that it is a bug in rhythmbox that it doesn't have an > arch-independent plugin directory? (I would expect it do something similar to > how x86_64 python uses both /usr/lib/python2.6/site-packages and > /usr/lib64/python2.6/site-packages.) > > Let's make Fedora ideal - and be pragmatic while we try ;-) This is beyond the scope of this ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #16 from Hicham HAOUARI 2010-05-01 09:51:17 EDT --- and thanks Thomas for reviewing this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #13 from Mads Kiilerich 2010-05-01 09:38:34 EDT --- (In reply to comment #11) > > rhythmbox-equalizer.x86_64: E: no-binary > > rhythmbox-equalizer.x86_64: W: only-non-binary-in-usr-lib > > This package would have been ideally noarch, but since it installs files in > arch dependant directories, there is no way to remove those warnings. Doesn't that mean that it is a bug in rhythmbox that it doesn't have an arch-independent plugin directory? (I would expect it do something similar to how x86_64 python uses both /usr/lib/python2.6/site-packages and /usr/lib64/python2.6/site-packages.) Let's make Fedora ideal - and be pragmatic while we try ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Thomas Kowaliczek changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #12 from Thomas Kowaliczek 2010-05-01 09:21:44 EDT --- Than it´s aporrvend by me i don´t found any problems with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #11 from Hicham HAOUARI 2010-05-01 08:27:05 EDT --- (In reply to comment #10) > That´s the only what i found maybe you can fix it? > > MUST: rpmlint must be run on every package. The output should be posted in the > review. > linuxdon...@localhost SPECS]$ rpmlint > /home/LinuxDonald/rpmbuild/RPMS/x86_64/rhythmbox-equalizer-1.3-2.fc12.x86_64.rpm > rhythmbox-equalizer.x86_64: W: spelling-error Summary(en_US) plugin -> plug > in, > plug-in, plugging the word "Plugin" is used like that within rhythmbox > rhythmbox-equalizer.x86_64: E: no-binary > rhythmbox-equalizer.x86_64: W: only-non-binary-in-usr-lib This package would have been ideally noarch, but since it installs files in arch dependant directories, there is no way to remove those warnings. > 1 packages and 0 specfiles checked; 1 errors, 2 warnings. > [linuxdon...@localhost SPECS]$ > > When not it is okay too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #10 from Thomas Kowaliczek 2010-05-01 08:14:20 EDT --- That´s the only what i found maybe you can fix it? MUST: rpmlint must be run on every package. The output should be posted in the review. linuxdon...@localhost SPECS]$ rpmlint /home/LinuxDonald/rpmbuild/RPMS/x86_64/rhythmbox-equalizer-1.3-2.fc12.x86_64.rpm rhythmbox-equalizer.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging rhythmbox-equalizer.x86_64: E: no-binary rhythmbox-equalizer.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 2 warnings. [linuxdon...@localhost SPECS]$ When not it is okay too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511107
--- Comment #9 from Thomas Kowaliczek 2010-05-01
08:13:40 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.
linuxdon...@localhost SPECS]$ rpmlint
/home/LinuxDonald/rpmbuild/RPMS/x86_64/rhythmbox-equalizer-1.3-2.fc12.x86_64.rpm
rhythmbox-equalizer.x86_64: W: spelling-error Summary(en_US) plugin -> plug in,
plug-in, plugging
rhythmbox-equalizer.x86_64: E: no-binary
rhythmbox-equalizer.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
[linuxdon...@localhost SPECS]$
MUST: The package must be named according to the Package Naming Guidelines.
Okay
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
Okay
MUST: The package must meet the Packaging Guidelines.
Okay
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
Okay
MUST: The License field in the package spec file must match the actual license.
Okay
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Okay
MUST: The spec file must be written in American English.
Okay
MUST: The spec file for the package MUST be legible.
Okay
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Okay
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Okay
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Okay
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Okay
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Okay
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
Okay
MUST: Packages must NOT bundle copies of system libraries.
Okay
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
Okay
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
Okay
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
Okay
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Okay
MUST: Each package must consistently use macros.
Okay
MUST: The package must contain code, or permissable content.
Okay
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
Okay
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
Okay
MUST: Header files must be in a -devel package.
Okay
MUST: Static libraries must be in a -static package.
Okay
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
Okay
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
Okay
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
Okay
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop fil
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Thomas Kowaliczek changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|linuxdon...@linuxdonald.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #8 from Hicham HAOUARI 2010-04-15 12:04:53 EDT --- Created a small patch to workaround the problem http://hicham.fedorapeople.org/rhythmbox-equalizer-1.3-fix-presets-per-user.patch Spec URL : http://hicham.fedorapeople.org/rhythmbox-equalizer.spec SRPM URL : http://hicham.fedorapeople.org/rhythmbox-equalizer-1.3-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 --- Comment #7 from Thomas Kowaliczek 2010-04-12 23:53:47 EDT --- I think the best would be to wait what upstream say. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Hicham HAOUARI changed: What|Removed |Added Flag|needinfo?(hicham.haou...@gm | |ail.com)| --- Comment #6 from Hicham HAOUARI 2010-04-12 17:10:08 EDT --- There is a blocker to 1.3, i reported it upstream in : http://code.google.com/p/rbeq/issues/detail?id=6 I have three options now : - Patch it to use gconf for presets - Wait for upstream to do it - Disable save button I don't know which one to choose yet -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Thomas Kowaliczek changed: What|Removed |Added Flag||needinfo?(hicham.haou...@gm ||ail.com) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511107] Review Request: rhythmbox-equalizer - An Equalizer plugin for Rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511107 Thomas Kowaliczek changed: What|Removed |Added CC||linuxdon...@linuxdonald.de --- Comment #5 from Thomas Kowaliczek 2010-03-28 19:58:36 EDT --- Please update it too version 1.3 and i will review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
