[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gedit-valencia-0.3.0-4.fc13 Resolution||ERRATA Last Closed|2010-05-24 00:12:15 |2010-12-13 15:03:23 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Fedora Update System changed: What|Removed |Added Fixed In Version|gedit-valencia-0.3.0-4.fc13 |gedit-valencia-0.3.0-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #19 from Fedora Update System 2010-12-13 15:04:34 EST --- gedit-valencia-0.3.0-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #18 from Fedora Update System 2010-12-13 15:03:10 EST --- gedit-valencia-0.3.0-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System 2010-11-27 18:37:11 EST --- gedit-valencia-0.3.0-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gedit-valencia'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/gedit-valencia-0.3.0-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #16 from Fedora Update System 2010-11-27 09:35:41 EST --- gedit-valencia-0.3.0-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gedit-valencia-0.3.0-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #15 from Fedora Update System 2010-11-27 09:35:35 EST --- gedit-valencia-0.3.0-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/gedit-valencia-0.3.0-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #14 from Jason Tibbitts 2010-11-25 13:57:19 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Michel Alexandre Salim changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Michel Alexandre Salim 2010-11-25 06:01:43 EST --- (In reply to comment #12) > The URL you gave for the source RPM is incorrect, should be release 3. Ah, of course. Sorry about that. > APPROVED Thanks! New Package SCM Request === Package Name: gedit-valencia Short Description: A gedit plugin providing lightweight Vala IDE Owners: salimma Branches: f13 f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Eric Smith changed: What|Removed |Added Flag|fedora-review?, |fedora-review+ |needinfo?(e...@brouhaha.com | |) | --- Comment #12 from Eric Smith 2010-11-20 17:25:11 EST --- The URL you gave for the source RPM is incorrect, should be release 3. All issues have been addressed. This package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #11 from Michel Alexandre Salim 2010-11-06 11:11:31 EDT --- ping. Eric, would it be possible to get this review finished soon? The other Vala plugin for gedit, vtg (gedit-vala) is currently not buildable on Rawhide, so we have no lightweight editing solution there ATM. Thanks -- Michel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Michel Alexandre Salim changed: What|Removed |Added Flag||needinfo?(e...@brouhaha.com ||) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #10 from Michel Alexandre Salim 2010-10-19 12:20:05 EDT --- Apologies for the delay! Start of the semester here, been busy preparing. Thanks for mentioning the optimization flags -- I just noticed that I need to pass them as VFLAGS, and need to pair each GCC option with its own -X. Done now. I've disabled debuginfo generation for now, and stripped the library file by hand, because it looks like even after passing -g, the sources are still not being packaged in -debuginfo. I'm looking at the script right now but my hunch is that /usr/lib/rpm/find-debuginfo.sh does not know how to handle Vala sources (yet). (ref: https://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_other_reasons ) http://salimma.fedorapeople.org/specs/gnome/gedit-valencia.spec http://salimma.fedorapeople.org/specs/gnome/gedit-valencia-0.3.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518892
Eric Smith changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Comment #9 from Eric Smith 2010-10-02 19:44:19 EDT ---
Review summary:
* Fails rpmlint due to debuginfo without sources. May need to patch Makefile
to pass "-g" option to valac. Possibly should arrange to pass make's CFLAGS as
arguments to valac's -X option, to be passed to C compiler.
Review detail:
[FAIL] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint *.rpm *.spec
gedit-valencia.i686: W: spelling-error Summary(en_US) plugin -> plug in,
plug-in, plugging
gedit-valencia.i686: W: spelling-error %description -l en_US plugin -> plug in,
plug-in, plugging
gedit-valencia.i686: W: spelling-error %description -l en_US tooltips -> tool
tips, tool-tips, toolkit
gedit-valencia.i686: W: spelling-error %description -l en_US autocompletion ->
auto completion, auto-completion, incompletion
gedit-valencia.i686: W: spelling-error %description -l en_US autocomplete ->
auto complete, auto-complete, completeness
gedit-valencia.src: W: spelling-error Summary(en_US) plugin -> plug in,
plug-in, plugging
gedit-valencia.src: W: spelling-error %description -l en_US plugin -> plug in,
plug-in, plugging
gedit-valencia.src: W: spelling-error %description -l en_US tooltips -> tool
tips, tool-tips, toolkit
gedit-valencia.src: W: spelling-error %description -l en_US autocompletion ->
auto completion, auto-completion, incompletion
gedit-valencia.src: W: spelling-error %description -l en_US autocomplete ->
auto complete, auto-complete, completeness
gedit-valencia.x86_64: W: spelling-error Summary(en_US) plugin -> plug in,
plug-in, plugging
gedit-valencia.x86_64: W: spelling-error %description -l en_US plugin -> plug
in, plug-in, plugging
gedit-valencia.x86_64: W: spelling-error %description -l en_US tooltips -> tool
tips, tool-tips, toolkit
gedit-valencia.x86_64: W: spelling-error %description -l en_US autocompletion
-> auto completion, auto-completion, incompletion
gedit-valencia.x86_64: W: spelling-error %description -l en_US autocomplete ->
auto complete, auto-complete, completeness
gedit-valencia-debuginfo.i686: E: debuginfo-without-sources
gedit-valencia-debuginfo.x86_64: E: debuginfo-without-sources
5 packages and 1 specfiles checked; 2 errors, 15 warnings.
[OK] MUST: The package must be named according to the Package Naming
Guidelines.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines.
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL.
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines.
[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[OK] MUST: Permissions on files must be set properly. Executables s
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518892
--- Comment #8 from Michel Alexandre Salim
2010-09-22 04:16:42 EDT ---
Hi Eric,
I will be planning to push this for F13, but the build problem is currently
because of an abortive attempt to update Vala on F-13. We have a Vala build
with the new-style API, and it's currently in the dist-f13-override tree
(meaning it's used when packages being built requested Vala) but not pushed out
as an update. I've requested the release engineering team to remove it from the
overrides.
For now F-13 builds should work if you build locally against the vala-0.9.3
that is publicly available there, and F-14+ should work just fine. If you want
to build on F-13 with Koji, change the version guard here:
%if 0%{?fedora} >=14 || 0%{?rhel} >= 6
replacing 14 with 13.
Thanks!
Oh, could you change the status to ASSIGNED and set the fedora-review flag? We
don't want to clutter up the review queue, it's clogged up enough as it is.
Thanks again.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Eric Smith changed: What|Removed |Added CC||e...@brouhaha.com AssignedTo|nob...@fedoraproject.org|e...@brouhaha.com --- Comment #7 from Eric Smith 2010-09-21 22:27:17 EDT --- Koji scratch build for F13 i686 failed, complaining about missing pkg-config vala-1.0.pc http://koji.fedoraproject.org/koji/taskinfo?taskID=2480847 Are you planning to push this for F13? If not, I'll proceed with review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #6 from Michel Alexandre Salim 2010-09-15 07:29:15 EDT --- Updated to also build against the newer Vala >= 0.9.5 http://salimma.fedorapeople.org/specs/gnome/gedit-valencia.spec http://salimma.fedorapeople.org/specs/gnome/gedit-valencia-0.3.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Michel Alexandre Salim changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|DEFERRED| --- Comment #5 from Michel Alexandre Salim 2010-07-26 10:31:12 EDT --- Hi Rakesh, I've just updated the specs for 0.3.0 -- from my testing it works fine with the current Vala 0.8.x and 0.9.x that we ship in F-12, F-13 and EL-6. Feel free to start the review: http://salimma.fedorapeople.org/specs/gnome/gedit-valencia.spec http://salimma.fedorapeople.org/specs/gnome/gedit-valencia-0.3.0-1.fc13.src.rpm Thanks, -- Michel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #4 from Michel Alexandre Salim 2010-05-24 07:08:48 EDT --- It will have to stay deferred for quite a bit longer, I'm afraid -- waiting on upstream releasing 0.3, which is taking a while. They also develop Shotwell so I'm guessing most of the work goes there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 Rakesh Pandit changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED --- Comment #3 from Rakesh Pandit 2010-05-24 00:12:15 EDT --- Open this when you enough time to invest in proceeding. Thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518892] Review Request: gedit-valencia - A gedit plugin providing lightweight Vala IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518892 --- Comment #2 from Rakesh Pandit 2010-05-17 04:00:41 EDT --- Michel, It has been three months In case you did addressed above issue in a week I will mark this request as deferred. -- Regards, Rakesh Pandit -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
