[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #15 from Fedora Update System  
2011-03-28 23:56:00 EDT ---
python-setuptools_trial-0.5.12-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-setuptools_trial-0.5
   ||.12-1.fc15
 Resolution||ERRATA
Last Closed||2011-03-28 23:56:05

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #9 from Ruben Kerkhof  2011-03-09 13:14:45 
EST ---
New version here:

SPEC:
http://ruben.fedorapeople.org/python-setuptools_trial.spec
SRPM:
http://ruben.fedorapeople.org/python-setuptools_trial-0.5.12-1.fc16.src.rpm

Darcs isn't used anymore and removed from the tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Toshio Ernie Kuratomi  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Toshio Ernie Kuratomi  2011-03-21 
16:37:40 EDT ---
All blockers fixed.  APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Ruben Kerkhof  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #11 from Ruben Kerkhof  2011-03-21 22:55:32 
EDT ---
New Package SCM Request
===
Package Name: python-setuptools_trial
Short Description: Setuptools plugin that makes unit tests execute with trial
instead of pyunit
Owners: ruben
Branches: f15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #12 from Kevin Fenzi  2011-03-21 23:15:03 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #13 from Fedora Update System  
2011-03-23 08:56:21 EDT ---
python-setuptools_trial-0.5.12-1.fc15 has been submitted as an update for
Fedora 15.
https://admin.fedoraproject.org/updates/python-setuptools_trial-0.5.12-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2011-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #14 from Fedora Update System  
2011-03-24 02:56:12 EDT ---
python-setuptools_trial-0.5.12-1.fc15 has been pushed to the Fedora 15 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Chen Lei  changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #6 from Chen Lei  2010-06-06 01:56:02 EDT ---
Is there any reason to del requires.txt in egg-info?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #7 from Ruben Kerkhof  2010-06-06 07:19:47 
EDT ---
In reply to comment #5:

> - upstream released a new version

Ok, here's version 0.5.9:
SPEC:
http://ruben.fedorapeople.org/python-setuptools_trial.spec
SRPM:
http://ruben.fedorapeople.org/python-setuptools_trial-0.5.9-1.fc14.src.rpm

> could you please be a bit more specific in %files, so you know, if the
> egg is build?

Sure, done

> I didn't found a not on upstreams webpage, if python3 is supported
> and what their plans are (releasing two different tarballs, or is
> 2to3 supposed to run?
> Could you ask them please?

I haven't heard anything about python3 from upstream (yet). They're busy
releasing a new version right now, so I suspect it can take a while. It surely
doesn't have a hight priority.

In reply to comment #6

> Is there any reason to del requires.txt in egg-info?

Not that I can remember, it's been a while since I started with this package.
Removed, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Toshio Ernie Kuratomi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||a.bad...@gmail.com
 AssignedTo|nob...@fedoraproject.org|a.bad...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Toshio Ernie Kuratomi  changed:

   What|Removed |Added

   Flag||fedora-review?

--- Comment #8 from Toshio Ernie Kuratomi  2010-11-04 
10:14:36 EDT ---
NEEDSWORK

Good:
* Named according to the naming guidelines (there's an underscore in all the
  upstream references to this name.)
* license is BSD which is approved
* spec file is readable
* Source matches upstream
* No locale files
* No shared libraries
* Not relocatable
* No file listed multiple times
* Permissions set properly
* Package consistently uses macros
* Code not content
* Nothing in doc affects runtime
* Not a GUI application
* Does not bundle libraries in the built rpm but see below
* filenames are valid utf8
* Does not own files owned by other packages
* Owns all directories it creates

Needswork:
* Does not build in koji.  The build looks for the setuptools_darcs package.
  This does not appear to be needed (only for creating sdists, not for the
  built package that we're doing so you can remove the line from the setup.py
that adds this to requires.
* setuptools_darcs code is present in the tarball.  However, it is not being
  used in the build.  The FPC is looking at new guidelines that say to remove
  such code (to make sure that it isn't being used in the build) so be ready
  for that potential guideline change.
  https://fedoraproject.org/wiki/PackagingDrafts/Treatment_Of_Bundled_Libraries

Rpmlint:
srpm and binary rpm share these warnings:

python-setuptools_trial.src: W: spelling-error %description -l en_US Setuptools
-> Setup tools, Setup-tools, Setups
python-setuptools_trial.src: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
python-setuptools_trial.src: W: spelling-error %description -l en_US pyunit ->
pyuria, punitive, impunity

These are all common words in computer jargon or proper names so these are
false positives.


Fix the building problems and I'll give it one more look.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #2 from Ruben Kerkhof  2010-02-24 12:09:07 
EST ---
Thanks for the review.

>> python-setuptools_trial.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 
>> 4,
>> tab: line 17)

Fixed.

>> As per declaration on .spec file, a copy of BSD license is needed to be
>> included. Please add.

This is not required, the package doesn't include a license file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #3 from Ruben Kerkhof  2010-02-24 12:30:35 
EST ---
New version here:

SPEC:
http://ruben.fedorapeople.org/python-setuptools_trial.spec
SRPM:
http://ruben.fedorapeople.org/python-setuptools_trial-0.5.3-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-04-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

--- Comment #4 from Ruben Kerkhof  2010-04-07 11:26:51 
EDT ---
Ok, upstream has added a license file at our request.

SPEC:
http://ruben.fedorapeople.org/python-setuptools_trial.spec
SRPM:
http://ruben.fedorapeople.org/python-setuptools_trial-0.5.6-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit

2010-04-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523034

Thomas Spura  changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org

--- Comment #5 from Thomas Spura  2010-04-29 
05:28:09 EDT ---
Just a few comments/questions for now:

- upstream released a new version

- could you please be a bit more specific in %files, so you know, if the egg is
build?

- I didn't found a not on upstreams webpage, if python3 is supported and what
their plans are (releasing two different tarballs, or is 2to3 supposed to run?
  Could you ask them please?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review